July 2016 - Koha-bugs - lists.koha-community.org

[Bug 10492] Translation problems with TT directives in po files
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16871 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53157|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53177&action=ed… Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt Signed-off-by: Srdjan <srdjan(a)catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> This patch adds the same tests in the aoColumns DT definition than the ones in the creation of the table. That's sound good. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14722] Refactor the catalogue export tool (command-line tools/ export.pl does not work anymore. Use misc/export_records.pl instead)
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 [Bug 16859] Fix wrong item field name in export.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #63 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have squashed 2 patches for the readability. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #62 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53175&action=ed… Bug 3534: Force margin-left: 0 for second button When quick adding a new patron, both button are in the DOM and the second button has a margin-left (from .btn-toolbar > .btn + .btn). This patch force the margin-left to 0 to avoid the button to move when toggling them. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #61 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53174&action=ed… Bug 3534 (QA Followup) Rebase and change floating save Bug 3534 - (QA Followup) Use single toolbar for regular/quickadd forms Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #60 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53173&action=ed… Bug 3534 (QA Followup) Fix indentation, show guarantor form, ignore bad data in pref Switch incorrect == to != when checking skipped fields Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #59 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53172&action=ed… Bug 3534 - QA Followup - use floating save I am not sure if this is desired, it makes sense for consistency but floats in a wierd place for a short form. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52934|0 |1 is obsolete| | Attachment #52935|0 |1 is obsolete| | Attachment #52936|0 |1 is obsolete| | Attachment #52937|0 |1 is obsolete| | Attachment #53152|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53171&action=ed… Bug 3534 - Patron quick add form This patch adds a new system preference: PatronQuickAddFields When either this pref or BorrowerMandatoryField is populated this will add a new dropdown to the bew patron toolbar. When a category is chosen from this dropdown the fields in PatronQuickAddFields and BorrowerMandatoryField will be displayed. There will be a button allowing a user to switch from the quickadd to the full form and fields will be copied between the forms when toggling. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields and note the new button for adding a patron 5 - Click the Quick add and choose a type 6 - Only required or quick add fields should be displayed 7 - Verify toggling forms copies information 8 - Ensure you cannot save patron without filling required fields (quick add fields should be optional) 9 - Ensure you can save patron with fields filled out 10 - Ensure that a duplicate patron brings up the duplicate/add new buttons with full form displayed 11 - Verify that subsequent edits use only full form 12 - Verify that data on form submitted is the data saved to patron 13 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries) Followed test plan, works as expected. Re-tested together with followup, works as expected (2016-06-02) Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0