July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9259] Delete marc batches from staged marc management
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '16

07 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 --- Comment #15 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- (In reply to Jonathan Druart from comment #14) > To enhance: > Maybe DeleteBatch should check if the batch has been cleaned before deleting > it. > I thought about this, but the DeleteBatch function can only be called if the status has been set to cleaned (the user can't see the button), so thought I could get away with skipping that :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10492] Translation problems with TT directives in po files
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16559 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #57 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #55) > I think you should trick the code to have only 1 toolbar for the 2 forms. > You will need to add a flag to check, to know which form we want to save. Indeed, combined to one toolbar, removed 'onclick' action from regular save and redirected to a js function -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53109|0 |1 is obsolete| | --- Comment #56 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 53152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53152&action=ed… Bug 3534 - (QA Followup) Use single toolbar for regular/quickadd forms -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #64 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have squashed 2 patches, for readability. Note that QA tools complains: FAIL t/db_dependent/Patron/CheckPrevCheckout.t FAIL git manipulation The file has been added and deleted in the same patchset But first patch has been signed off and the other one is a qa-followup, so it's ok by me. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #63 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53148&action=ed… Bug 6906: Add updated schema files. * Koha/Schema/Result/Borrower.pm: Updated schema file. * Koha/Schema/Result/Category.pm: Updated schema file. * Koha/Schema/Result/Deletedborrower.pm: Updated schema file. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #62 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53147&action=ed… Bug 6906: Follow coding guidelines in terminology. * Koha/Patron.pm (wantsCheckPrevCheckout, doCheckPrevCheckout): Rename to... (wants_check_for_previous_checkout, do_check_for_previous_checkout): ...this. * C4/Circulation.pm: Use new names. * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. Bug 6906: Fix POD reference to old method name. * Koha/Patron.pm (wants_check_for_previous_checkout): Fix POD. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #61 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53146&action=ed… Bug 6906: Add the warning message to the batch checkout Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0