July 2016 - Koha-bugs - lists.koha-community.org

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53109|0 |1 is obsolete| | --- Comment #56 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 53152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53152&action=ed… Bug 3534 - (QA Followup) Use single toolbar for regular/quickadd forms -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #64 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have squashed 2 patches, for readability. Note that QA tools complains: FAIL t/db_dependent/Patron/CheckPrevCheckout.t FAIL git manipulation The file has been added and deleted in the same patchset But first patch has been signed off and the other one is a qa-followup, so it's ok by me. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #63 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53148&action=ed… Bug 6906: Add updated schema files. * Koha/Schema/Result/Borrower.pm: Updated schema file. * Koha/Schema/Result/Category.pm: Updated schema file. * Koha/Schema/Result/Deletedborrower.pm: Updated schema file. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #62 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53147&action=ed… Bug 6906: Follow coding guidelines in terminology. * Koha/Patron.pm (wantsCheckPrevCheckout, doCheckPrevCheckout): Rename to... (wants_check_for_previous_checkout, do_check_for_previous_checkout): ...this. * C4/Circulation.pm: Use new names. * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. Bug 6906: Fix POD reference to old method name. * Koha/Patron.pm (wants_check_for_previous_checkout): Fix POD. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #61 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53146&action=ed… Bug 6906: Add the warning message to the batch checkout Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #60 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53145&action=ed… Bug 6906: Tests - Do not assume CPL exists Since bug 14878, tests must create the data they need to pass and not assume they exist. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52278|0 |1 is obsolete| | Attachment #52279|0 |1 is obsolete| | Attachment #52280|0 |1 is obsolete| | Attachment #53104|0 |1 is obsolete| | Attachment #53105|0 |1 is obsolete| | Attachment #53136|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53144&action=ed… Bug 6906 - show 'Borrower has previously issued... New feature: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their checkout history. - Global syspref ('CheckPrevCheckout'), set to 'hardno' by default, allows users to enable this feature library wide. - Per patron category pref allows libraries to create overrides per category, falling back on the global setting by default. - Per patron pref allows switching the functionality on at the level of patron. Fall-back to category settings by default. * Koha/Patron (wantsCheckPrevCheckout, doCheckPrevCheckout): New methods. * C4/Circulation.pm (CanBookBeIssued): Introduce CheckPrevCheckout check. * admin/categories.pl: Pass along checkprevcheckout. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Expose CheckPrevCheckout per category setting. * koha-tmpl/intranet-tmpl/prog/en/modules/preferences/patrons.pref: Expose CheckPrevCheckout syspref. * koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Expose per patron CheckPrevCheckout preference. * koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Expose per patron CheckPrevCheckout preference. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVCHECKOUT' confirmation message. * installer/data/mysql/kohastructure.sql: Modify structure of 'categories', 'borrowers', 'oldborrowers'. * installer/data/mysql/sysprefs.sql: Add 'CheckPrevCheckout'. * installer/data/mysql/atomicupdate/checkPrevCheckout.sql: New file. * t/db_dependent/Patron/CheckPrevCheckout.t: New file with unit tests. Test plan: - Apply patch. - Run updatedatabase. - Regenerate Koha Schema files. - Run the unit tests. - Verify 'CheckPrevCheckout' is visible in Patrons sysprefs and can be switched to 'hardyes', 'softyes', 'softno' and 'hardno'. + Check out previously checked out items to a patron, checking the message appears as expected. - Verify no 'Check previous checkouts' setting appears on the borrower category pages if the syspref is set to a 'hard' option. - Verify 'Check previous checkouts' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting if that is set to a 'soft' option). - Verify no 'Check previous checkouts' setting appears on the individual borrower pages if the syspref is set to a 'hard' option. - Verify 'Check previous checkouts' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting if the latter is set to a 'soft' option). Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #58 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Alex Sassmannshausen from comment #57) > (In reply to Jonathan Druart from comment #52) > > (In reply to Alex Sassmannshausen from comment #49) > > > * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... > > > * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. > > > > Why? :) > > It struck me there was a pattern to the naming of the test files, I decided > to stick with that. Ha yes, got it! Actually the methods of Koha::Patron are tested in subtests of t/db_dependent/Koha/Patrons.t So it would make to move yours there. But it's 400 lines, so maybe not... Actually we have t/db_dependent/Patron.t t/db_dependent/Patrons.t t/db_dependent/Patron/*.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patron/*.t It's a bit... confusing, I agree :) So let's keep it as it, and I will try to clean that on another bug report. > > (In reply to Alex Sassmannshausen from comment #51) > > > - One patch now adds updated schema files for dbic. This will fix the test > > > error (previously I assumed the tester would do this, but since the last > > > hackfest I no longer make that assumption). > > > > AFAIK that is still the case. > > Actually I personally submit a patch with a DONT_PUSH pattern in the commit > > message and let the RM generate the schema by himself. > > Interesting — I see the reason why you'd add DONT_PUSH — presumably to make > it clear to the RM that they should generate the schema files themselves… > > To clarify: do you literally just dump DONT_PUSH somewhere in the commit > message? > > Or is it part of the subject line or has a special location? Beginning of the commit message, something like: Bug 12345: [DO NOT PUSH] Schema files That could be a topic for the next meeting, in order to clarify things for everybody. Kyle, any thoughts? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 9259] Delete marc batches from staged marc management
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|batch delete marc batches |Delete marc batches from | |staged marc management -- You are receiving this mail because: You are watching all bug changes.

1 0