July 2016 - Koha-bugs - lists.koha-community.org

[Bug 9259] batch delete marc batches
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16862 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9259] batch delete marc batches
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- To enhance: Maybe DeleteBatch should check if the batch has been cleaned before deleting it. Note that the patch is not perfect but follow the existing pattern of this module. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9259] batch delete marc batches
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53140&action=ed… Bug 9259: Use is instead of is_deeply Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9259] batch delete marc batches
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53116|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53139&action=ed… Bug 9259: Ability to delete a staged file once it has been cleaned To test: 1) Go to Tools -> Staged MARC Management and clean a file. If you have no files to clean, go to 'Stage MARC for import' and upload one to clean following the necessary steps. 2) Confirm that once the file has been cleaned, the Action column now shows a Delete button. Confirm this button only shows for cleaned files. 3) Click the Delete button. 4) Confirm that clicking Cancel exits the pop-up message and does not delete the file. 5) Confirm that clicking OK refreshes the list of staged records and the one you just deleted is no longer on it (has been deleted). You can confirm this by checking for the file in mysql (SELECT * FROM import_batches WHERE import_batch_id = X;) 6) Run prove -v t/db_dependent/ImportBatch.t (have written unit tests for CleanBatch and DeleteBatch) Sponsored-by: Catalyst IT Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> Catalyst sign off, so needs another one but YAY this is great. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9259] batch delete marc batches
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #57 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- (In reply to Jonathan Druart from comment #52) > (In reply to Alex Sassmannshausen from comment #49) > > * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... > > * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. > > Why? :) It struck me there was a pattern to the naming of the test files, I decided to stick with that. > (In reply to Alex Sassmannshausen from comment #51) > > - One patch now adds updated schema files for dbic. This will fix the test > > error (previously I assumed the tester would do this, but since the last > > hackfest I no longer make that assumption). > > AFAIK that is still the case. > Actually I personally submit a patch with a DONT_PUSH pattern in the commit > message and let the RM generate the schema by himself. Interesting — I see the reason why you'd add DONT_PUSH — presumably to make it clear to the RM that they should generate the schema files themselves… To clarify: do you literally just dump DONT_PUSH somewhere in the commit message? Or is it part of the subject line or has a special location? Alex -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14334] DBI fighting DBIx over Autocommit in tests
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #25 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Jonathan Druart from comment #23) > Created attachment 40184 [details] [review] > [ FOR DISCUSSION ] Bug 14334: Add a Database module for db dependent tests > > What about something like that to avoid c/p? +1 I like this. If I get back to this bug, I'll use that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #56 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #52) > (In reply to Alex Sassmannshausen from comment #49) > > * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... > > * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. > > Why? :) It seems that you missed this one -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14722] Refactor the catalogue export tool (command-line tools/ export.pl does not work anymore. Use misc/export_records.pl instead)
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 [Bug 16855] Poor performance due to high overhead of SQL call in export.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11698] Add validity check for amount on budget page
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '16

06 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11698 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16832 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0