July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53045&action=ed… Bug 15128: Do not display "New suggestion" if limit has just been reached If limit is X and patrons has X-1 pending suggestions, when a new one is added, the "New suggestion" should not been added. to avoid another call to SearchSuggestions, we assume than the suggestion has been correctly added. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53044&action=ed… Bug 15128: Revert Display all purchase suggestions whether or not suggestion was added This does not work correctly and should be handle on another bug report. The behavior existed prior to this patchset. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53034|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53043&action=ed… Bug 15128 - (QA Followup) Don't get patrons suggestions if limit not set Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53033|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53042&action=ed… Bug 15128 - (QA Followup) Fix use of 'my' variable causing loss of data Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53041&action=ed… Bug 15128 (QA Followup) Display all purchase suggestions whether or not suggestion was added Correct enforcement of 0 limit Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52722|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53040&action=ed… Bug 15128 - Followup Only check limit for signed in borrower Show all suggestions after a new one is added Signed-off-by: Barbara Walters <bwalters(a)ncrl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52721|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53039&action=ed… Bug 15128 [QA Followup 2] - Only count pending suggestions for the limit Signed-off-by: Barbara Walters <bwalters(a)ncrl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52720|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53038&action=ed… Bug 15128 [QA Followup] - Make suggestion display after being added Also fixes the issue that the add suggestion link would sometimes show even if the patron could not make an additional suggestion. Signed-off-by: Barbara Walters <bwalters(a)ncrl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52719|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53037&action=ed… Bug 15128 - Add ability to limit patrons open purchase suggestions To test: 1 - Define a number of MaxOpenSuggestions 2 - Add some suggestions for a patron 3 - Note they cannot add any more suggestions if limit is reached 4 - Delete a suggestion and note you can add another 5 - Add them to limit again 6 - Accept a suggestion in the staff client and note user can add more 7 - Repeat above with rejecting or deleting 8 - Sign off. Sponsored by: North Central Regional Library (http://ncrl.org/) Signed-off-by: Barbara Walters <bwalters(a)ncrl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0