July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell <colin.campbell(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #50 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- I'll try and tidyup the way login on raw connections handles poor connections. The changes introduced in 13432 was a major regression for us and were no longer using the standard SIPServer.pm as many sites are dependent on large numbers of SIP connections. I'll see if that can all pull together in one patch. I'm resetting the status for the moment -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14968] found shouldn't be set to null when cancelling holds
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14968] found shouldn't be set to null when cancelling holds
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53016&action=ed… Bug 14968 - Provides unit test Signed-off-by: Broust <jean-manuel.broust(a)univ-lyon2.fr> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14968] found shouldn't be set to null when cancelling holds
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52941|0 |1 is obsolete| | Attachment #52942|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53015&action=ed… Bug 14968 - found shouldn't be set to null when cancelling holds Signed-off-by: JM Broust <jean-manuel.broust(a)univ-lyon2.fr> Signed-off-by: Broust <jean-manuel.broust(a)univ-lyon2.fr> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14968] found shouldn't be set to null when cancelling holds
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #49 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- Comment on attachment 53013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53013 Bug 15006: Add timeout and strikes to raw_transport This is unnecessary - The bogus 3 strikes was already removed in commit 078ce11e113b172726f9ab3180e52a06334d4aab Test plan is ambiguous this routine is not called when using "telnet" authentication. On a raw connection session is started when a sip login is received. If that login fails, the session is terminated. (The login is from the client machine's config so it wont try again with different values) and sends a failed login response before shutting down. If the input is not a login message or a random string it does not respond or login the session but falls through to sip_protocol_loop and times out on the time out set there. I think this should be considered a bug. Its probably the reason why adding a timeout to that had an effect on building up sip sessions as that is meant to be an endless (until logout or connection drop) loop - I think this a bug and that if a connection is not established raw_transport should exit without entering sip_loop -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13807] SIPServer Input loop not checking for closed connections reliably
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52111|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53011|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #48 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Kyle: Please verify your signoff. Thanks. -- You are receiving this mail because: You are watching all bug changes.

1 0