July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 --- Comment #32 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 53033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53033&action=ed… Bug 15128 - (QA Followup) Fix use of 'my' variable causing loss of data -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16838 [Bug 16838] Elasticsearch - mapping tables are not populated on new installs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #28) > This cannot be signed off, the patchset does not work at all, there is no > limitation! Still valid... Nick, could you confirm that these patches have been tested correctly? They do not work for me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #51 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Colin Campbell from comment #49) > Comment on attachment 53013 [details] [review] > Bug 15006: Add timeout and strikes to raw_transport > > This is unnecessary - The bogus 3 strikes was already removed in commit > 078ce11e113b172726f9ab3180e52a06334d4aab > > > Test plan is ambiguous this routine is not called when using "telnet" > authentication. On a raw connection session is started when a sip login is > received. If that login fails, the session is terminated. (The login is from > the client machine's config so it wont try again with different values) and > sends a failed login response before shutting down. If the input is not a > login message or a random string it does not respond or login the session > but falls through to sip_protocol_loop and times out on the time out set > there. I think this should be considered a bug. Its probably the reason why > adding a timeout to that had an effect on building up sip sessions as that > is meant to be an endless (until logout or connection drop) loop - I think > this a bug and that if a connection is not established raw_transport should > exit without entering sip_loop >From testing i recall seeing that raw_transport does respond to requests; one of the reasons that I made it more restrict in a previous patch (relaxed it later again for minimal behavior changes). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13807] SIPServer Input loop not checking for closed connections reliably
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807 --- Comment #7 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #6) > (In reply to Kyle M Hall from comment #5) > > Passing QA provisionally, we should deal with the interaction with bug 13807 > > before anything is pushed. > 13807->15006 > I rebased 15006 on top of this one. So it can go first.. I'm trying to add to 15006 a solution to the log in bug I identified, I'll generated that on top of this -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52894|0 |1 is obsolete| | --- Comment #95 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53029&action=ed… Bug 14048: (QA followup) Default to 1 if no default rule This patch answers Jonathan's request to simplify this patchset a bit. It removes the need for the .sql file, as _default_rule now defaults to a fixed value (1, which was set by the removed .sql file). This allowed to remove the overloaded ->delete method. The tests have been adjusted to reflect this changes, including tests for the new 'default'-if-absent situation. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52883|0 |1 is obsolete| | --- Comment #94 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53028&action=ed… Bug 14048: Use mock_preference in tests Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52876|0 |1 is obsolete| | --- Comment #93 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53027&action=ed… Bug 14048: (QA folloup) C4::Context->preference should be used Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52844|0 |1 is obsolete| | --- Comment #92 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53026&action=ed… Bug 14048: (followup) Use the original holding branch This patch picks the item's holding branch *before* it gets fixed by using the checkin library instead. This way the RefundLostOnReturnControl syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained this behaves just like if CheckinLibrary was set) Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0