August 2016 - Koha-bugs - lists.koha-community.org

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #36 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 53699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53699 Bug 12532 - Redirect guarantee email to guarantor Review of attachment 53699: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=125…) ----------------------------------------------------------------- Hi Maxime and Mehdi, working on this again: A) I am confused about some changes that seem unrelated to this feature - can you please explain you explain and/or amend test plan? (see splitter comments below) B) Is it correct that ACCTDETAILS and RLIST have been dropped from this patch set? (comparing comment#1 to code and syspref description) C) I'd also like to take into account Kyle's earlier comment#28: >1) Should this be a blanket setting? Maybe the parent of an 8 year old would want this, but not the parent of a 17 year old I agree with Kyle here, having this as a global setting will not match the needs of every library. But I think moving from global to more granular should be possible later without any regressions, so for me this is not a blocker. >2) Should the generation of the notice be based on the guarantees messaging settings, or the guarantors? It's a good question: Who can decide that the e-mails are forwarded? I don't have a clear idea about this. Again, not a blocker for me if we'd handle this globally at first. Maybe it could also be a setting under administration -> category codes? >3) Following 2, perhaps guarantors should have the option of receiving notices of guarantees as part of the messaging preferences See above :) >4) Wouldn't it be prudent to send the notice to both? It could just CC the guarantor I have thought about it and I'd really like to see this change happen. I know more places need to be touched, but it seems to be a much cleaner and clearer solution to me. Also: if we change this later on, we got a behaviour change. Worth to give this more thought from the beginning. >I think at a minimum this should be an option for each guarantor, and the email should just add them as a CC ( or some other method so that both the guarantee and guarantor receive >the notice ). A default setting of on or off could be added to the patron types editor, and a checkbox for receiving guarantees notices could be added to the messaging settings for >guarantors on the staff side and the opac. @Kyle - would you be ok with this being global and CC as a first step? D) Some thoughts about wording - you might want to check this with a native speaker :) - I am in favor of short preference names - I was wondering if we couldn't just leave the "Enable" off: RedirectGuaranteeEmail - Similar for the preference description: Now: [Do|Don't] enable the ability to redirect guarantee email messages to guarantor. All email message placed in message_queue table will be affected. Suggestion: [Enable|Don't enable] redirection of guarantee email messages to the guarantor. All email messages send via the message_queue table will be affected. ------------------------------------------- Some general notes: - database update - ok - QA test tools - ok - tests pass for me - apart from one test failing in Letters.t before and after the patch - ok - functionality tested for checkout notices with and without guarantor and yes/no pref setting - ok ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref @@ +183,5 @@ > + - pref: EnableRedirectGuaranteeEmail > + choices: > + yes: Do > + no: "Don't" > + - enable the ability to redirect guarantee email messages to guarantor. All email message placed in message_queue table will be affected. In the initial description of this feature you named ACCTDETAILS and RLIST - those don't go through the message_queue. Looking at the code, I think they are not included? Which messages are affected? ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +82,1 @@ > Why those changes? @@ +1069,5 @@ > + [% IF ( !opadd ) && ( !opduplicate ) && !destination %] > + <script type="text/javascript"> > + $("#saverecord").attr("id","PatronMmessagingPreferences"); > + </script> > + [% END %] Same here: why those changes? ::: members/memberentry.pl @@ +323,5 @@ > push @errors, "ERROR_login_exist"; > } > > + my $password = $input->param('password') || ''; > + my $password2 = $input->param('password2') || ''; Same here: why those changes? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15700] New: Buttons don't work in inventory/stocktaking
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15700 Bug ID: 15700 Summary: Buttons don't work in inventory/stocktaking Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org To reproduce: Go to Tools, Inventory/stocktaking Click Submit to show selection of items Buttons 'Mark seen and continue' and 'Continue without marking' do not work. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #39 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Should we make this also dependent on bug 14868? We also need to resolve the question of taking opacuserlogin into account. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8030] Change pickup location of a hold from patron record
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Marking 'BLOCKED' for now - please swich back once dependencies have been cleared! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #38 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Conclusion at the dev meeting was: I am too paranoid ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12022] Independent branches does not isolate pending and approved comments by branch.
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022 --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Kyle, sorry, but I think this behaviour change will possibly upset some libraries. Could we tie it to IndyBranches - or a new pref? There is another example where the latter has been done: IndependentBranchesPatronModifications -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17190 [Bug 17190] Mark REST API dependencies as mandatory in PerlDependencies.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8030] Change pickup location of a hold from patron record
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 --- Comment #21 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- We've concluded to wait for this until bug 14868 is sorted out and not to backport REST API patches for now to the stable releases until we have worked out the structure of things a bit more. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #84 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks for the followup and qa Marcel! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #83 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #76) > > What do you think? > > Sounds good. But please open up a new report. Let's move it to Bug 17135 (entities must not be multiplied beyond necessity ;). After all, without the 3.a. part from comment #75 or something like that, Bug 14390 is only a half of the solution for this issue - i.e. Bug 17135 is still valid and still a blocker. -- You are receiving this mail because: You are watching all bug changes.

1 0