August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #73 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Alright :) Glad that this is easier than I thought initially. So all is ready for QA? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #72 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jacek Ablewicz from comment #62) > Note: for ensuring that MaxFine behaviour is unchanged, I did just: > > 1) set MaxFine to 100.00 > 2) commented out $accountline->set(...) in UpdateFine > 3) (without the last patch): fines.pl 2>warnings.01 - I got over 1200 > "Reducing fine for ... MaxFine reached" warnings in warnings.01 for my test > database with 19k overdues > 4) (with the last patch included): fines.pl 2>warnings.02 > 5) diff warnings.01 warnings.02: no differences > > Some extra testing with step 2) excluded would be better, but hopefully the > above is good enough. Also in my opinion code changes introduced by the last > patch are 100% solid and regression-free. Thx for your signoff and additional testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #71 from Kyle M Hall <kyle(a)bywatersolutions.com> --- For what it's worth, it's pretty trivial to clean up any checked in fines with a status of FU Katrin. -- Close out any accruing fines with no current issue UPDATE accountlines LEFT JOIN issues USING ( itemnumber, borrowernumber ) SET accounttype = 'F' WHERE accounttype = 'FU' and issues.issue_id IS NULL; -- Close out any extra not really accruing fines, keep only the latest accruing fine UPDATE accountlines SET accounttype = 'F' WHERE accountlines_id NOT IN ( SELECT accountlines_id FROM ( SELECT * FROM accountlines WHERE accounttype = 'FU' ORDER BY accountlines_id DESC ) a2 GROUP BY borrowernumber, itemnumber ); -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #70 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #64) > But doesn't the problem described here still exist after bug 15675? Renewing > an item with a fine should recreate the problem - so maybe we should also > run the clean-up script again? This bug did not create two FU records, Katrin. It changed a F record back to FU. Note that a record like type M (Sundry) from manual invoice does not have an issue id (only an optional item number); so would not change to FU. I am not sure if we can create type O records still (apart from adding them manually to authorized values). I see no need to run the cleanup script in this regard. I would suggest to open up a new report for cleaning up isolated FU records which should have been closed (as Jacek mentioned earlier). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11921] memcached configuration should be moved back to koha-conf.xml
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- See bug 16579 for more information on these patches. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11921] memcached configuration should be moved back to koha-conf.xml
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16579 | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11921] memcached configuration should be moved back to koha-conf.xml
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17188, 17189 Assignee|gmcharlt(a)gmail.com |jonathan.druart(a)bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17188 [Bug 17188] Koha does not support several memcached servers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 [Bug 17189] Add the ability to define several memcached namespaces -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11921] memcached configuration should be moved back to koha-conf.xml
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 [Bug 16579] Use separate memcached namespace for caching koha-conf.xml -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11921] memcached configuration should be moved back to koha-conf.xml
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54820&action=ed… Bug 11921: Update remaining occurrences of ->ismemcached TODO: Would be better to provide a better way to know if memcache is correctly set -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11921] memcached configuration should be moved back to koha-conf.xml
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54819&action=ed… Bug 11921: Restore memcached infos to koha-conf - Koha::Config Move C4::Context->read_config_file to Koha::Config That permits to reuse it from Koha::Cache without needing C4::Context (and introduce a circular deps). TODO: Add decent POD to Koha::Config -- You are receiving this mail because: You are watching all bug changes.

1 0