August 2016 - Koha-bugs - lists.koha-community.org

[Bug 10227] GetMessagingPreferences does not return correct Digest preferences
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux(a)biblibre.com> --- Created attachment 54826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54826&action=ed… Bug 10227 : Fix GetMessagingPreferences when digest is possible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54779|0 |1 is obsolete| | --- Comment #82 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54825&action=ed… Bug 14390: [Follow-up] Only update FU record in UpdateFine Exclude O, F and M when outstanding == 0. Check if the issue_id points to a FU record. Note: We only warn now when we see a second FU record with this issue id. That should be a rare exception. As before, we are just counting it in our total. Added a FIXME. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested fine on overdue. Renewed and backdated for a second fine. The F and FU can be seen on the Fines tab and are totaled on Check out. Signed-off-by: Jacek Ablewicz <abl(a)biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54596|0 |1 is obsolete| | --- Comment #81 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54824&action=ed… Bug 14390: [QA Follow-up] UpdateFine should be passed a hash Renewing an overdue would not work. Log shows: renew: Can't use string ("2144746608") as a HASH ref while "strict refs" in use at C4/Overdues.pm line 508., referer: /cgi-bin/koha/circ/circulation.pl?borrowernumber=1 Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54595|0 |1 is obsolete| | --- Comment #80 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54823&action=ed… Bug 14390 [QA Followup] - Fix warning Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54594|0 |1 is obsolete| | --- Comment #79 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54822&action=ed… Bug 14390 [QA Followup] - Unit Test Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54593|0 |1 is obsolete| | --- Comment #78 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54821&action=ed… Bug 14390 - Fine not updated from 'FU' to 'F' on renewal Test Plan: 1) Find an overdue checkout with a fine 2) Renew item, note fine is not closed out (Account type F) 3) Apply this patch 4) Find another overdue checkout with a fine 5) Renew item, note fine is now correctly closed out 6) Backdate a checkout to be already overdue ( but not have a fine since fines.pl hasn't run yet ) 7) Renew item, note a closed out fine is created Signed-off-by: Sean Minkel <sminkel(a)rcplib.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | Status|Signed Off |Passed QA --- Comment #77 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #73) > Alright :) Glad that this is easier than I thought initially. > So all is ready for QA? Yes. We are ready now. Since this actually was my QA session, I am happy to promote this patch set to Passed QA now. I leave it to anyone interested to add additional cleaning up on a new report please. This patch set is for 16.05 too since bug 15675 was pushed to 16.05. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #76 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jacek Ablewicz from comment #75) > IMO update database part from Bug 15675 is of no use here (and there is no > need to check for duplicated FUs for the same item again, there shouldn't be > any). What I think needs to be done: > > 1) select the FU fine records that may need correction: for that we may need > to compare a due date from issue record and the date on the end of the fine > description - if the dates are the same, this is a correct FU record, no > need to change anything in it > > 2) if the dates are different, there are two possibilities: > > 3.a) if the fine is not accruing / item is not currently due: it's an old > fine record (either left unclosed by Bug 15675 or maybe patron renewed this > item after Bug 15675 was applied in the production database; maybe it got > overwritten in the meantime or maybe not, there is no easy way to tell): it > needs to be closed (FU -> F) > > 3.b) if the fine is accruing (item is due / CalcFine() returns a positive > value): this is an old record which got overwritten: leave it as FU, but > correct a due date in fine description. > > What do you think? Sounds good. But please open up a new report. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #75 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- IMO update database part from Bug 15675 is of no use here (and there is no need to check for duplicated FUs for the same item again, there shouldn't be any). What I think needs to be done: 1) select the FU fine records that may need correction: for that we may need to compare a due date from issue record and the date on the end of the fine description - if the dates are the same, this is a correct FU record, no need to change anything in it 2) if the dates are different, there are two possibilities: 3.a) if the fine is not accruing / item is not currently due: it's an old fine record (either left unclosed by Bug 15675 or maybe patron renewed this item after Bug 15675 was applied in the production database; maybe it got overwritten in the meantime or maybe not, there is no easy way to tell): it needs to be closed (FU -> F) 3.b) if the fine is accruing (item is due / CalcFine() returns a positive value): this is an old record which got overwritten: leave it as FU, but correct a due date in fine description. What do you think? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '16

24 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #74 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #70) > This bug did not create two FU records, Katrin. It changed a F record back > to FU. To be more precise: Without this patch, the FU did not become F. Without the last follow-up the corrected F became FU again. Clear enough? :) -- You are receiving this mail because: You are watching all bug changes.

1 0