August 2016 - Koha-bugs - lists.koha-community.org

[Bug 16329] New: Koha::Logger->sql(). Unified interface to log SQL statements OR use DBIx::Log4perl
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16329 Bug ID: 16329 Summary: Koha::Logger->sql(). Unified interface to log SQL statements OR use DBIx::Log4perl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Instead of whenever needing to log SQL statements, making a custom logging output/function, introduce a centralized subroutine to handle all sql-statement logging. How the SQL-statements should be logged remains to be seen, but currently simply presenting very simple formatting we can discuss about. SQL libraries (DBI, DBIx) also allow logging SQL-statements but lack the fine-grained control Log4perl offers. Or maybe Log4perl can be integrated better to DBI / DBIx with this: https://metacpan.org/pod/DBIx::Log4perl Because I am not a huge fan of DBIx and also integrating that to Koha::Object is a lot of work, will not pursue that track further. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 16304] New: Koha::Logger, lazy load loggers so environment can be properly set.
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '26

12 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16304 Bug ID: 16304 Summary: Koha::Logger, lazy load loggers so environment can be properly set. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org If you instantiate Koha::Loggers before having set the C4::Context->interface, their interface defaults to 'opac'. This is rather undesired especially for 'commandline' scripts such as cronjobs. A solution to this is to lazyLoad loggers when they are really needed. LazyLoading might also have a performance boost when using packages that initialize a package-level logger but which never gets used. see t/Koha/Logger.t on how to replicate this issue, but here is a nutshell of how to replicate this issue: @@ file A.pm package A; use Koha::Logger; my $logger = Koha::Logger->get({category => __PACKAGE__}); #interface unknown sub doStuff { $logger->error('My interface is always "opac"'); } @@ script run.pl use C4::Context; C4::Context->interface('commandline'); use A; A::doStuff(); #error is logged using the "opac"-interface instead #of the "commandline"-interface -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 16450] New: Remove the use of "onclick" from guarantor search template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450 Bug ID: 16450 Summary: Remove the use of "onclick" from guarantor search template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/guarantor_search.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13041, 16386 When adding a guantor to a patron record, a search form is shown in a popup window. This page should be reworked to avoid the use of "onclick." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 [Bug 13041] Can't add user as manager of basket if name includes a single quote https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 [Bug 16386] Replace the use of "onclick" from patron card creator templates -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 16386] New: Replace the use of "onclick" from patron card creator templates
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 Bug ID: 16386 Summary: Replace the use of "onclick" from patron card creator templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: arslanone(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 16372 Several patron card creator templates include the use of an "onclick" attribute. These should be removed in favor of defining events in JavaScript. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 [Bug 16372] Replace the use of "onclick" for deletion confirmation in some templates -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 16457] New: Remove the use of "onclick" from the patron entry form
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '26

11 Jun '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457 Bug ID: 16457 Summary: Remove the use of "onclick" from the patron entry form Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/memberentry.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 13041, 16386, 16450 There are several instances of "onclick" in memberentrygen.tt. It should be rewritten so that JS functionality can be separate from the markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 [Bug 13041] Can't add user as manager of basket if name includes a single quote https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 [Bug 16386] Replace the use of "onclick" from patron card creator templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16450 [Bug 16450] Remove the use of "onclick" from guarantor search template -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 15792] New: Double-clicking the 'renew' button on circulation.pl will double-charge account management fee
by bugzilla-daemon＠bugs.koha-community.org 24 May '26

24 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15792 Bug ID: 15792 Summary: Double-clicking the 'renew' button on circulation.pl will double-charge account management fee Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com PREREQUISITES 1) Create an account type that has an enrollment fee, and create a borrower of that type. 2) Write off any account management fees charged to that borrower by the account creation. STEPS TO RE-CREATE 1) Change borrower's dateexpiry to make the borrower expired. 2) Paste borrower's card number into 'Check out' bar 3) A warning will appear saying that the borrower's account has expired, including a 'Renew' link. 4) Double-click the link 5) Check the borrower's fines. You will see two account management fees in a row. distinct from the fee that was written off just after the patron was created. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 16687] New: Translatability: Fix issues in Administration preferences
by bugzilla-daemon＠bugs.koha-community.org 13 May '26

13 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687 Bug ID: 16687 Summary: Translatability: Fix issues in Administration preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Fix sentence splitting and other translation issues in file koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref to avoid odd translations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 45

[Bug 16260] New: Moderate the impact of AllowHoldsOnPatronsPossessions
by bugzilla-daemon＠bugs.koha-community.org 11 May '26

11 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 Bug ID: 16260 Summary: Moderate the impact of AllowHoldsOnPatronsPossessions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: marjorie.barry-vila(a)ccsr.qc.ca QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Hi, System preference AllowHoldsOnPatronsPossessions is too restrictive. Test plan: -AllowHoldsOnPatronsPossessions : Don't allow -notice with 2 items (X and Y) -one of items is check-out by borrower A (item X) -other items is check-out by borrower B (item Y) If Borrower A wants to hold item Y, he can not because of the system preference. If system preference is Allow, Borrower A can hold item Y but he can hold item X too, and we don't want that he can. Is there something I do not understand in the configuration ? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 16544] New: Changes to circ rules should be logged.
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '26

21 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544 Bug ID: 16544 Summary: Changes to circ rules should be logged. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com At present, changes to circulation rules are not logged. This means that there is no way to determine what circulation rules were in effect at a given time, which makes historical trouble-shooting impossible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 33

[Bug 16786] New: No longer to add multiple emails addresses in an email field
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Bug ID: 16786 Summary: No longer to add multiple emails addresses in an email field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Previous to Koha 3.22, it was possible to enter multiple comma separated email addresses in a patron's email field. This allowed a patron to opt to receive a copy of any given email in more than one address! Now the email validation disallows this, but there is no technical reason to disallow it as far as I am aware. The email validator should be updated to supported multiple comma separated email addresses in any given email field. -- You are receiving this mail because: You are watching all bug changes.

1 28