August 2016 - Koha-bugs - lists.koha-community.org

[Bug 13903] Add API routes to list, create, update, delete holds
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '16

03 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17042 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042 [Bug 17042] Fix missing properties in Swagger definition for Hold -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13799] Add base for building RESTful API
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '16

03 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17041 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041 [Bug 17041] Fix missing properties in Swagger definition for Patron -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '16

03 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53941&action=ed… Bug 10407: [QA Follow-up] Hashref process_batch params As requested by Mark Tompsett. Hope this guarantees a signoff now.. Note: For consistency four additional parameters were needed to no longer use file level vars in this subroutine. Test plan: Import a file with stage_file.pl. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Imported a marc file and a marcxml file with stage_file.pl. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '16

03 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53940&action=ed… Bug 10407: Add two subtests to t/ImportBatch.t Creates a few simple tests for the two new subroutines in ImportBatch.pm. Test plan: Run t/ImportBatch.t. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '16

03 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53939&action=ed… Bug 10407: Add marcxml import (follow-up) This patch makes the following changes: [1] Based on the groundwork of the former patch, add call to RecordsFromMARCXMLFile in stage-marc-import. Use format param. [2] Add format to the template. Use file extension to determine. If you use .xml or .marcxml as extension, MARCXML is selected. [3] In stage-marc-import.tt mark UTF-8 encoding as UTF-8 not as utf8. [4] BatchStageMarcRecords: do not call plugin if you have no records. [5] RecordsFromISO2709File: also return errors in an array. [6] In misc/stage_file.pl also use UTF-8. Handling of errors from [5]. Test plan: [1] Import an empty file as MARC or MARCXML (with Tools/Stage..import). [2] Import an non-empty file with invalid contents as MARC or MARCXML. [3] Export a few records with Tools/Export as MARC and MARCXML. [4] Import these two files. Check selected format versus file extension. [5] Import a MARCXML file with misc/stage_file.pl. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '16

03 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53938&action=ed… Bug 10407: Resolve warnings from child process After the staging job finishes, the child tries to print results to STDOUT (which is closed). This creates warnings like: stage-marc-import.pl: binmode() on closed filehandle STDOUT at C4/Templates.pm line 120. stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at /usr/lib/perl5/Template/Provider.pm line 964. Resolving it is simple: the child should exit after marking the job as finished. Test plan: Import a marc file. Observe that you do no longer have such warnings. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '16

03 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53765|0 |1 is obsolete| | Attachment #53766|0 |1 is obsolete| | Attachment #53767|0 |1 is obsolete| | Attachment #53768|0 |1 is obsolete| | Attachment #53769|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53937&action=ed… Bug 10407: Allow MARCXML records to be imported via GUI (groundwork) Patch from Olli, manual rebase by Marcel (July 7, 2016). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Needs follow-up. Test plan in the third patch. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '16

03 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17034] New: Creating a new patron fails due to DB error
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '16

03 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17034 Bug ID: 17034 Summary: Creating a new patron fails due to DB error Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: code(a)adamgoforth.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com After upgrading from Koha 16.05.01 to 16.05.02 with the Debian package, creating a new patron via the web interface fails. After filling out and submitting the form at /cgi-bin/koha/members/memberentry.pl?op=add&categorycode=OP this error is displayed: DBIx::Class::Row::store_column(): No such column 'checkprevcheckout' on Koha::Schema::Result::Borrower at /usr/share/koha/lib/C4/Members.pm line 731 It seems that the problem is in line 727 of Members.pm: $new_member->{checkprevcheckout} ||= 'inherit'; Commenting out this line allows the patron creation to finish normally. The issue seems to be that the column "checkprevcheckout" does not exist in the borrowers table and should not exist in this version of Koha. Apparently it was added to master in bug 6906, and it shouldn't be in a public release until Koha 16.11. Koha version: 16.05.02.000 OS: Debian 8.5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 7441] Search results showing wrong branch
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '16

03 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #80 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #79) > Jonathan, would you be ok with me testing with a UNIMARC sample database > (from the sandboxes I think)? Yes, of course! -- You are receiving this mail because: You are watching all bug changes.

1 0