August 2016 - Koha-bugs - lists.koha-community.org

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #103 from Francois Charbonnier <francois.charbonnier(a)inlibro.com> --- (In reply to Katrin Fischer from comment #102) > (In reply to Francois Charbonnier from comment #96) > > (In reply to Katrin Fischer from comment #59) > > > > > - What is the definition of an "Active transaction"? (was not clear to me, > > > so asking :) ) > > > > The idea behind "Active transactions" is to help balance cash register > > transactions. In other words, how much goes in or how much goes out the cash > > register. The active transactions group what patrons paid or gave as credit > > to the library, which means what went IN the register. > > > > The code works this way : it takes all transactions where account types are > > NOT "F" (Fine), "FU" (Fine unpaid), "FOR" (Forgiven), "M" (Sundry), "L" > > (Lost). > > Sorry, I still don't get it :( The list of excluded fine types looks a bit > arbitrary to me - what about custom MANUAL_INV values? And what is left by > excluding those? Hey Katrin, But you do get that "active transaction" groups all transactions where patrons give money to the library, right ? The logic should be different. What do you think of grouping the relevant account types, "Pay" and "C" (are there other?) instead of excluding this list? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 16478] New: Translation breaks display of Checkout history in tab Checks / On-site-checkouts
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Bug ID: 16478 Summary: Translation breaks display of Checkout history in tab Checks / On-site-checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt the filter for the tabs 'Checkouts' and 'On-site checkouts' uses text that is exposed to translation. If they are translated, the tabs will be empty on translated pages. (Note: Enable syspref OnSiteCheckuts for testing) See opac-readingrecord.tt line 83ff: [% IF issue.onsite_checkout %] onsite [% ELSE %] checkout [% END %] E.g. in German (/de-DE/modules/opac-readingrecord.tt), it translates to: [% IF issue.onsite_checkout %] vor Ort [% ELSE %] ausgeliehen [% END %] It should be the same as in the English version. A very dirty workaround would be not to translate 'onsite' and 'checkout' in Pootle. Most problably other language will fall into this trap as well. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 16599] XSS found in opac-shareshelf.pl
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16599 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14568 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14423] Multiple XSS and XSRF issues in Staff Client
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14423 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14568 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14416] Stored XSS flaw affects OPAC and Staff interface
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14416 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14568 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14568 | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #29 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 53901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53901&action=ed… Bug 13895: Allow user to access their own checkouts and renew them Let user access their own checkouts and if OpacRenewalAllowed system preference is on, also let user to renew their checkouts. Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie) with a Patron that has no permissions. This Patron will be referred as "your patron" or "your borrowernumber" below. 2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with your borrowernumber) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with someone else's borrowernumber) and check you get a permission error. 4. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id of your Patron) and check you receive correct data 5. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id of some other Patron) and check you get a permission error. 6. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY, replace YYY with existing checkout id of some other Patron. You should get a permission error. 7. Set system preference OpacRenewalAllowed to 0. 8. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY. YYY should be checkout id of checkout for your patron. You should get a permission error. 9. Set system preference OpacRenewalAllowed to 1. 10. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until the maximum number of renewals is reached (you should have a 403 error). YYY should be checkout id of checkout for your patron. 11. Run unit tests in t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53423|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53892&action=ed… Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0