August 2016 - Koha-bugs - lists.koha-community.org

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #29 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 53901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53901&action=ed… Bug 13895: Allow user to access their own checkouts and renew them Let user access their own checkouts and if OpacRenewalAllowed system preference is on, also let user to renew their checkouts. Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie) with a Patron that has no permissions. This Patron will be referred as "your patron" or "your borrowernumber" below. 2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with your borrowernumber) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with someone else's borrowernumber) and check you get a permission error. 4. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id of your Patron) and check you receive correct data 5. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id of some other Patron) and check you get a permission error. 6. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY, replace YYY with existing checkout id of some other Patron. You should get a permission error. 7. Set system preference OpacRenewalAllowed to 0. 8. Send PUT request to http://yourlibrary/api/v1/checkouts/YYY. YYY should be checkout id of checkout for your patron. You should get a permission error. 9. Set system preference OpacRenewalAllowed to 1. 10. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until the maximum number of renewals is reached (you should have a 403 error). YYY should be checkout id of checkout for your patron. 11. Run unit tests in t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53423|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53892&action=ed… Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13796] Alert in OPAC when renewing an item with a rental charge
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 --- Comment #14 from Owen Leonard <oleonard(a)myacpl.org> --- I think Variant III is the best. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #40) > (In reply to Jonathan Druart from comment #38) > > (In reply to Julian Maurice from comment #32) > > > Created attachment 50142 [details] [review] [review] [review] > > > Bug 15126: Update patron definition > > > > Julian, I think we need tests to make sure the swagger file will be always > > up-to-date with the DB structure. Any ideas how we could do that? > > Maybe that should be a coding guideline/QA requisite, that every endpoint > has a proper set of unit tests, including this check on the swagger files. > I'd vote for discussing this on the next dev meeting to gather broader > opinions. This has never been done and the json file is not up-to-date: checkprevcheckout and updated_on are missing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #28 from Lari Taskula <larit(a)student.uef.fi> --- What about user who does not have 'circulate_remaining_permissions' permission, but wants to access his own checkouts or renew his own checkouts if OpacRenewalAllowed is on? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53889|0 |1 is obsolete| | --- Comment #27 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 53891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53891&action=ed… [SIGNED-OFF] Bug 13895: Fixed QA demands Signed-off-by: Frédéric Demians <f.demians(a)tamil.fr> Fix QA, and fix tests failing Signed-off-by: Lari Taskula <larit(a)student.uef.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51303|0 |1 is obsolete| | --- Comment #26 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 53890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53890&action=ed… [SIGNED-OFF] Bug 13895: Add API routes for checkouts retrieval and renewal GET /checkouts?borrowernumber={borrowernumber} GET /checkouts/{checkout_id} PUT /checkouts/{checkout_id} + unit tests in t/db_dependent/api/v1/checkouts.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with a borrowernumber that has checkouts) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until the maximum number of renewals is reached (you should have a 403 error) 5. Run unit tests in t/db_dependent/api/v1/checkouts.t Depends on bug 15126 Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Lari Taskula <larit(a)student.uef.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53878|0 |1 is obsolete| | --- Comment #25 from Frédéric Demians <frederic(a)tamil.fr> --- Created attachment 53889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53889&action=ed… Bug 13895: Fixed QA demands Signed-off-by: Frédéric Demians <f.demians(a)tamil.fr> Fix QA, and fix tests failing -- You are receiving this mail because: You are watching all bug changes.

1 0