August 2016 - Koha-bugs - lists.koha-community.org

[Bug 13796] Alert in OPAC when renewing an item with a rental charge
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 --- Comment #14 from Owen Leonard <oleonard(a)myacpl.org> --- I think Variant III is the best. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #40) > (In reply to Jonathan Druart from comment #38) > > (In reply to Julian Maurice from comment #32) > > > Created attachment 50142 [details] [review] [review] [review] > > > Bug 15126: Update patron definition > > > > Julian, I think we need tests to make sure the swagger file will be always > > up-to-date with the DB structure. Any ideas how we could do that? > > Maybe that should be a coding guideline/QA requisite, that every endpoint > has a proper set of unit tests, including this check on the swagger files. > I'd vote for discussing this on the next dev meeting to gather broader > opinions. This has never been done and the json file is not up-to-date: checkprevcheckout and updated_on are missing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #28 from Lari Taskula <larit(a)student.uef.fi> --- What about user who does not have 'circulate_remaining_permissions' permission, but wants to access his own checkouts or renew his own checkouts if OpacRenewalAllowed is on? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53889|0 |1 is obsolete| | --- Comment #27 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 53891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53891&action=ed… [SIGNED-OFF] Bug 13895: Fixed QA demands Signed-off-by: Frédéric Demians <f.demians(a)tamil.fr> Fix QA, and fix tests failing Signed-off-by: Lari Taskula <larit(a)student.uef.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51303|0 |1 is obsolete| | --- Comment #26 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 53890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53890&action=ed… [SIGNED-OFF] Bug 13895: Add API routes for checkouts retrieval and renewal GET /checkouts?borrowernumber={borrowernumber} GET /checkouts/{checkout_id} PUT /checkouts/{checkout_id} + unit tests in t/db_dependent/api/v1/checkouts.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with a borrowernumber that has checkouts) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until the maximum number of renewals is reached (you should have a 403 error) 5. Run unit tests in t/db_dependent/api/v1/checkouts.t Depends on bug 15126 Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Lari Taskula <larit(a)student.uef.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53878|0 |1 is obsolete| | --- Comment #25 from Frédéric Demians <frederic(a)tamil.fr> --- Created attachment 53889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53889&action=ed… Bug 13895: Fixed QA demands Signed-off-by: Frédéric Demians <f.demians(a)tamil.fr> Fix QA, and fix tests failing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15809] New: versions of CGI < 4.08 do not have multi_param
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Bug ID: 15809 Summary: versions of CGI < 4.08 do not have multi_param Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On debian Jessie, the CGI version is >= 4.08 Since this version, the param method raise a warning "CGI::param called in list context". Indeed, it can cause vulnerability if called in list context https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named… http://blog.gerv.net/2014/10/new-class-of-vulnerability-in-perl-web-applica… There is a long journey to get rid of these warnings. First I suggest to redefine the multi_param method when the CGI version installed is < 4.08, it will allow us to move the wrong ->param calls to ->multi_param without waiting for everybody to upgrade. The different ways to call these 2 methods are: my $foo = $cgi->param('foo'); # OK my @foo = $cgi->param('foo'); # NOK, will raise the warning my @foo = $cgi->multi_param('foo'); #OK $template->param( foo => $cgi->param('foo') ); # NOK, will raise the warning and vulnerable $template->param( foo => scalar $cgi->param('foo') ); # OK -- You are receiving this mail because: You are watching all bug changes.

1 42

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #37) > The import tool does not work for me under plack (master), could you confirm? Did you test with plackup.sh ? There is an essential difference: When you test with koha-plack, the apache include file apache-shared-intranet-plack.conf comes into the picture. It includes a bunch of ProxyPass directives for some problematic scripts, and yes it includes stage-marc-import.pl. This means that the import tool most probably does not work with plackup.sh too without this patch. (Especially when you repeat the import?) So your problem here is not the scope of this report. I retested this patch by importing a marcxml twice with koha-plack enabled, and I confirm that it still works as expected. Btw I would like to work on resolving these issues making the ProxyPass unneeded, but yes on another report :) Thx for testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #24 from Lari Taskula <larit(a)student.uef.fi> --- (In reply to Frédéric Demians from comment #22) > I've just tried this patch in order to test bug 17005 depending patch. For me > 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this > error: > > Can't call method "borrowernumber" on unblessed reference at > <base>Koha/REST/V1/Checkout.pm line 81 > > It may be due to my testing environment. Can someone confirm that tests are > still working on master? It was a small issue in the code. Calling $checkout->borrowernumber on unblessed reference $checkout, probably meant $checkout->{borrowernumber} instead, or even don't unbless $checkout(?). -- You are receiving this mail because: You are watching all bug changes.

1 0