August 2016 - Koha-bugs - lists.koha-community.org

[Bug 15809] New: versions of CGI < 4.08 do not have multi_param
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Bug ID: 15809 Summary: versions of CGI < 4.08 do not have multi_param Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On debian Jessie, the CGI version is >= 4.08 Since this version, the param method raise a warning "CGI::param called in list context". Indeed, it can cause vulnerability if called in list context https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named… http://blog.gerv.net/2014/10/new-class-of-vulnerability-in-perl-web-applica… There is a long journey to get rid of these warnings. First I suggest to redefine the multi_param method when the CGI version installed is < 4.08, it will allow us to move the wrong ->param calls to ->multi_param without waiting for everybody to upgrade. The different ways to call these 2 methods are: my $foo = $cgi->param('foo'); # OK my @foo = $cgi->param('foo'); # NOK, will raise the warning my @foo = $cgi->multi_param('foo'); #OK $template->param( foo => $cgi->param('foo') ); # NOK, will raise the warning and vulnerable $template->param( foo => scalar $cgi->param('foo') ); # OK -- You are receiving this mail because: You are watching all bug changes.

1 42

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #37) > The import tool does not work for me under plack (master), could you confirm? Did you test with plackup.sh ? There is an essential difference: When you test with koha-plack, the apache include file apache-shared-intranet-plack.conf comes into the picture. It includes a bunch of ProxyPass directives for some problematic scripts, and yes it includes stage-marc-import.pl. This means that the import tool most probably does not work with plackup.sh too without this patch. (Especially when you repeat the import?) So your problem here is not the scope of this report. I retested this patch by importing a marcxml twice with koha-plack enabled, and I confirm that it still works as expected. Btw I would like to work on resolving these issues making the ProxyPass unneeded, but yes on another report :) Thx for testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #24 from Lari Taskula <larit(a)student.uef.fi> --- (In reply to Frédéric Demians from comment #22) > I've just tried this patch in order to test bug 17005 depending patch. For me > 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this > error: > > Can't call method "borrowernumber" on unblessed reference at > <base>Koha/REST/V1/Checkout.pm line 81 > > It may be due to my testing environment. Can someone confirm that tests are > still working on master? It was a small issue in the code. Calling $checkout->borrowernumber on unblessed reference $checkout, probably meant $checkout->{borrowernumber} instead, or even don't unbless $checkout(?). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53817|0 |1 is obsolete| | --- Comment #23 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 53878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53878&action=ed… Bug 13895: Fixed QA demands https://bugs.koha-community.org/show_bug.cgi?id=13895 Signed-off-by: Jiří Kozlovský <mail(a)jkozlovsky.cz> Test plan still working Fixes Can't call method "borrowernumber" on unblessed reference at <base>Koha/REST/V1/Checkout.pm line 81 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic(a)tamil.fr --- Comment #22 from Frédéric Demians <frederic(a)tamil.fr> --- I've just tried this patch in order to test bug 17005 depending patch. For me 4 tests are failing: 23, 24, 26, 27. It seems that each time, I've got this error: Can't call method "borrowernumber" on unblessed reference at <base>Koha/REST/V1/Checkout.pm line 81 It may be due to my testing environment. Can someone confirm that tests are still working on master? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] Search results showing wrong branch
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #78 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #77) > > I am wondering if it would not be easier to use something like > > items.$pref_value instead of the xsl:choose blocks which copy/paste code. > > I'm not sure what you mean, but if you want to submit a followup to make > that change I'd be happy to test and sign off on it! Sorry but I really don't want to write xslt code. Waiting for a unimarc signoff! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15247] mysql_auto_reconnect do not reconnect with UTF8 connection
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15247 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #99 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to David Cook from comment #98) > (In reply to M. Tompsett from comment #97) > > PerlDependencies issue. > > Could you elaborate? > > I've added the Perl dependency. > > https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter. > html&bug=10662&attachment=53362 I'm going to guess off the top of my head without checking... But I usually state the file where the problem is. That's why it is marked as "Patch does not apply". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #16 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Aleisha Amohia from comment #15) > (In reply to Jonathan Druart from comment #13) > > Aleisha, as Mark told you in comment 3 and comment 5, your patch conflict > > with bug 10589 and bug 16335. > > I see 10589 has been closed will this one goes ahead. Mark, should we wait > for you to finish your work with 16335 before finishing this one? Go ahead with this. 16335 is going to take a long time before I get it finished. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16985] New: Self registration verification e-mail is broken - no token at the end of the URL
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 Bug ID: 16985 Summary: Self registration verification e-mail is broken - no token at the end of the URL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: kyle.m.hall(a)gmail.com When using PatronSelfRegistrationVerifyByEmail with the patron self registration the patron is sent an email with a confirmation URL to confirm his/her e-mail address before the registration is finished. The URL ends with a token. The token is now missing. I have tried git bisecting it, but I ran into general problems with patron modifications being broken - but I suspect this might be related to bug 14757 as it works right before this was added. Adding Kyle in hope he can see what's going wrong there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6