August 2016 - Koha-bugs - lists.koha-community.org

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #42 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Since Bug 16699 now already is in master, I took the liberty of rebasing this patch against master atop on 14868 which was discussed above. Since rebasing each patch is too much work, I merged all the previous patches in. No functionality is changed, and tests are updated to match new permissions from Bug 14868, so I leave it as Signed off, but more testing should probably be done. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13895 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 [Bug 13895] Add API routes for checkouts retrieval and renewal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 [Bug 13895] Add API routes for checkouts retrieval and renewal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15126, 16086 |16699, 14868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 [Bug 14868] REST API: Swagger2-driven permission checking https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST API: Use newer version of Swagger2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 [Bug 16086] Add Koha::Issue objects. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53890|0 |1 is obsolete| | Attachment #53891|0 |1 is obsolete| | Attachment #53924|0 |1 is obsolete| | Attachment #54685|0 |1 is obsolete| | --- Comment #41 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 54951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54951&action=ed… Bug 13895: Add API routes for checkouts retrieval and renewal GET /checkouts?borrowernumber={borrowernumber} GET /checkouts/{checkout_id} PUT /checkouts/{checkout_id} + unit tests in t/db_dependent/api/v1/checkouts.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with a borrowernumber that has checkouts) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until the maximum number of renewals is reached (you should have a 403 error) 5. Run unit tests in t/db_dependent/api/v1/checkouts.t Depends on bugs 16699 and 14868 Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Lari Taskula <larit(a)student.uef.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13921] XSLT Literary Formats Not Showing
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54720|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54949&action=ed… [PASSED QA] Bug 13921 - XSLT Literary Formats Not Showing This patch adds some missing literary formats to the staff client and OPAC's search results XSLT display. To test you must have DisplayOPACiconsXSLT and DisplayIconsXSLT system preferences enabled. XSLTResultsDisplay and OPACXSLTResultsDisplay should be set to 'default.' Perform searches in the staff client and the OPAC and confirm that the following literary forms (defined in 008 position 33) display correctly: Not fiction; Fiction; Dramas; Essays; Novels; Humor, satires, etc.; Letters; Short stories; Mixed forms; Poetry; Speeches. Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13921] XSLT Literary Formats Not Showing
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11019] Require some fields when adding authorized value category
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54924|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54948&action=ed… [PASSED QA] Bug 11019 - Require some fields when adding authorized value category This patch modifies the form for adding an authorized value so that the category is a required fields. Previously a new authorized value category could be saved with no data. To test, apply the patch and go to Administration -> Authorized values. - Click the "New category" button. - Click the save button without filling in the category. You should be prevented from submitting the form. - Verify that filling in the required field allows the form to be submitted. - Perform the same test when editing an existing authorized value. Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Follow-up for QA: Allow a blank authorised value to be created. Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Amended test plan. Current patch-complexity: Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11019] Require some fields when adding authorized value category
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7115] Suggestion form has wrong label if AdvancedSearchTypes = collection
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7115 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- The suggestion form is now using SUGGEST_FORMAT. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes.

1 0