August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14395] Two different ways to calculate 'No renewal before' ( days or hours)
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '16

29 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #51 from Claudio <costalc(a)gmail.com> --- *** Bug 15666 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '16

29 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko(a)abunchofthings.net --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Adding Mirko as this adds a new dependency. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '16

29 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '16

29 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Signed Off |Failed QA --- Comment #37 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Nick, starting with a first code review here: 1) There seem to be a few lines doubled up in AddIssue now: $item->{'issues'}++; if ( C4::Context->preference('UpdateTotalIssuesOnCirc') ) { UpdateTotalIssues($item->{'biblionumber'}, 1); } $item->{'issues'}++; if ( C4::Context->preference('UpdateTotalIssuesOnCirc') ) { UpdateTotalIssues( $item->{'biblionumber'}, 1 ); } 2) This line is a change of behaviour: Before the change was dependent on the system preference - now it will always happen? - CartToShelf( $itemnumber ) if ( C4::Context->preference("ReturnToShelvingCart") ); + CartToShelf( $itemnumber ) if ( $item->{'location'} eq 'CART' && $item->{'permanent_location'} ne 'CART' ); 3) ReturnToShelvingCart is removed from the code, but the system preference is not deleted in the database update. 4) koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js contains strings - those can not be translated (js files can't be in general) 5) Tests are failing for me (run within koha-shell in kohadevbox): kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl t/db_dependent/Circulation/issue.t Global symbol "$item" requires explicit package name at /home/vagrant/kohaclone/C4/Items.pm line 635. Global symbol "$item" requires explicit package name at /home/vagrant/kohaclone/C4/Items.pm line 635. Can you please take a look? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14435] The table saved_reports is never populated
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I got no problem with this not being perfect for the time being, but could we add one little thing? I am missing an option to delete the saved results - either from the GUI or maybe when the runreport.pl is run an option to clean the last x saved results... I am a little worried that this table will fill up quickly with no way to get rid of stored results. Please read "failed qa" as asking for feedback! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12586] Record matching rules - Required match checks doesn' t work with MARCXML
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This works in my tests, but is missing unit tests. Would it be possible to add a unit test covering the new behaviour here? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7677] New area in subscriptions and new function when receiving
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #91 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Matthias, in testing things looked great, but now the tests are failing for me, hoping it's easy to fix: perl t/db_dependent/Serials_2.t: Can't call method "lastvalue1" on an undefined value at /home/katrin/kohaclone/C4/Serials.pm line 1575. # Looks like your test exited with 2 just after 46. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |tomascohen(a)gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #42 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Since Bug 16699 now already is in master, I took the liberty of rebasing this patch against master atop on 14868 which was discussed above. Since rebasing each patch is too much work, I merged all the previous patches in. No functionality is changed, and tests are updated to match new permissions from Bug 14868, so I leave it as Signed off, but more testing should probably be done. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '16

28 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13895 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 [Bug 13895] Add API routes for checkouts retrieval and renewal -- You are receiving this mail because: You are watching all bug changes.

1 0