August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- Reopening because this issue still exists: > 1. Find a title with multiple holds. > 2. Check an available item out to any patron who > is not at the top of the hold priority list. > 3. The hold for that patron is not removed -- it's > still on hold for them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14434] OPAC should indicate to patrons that auto renewal will not work because hold has been placed
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54877|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54915&action=ed… Bug 14434: Display "Not renewable (on hold)" in OPAC This patch makes the OPAC display "Not renewable (on hold)" when a hold is placed. Test plan: 1) Do not apply patch. 2) Issue an item with automatic renewal. 3) Issue an item with manual renewal. 4) Place a hold on both items. 5) Log in as patron and note that the column "Renew" says "Automatic renewal (x of y renewals remaining)" for the auto renewed item and "(On hold) for the other item. 6) Apply patch. 7) Refresh OPAC and note that now "Not renewable (on hold)" is displayed for both items. 8) Cancel the holds, then log in as patron again and confirm that the correct renewal conditions are displayed. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14434] OPAC should indicate to patrons that auto renewal will not work because hold has been placed
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14434 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54907&action=ed… Bug 14060: Display date format pattern instead of date format name -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54906&action=ed… Bug 14060: Add support for dmydot -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54905&action=ed… Bug 14060: Force the input to contain a valid date Before this patch, the user was still allowed to enter a valid date. Now, if the date is not valid, the input is emptied. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54904&action=ed… Bug 14060: Display the date format on the warning popup The date format is now displayed on the warning popup. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54903&action=ed… Bug 14060: Add OnClose event on missing datepicker The "suspend until" inputs (hold list on circ/circulation.pl and members/moremember.pl) were not set in the same way. The minDate option should be set for both (bug 10703 removed it for circ/circulation.pl). This patch reintroduces the option and add the OnClose event on both. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54606|0 |1 is obsolete| | Attachment #54607|0 |1 is obsolete| | Attachment #54608|0 |1 is obsolete| | Attachment #54609|0 |1 is obsolete| | Attachment #54610|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54902&action=ed… Bug 14060: Remove readonly attributes on date inputs In order to remove accessibility issues due to the readonly attributes on date inputs, this patch will remove them and introduce a javascript validation on them. This patch is not perfect for some reason: I didn't manage to force the user to select a valid date. One solution would be to reopen the datepicker plugin until a valid date is inserted. But it could be annoying for users (and for me: I did not manage to implement this solution). You will note that input is emptied if the date is not valid. This is a quick and efficient solution to prevent submitting invalid date and make Koha explodes. A proper solution would be to implement the check server side send a friendly message to the user. Test plan: For all inputs, try an invalid and a valid date. 1/ Debar a patron 2/ On the checkout tables (circulation and moremember), add a renewal due date (at the bottom of the tables) 3/ On the checkout page, specify a due date 4/ On the return page, specify a return date 5/ On the invoice page (acquisition module), enter a shipment and billing date 6/ On the invoice search page (invoices.pl) use filters shipment and billing dates 7/ On the offline circ page, specify a due date 8/ On the edit patron page (memberentry), add a debarment 9/ On the reserve page (reserve/request.pl), use the date inputs to suspend until a defined date 10/ Edit patrons in a batch (tools/modborrowers.pl) and use the registration and expiry date inputs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0