August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 Amanda <amanda.kelly(a)charteredaccountantsanz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 --- Comment #3 from Amanda <amanda.kelly(a)charteredaccountantsanz.com> --- Owen and Nick, yes you are correct. This was a customisation - the creation of an "invalid reserves queue". The fix was - Catalyst made the Invalid RQ just a report - the queue had been assigning an item to fill a reserve, it now ignores that. And fills it with whatever item is issued to the borrower. That made the reserve come off. So I will close this bug. thanks for looking into it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 6847] Bulk userid, password generation and email
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6847 Irma Birchall <irma(a)calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma(a)calyx.net.au -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9097] 'Welcome mail' for new library users
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Irma Birchall <irma(a)calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma(a)calyx.net.au -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6847] Bulk userid, password generation and email
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6847 Bob Birchall <bob(a)calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob(a)calyx.net.au --- Comment #2 from Bob Birchall <bob(a)calyx.net.au> --- (In reply to Marc Véron from comment #1) > Is this bug still valid? I think it is. AutoEmailOpacUser will only work if you create a new patron from scratch and finish the registering process in one session. If you use patron data import no emails are sent out when the account is created. Bug 9097 is similar but different. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54899|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 54900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54900&action=ed… Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) IMPORTANT STEP: Before you import, make sure that the authtypecode of the file you are going to import matches the Code of your new authority type. Use Vim or something similar to do a search and replace and change the codes in your file - do NOT use LibreOffice etc. because it tries to be too helpful and messes with the formatting of the file (this is what has broken the Import function in previous testing of this patch) 7) Import into your new authority type using the file you just exported (make sure you've done Step 6) 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54840|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 54899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54899&action=ed… Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) IMPORTANT STEP: Before you import, make sure that the authtypecode of the file you are going to import matches the Code of your new authority type. Use Vim or something similar to do a search and replace and change the codes in your file - do NOT use LibreOffice etc. because it tries to be too helpful and messes with the formatting of the file (this is what has broken the Import function in previous testing of this patch) 7) Import into your new authority type using the file you just exported (make sure you've done Step 6) 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Go to Admin -> MARC bibliographic framework 12) Confirm that the 'Export' and 'Import' functions still work here as well Note: If the Export does not work for the default auth type, do not panic. The patch for bug 16035 should fix this. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #41 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Great Work, Lari! Tested thus : 1) minified swagger: perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d api/v1/swagger/swagger.min.json (minifySwagger should perhaps have execution permissions?) 2) restarted plack to pick up changes 3) loaded testdata and added circulation rule to allow holds 4) ran tests t/db_dependent/api/v1/patrons.t and t/db_dependent/api/v1/holds.t 5) ran some manual tests, without permissions, observed authentication failure 6) tested with patron session without borrower permissions, permission failure except on own patron info and own holds 7) tested with superlibrarian Should get an extra pair of eyes and testing, but I'm all OK. Now let's get Bug Bug 17004 moving as well (API auth), and we're really moving towards a great RESTful API -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54771|0 |1 is obsolete| | --- Comment #40 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 54897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54897&action=ed… Bug 14868: Display required permissions in permission error response When user does not have required permissions to use API operation, it would be useful to let them know which permissions he is missing. Since they are now defined in Swagger, we can easily render them into the response. To test: 1. Use a patron without any permissions 2. Make GET request to http://yourlib/api/v1/patrons 3. Observe permission error and see that required_permissions are displayed. 4. Run t/db_dependent/api/v1/patrons.t Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54767|0 |1 is obsolete| | --- Comment #39 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 54896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54896&action=ed… Bug 14868: Use x-koha-authorization in current routes To test: 1. Run t/db_dependent/api/v1/holds.t 2. Run t/db_dependent/api/v1/patrons.t Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0