August 2016 - Koha-bugs - lists.koha-community.org

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54840|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 54899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54899&action=ed… Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) IMPORTANT STEP: Before you import, make sure that the authtypecode of the file you are going to import matches the Code of your new authority type. Use Vim or something similar to do a search and replace and change the codes in your file - do NOT use LibreOffice etc. because it tries to be too helpful and messes with the formatting of the file (this is what has broken the Import function in previous testing of this patch) 7) Import into your new authority type using the file you just exported (make sure you've done Step 6) 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Go to Admin -> MARC bibliographic framework 12) Confirm that the 'Export' and 'Import' functions still work here as well Note: If the Export does not work for the default auth type, do not panic. The patch for bug 16035 should fix this. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #41 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Great Work, Lari! Tested thus : 1) minified swagger: perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d api/v1/swagger/swagger.min.json (minifySwagger should perhaps have execution permissions?) 2) restarted plack to pick up changes 3) loaded testdata and added circulation rule to allow holds 4) ran tests t/db_dependent/api/v1/patrons.t and t/db_dependent/api/v1/holds.t 5) ran some manual tests, without permissions, observed authentication failure 6) tested with patron session without borrower permissions, permission failure except on own patron info and own holds 7) tested with superlibrarian Should get an extra pair of eyes and testing, but I'm all OK. Now let's get Bug Bug 17004 moving as well (API auth), and we're really moving towards a great RESTful API -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54771|0 |1 is obsolete| | --- Comment #40 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 54897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54897&action=ed… Bug 14868: Display required permissions in permission error response When user does not have required permissions to use API operation, it would be useful to let them know which permissions he is missing. Since they are now defined in Swagger, we can easily render them into the response. To test: 1. Use a patron without any permissions 2. Make GET request to http://yourlib/api/v1/patrons 3. Observe permission error and see that required_permissions are displayed. 4. Run t/db_dependent/api/v1/patrons.t Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54767|0 |1 is obsolete| | --- Comment #39 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 54896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54896&action=ed… Bug 14868: Use x-koha-authorization in current routes To test: 1. Run t/db_dependent/api/v1/holds.t 2. Run t/db_dependent/api/v1/patrons.t Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54766|0 |1 is obsolete| | --- Comment #38 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 54895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54895&action=ed… Bug 14868: Give users possibility to request their own object Allow access to user's own objects even if they do not have required permissions. This will be very useful in many cases where an user wants to request their own object, for example renewing their checkouts or placing a hold for themselves. First, this patch renames "x-koha-permission" to "x-koha-authorization" in order to describe the new functionality better. Second, we can now add two extra parameters under "x-koha-authorization": - "allow-owner"; Allows the owner of object to access it (without permission) - "allow-guarantor"; Allows guarantor of the owner of object to access it (without permission) Third, since permission checking is outside of actual controller, we need a way to find out ownership from different types of parameters, e.g. checkout_id from /checkouts/{checkout_id}, borrowernumber from /patrons/{borrowernumber} etc. A solution is to match the parameter with a subroutine that is designed to verify the ownership for that object. See the new subroutines in Koha::REST::V1. To use this functionality you will simply define it in Swagger: "/patrons/{borrowernumber}": { "get": { ..., "x-koha-authorization": { "allow-owner": true, "permissions": { "borrowers": "1" } } } } If a parameter that is not yet defined in Koha::REST::V1::check_object_ownership, you also need to define it and implement a subroutine that determines ownership. Tests are provided in a following patch that adds this functionality for current API operations. Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54765|0 |1 is obsolete| | --- Comment #37 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 54894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54894&action=ed… Bug 14868: Swagger2-driven Permission checking Define 'x-koha-permission' for the Swagger2 Operation Object, to automatically authorize against the required permissions. This way we immediately tell the API consumer in the Swagger2-definition, which permissions are needed to access defined resources. Also we don't need to maintain permissions in multiple locations and we can build a smart testing framework to help a lot in creating tests for the new REST API. Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #27 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Katrin Fischer from comment #26) > I searched for documentation up and down last night - didn't come up with > much. > > We don't have a 'please give feedback' status - so I am setting 'Failed QA', > please take a look and consider/comment. My guess, and I'm assuming Amazon would be able to tell us, is that ref=... means that is the page it came from. In terms of generating revenue, I'm guessing that not just the tag but the ref is also paid. Only Amazon would know. And their documentation is not easily searched through. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I searched for documentation up and down last night - didn't come up with much. We don't have a 'please give feedback' status - so I am setting 'Failed QA', please take a look and consider/comment. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from Owen Leonard <oleonard(a)myacpl.org> --- I'm getting a JavaScript error on returns.pl: SyntaxError: expected expression, got ',' $("#barcode").focus(); }, Is it possible for the error message to use the date format pattern instead of the date format name? It's not very clear for the alert to say "Please enter a valid date (should match us)." It would be better to see: "Please enter a valid date (should match MM/DD/YYYY)." Other than that, this seems to be working really well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15503] Grab Item Information from Order Files
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #10 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Matthias Meusburger from comment #9) > Nick, can you post the MarcItemFieldsToOrder syspref you used? homebranch: 975$a holdingbranch: 975$b itype: 975$9|975$z nonpublic_note: 975$x public_note: 975$y loc: 975$8 ccode: 975$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 969$h budget_code: 922$a price: 975$p -- You are receiving this mail because: You are watching all bug changes.

1 0