August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54766|0 |1 is obsolete| | --- Comment #38 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 54895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54895&action=ed… Bug 14868: Give users possibility to request their own object Allow access to user's own objects even if they do not have required permissions. This will be very useful in many cases where an user wants to request their own object, for example renewing their checkouts or placing a hold for themselves. First, this patch renames "x-koha-permission" to "x-koha-authorization" in order to describe the new functionality better. Second, we can now add two extra parameters under "x-koha-authorization": - "allow-owner"; Allows the owner of object to access it (without permission) - "allow-guarantor"; Allows guarantor of the owner of object to access it (without permission) Third, since permission checking is outside of actual controller, we need a way to find out ownership from different types of parameters, e.g. checkout_id from /checkouts/{checkout_id}, borrowernumber from /patrons/{borrowernumber} etc. A solution is to match the parameter with a subroutine that is designed to verify the ownership for that object. See the new subroutines in Koha::REST::V1. To use this functionality you will simply define it in Swagger: "/patrons/{borrowernumber}": { "get": { ..., "x-koha-authorization": { "allow-owner": true, "permissions": { "borrowers": "1" } } } } If a parameter that is not yet defined in Koha::REST::V1::check_object_ownership, you also need to define it and implement a subroutine that determines ownership. Tests are provided in a following patch that adds this functionality for current API operations. Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54765|0 |1 is obsolete| | --- Comment #37 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 54894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54894&action=ed… Bug 14868: Swagger2-driven Permission checking Define 'x-koha-permission' for the Swagger2 Operation Object, to automatically authorize against the required permissions. This way we immediately tell the API consumer in the Swagger2-definition, which permissions are needed to access defined resources. Also we don't need to maintain permissions in multiple locations and we can build a smart testing framework to help a lot in creating tests for the new REST API. Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #27 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Katrin Fischer from comment #26) > I searched for documentation up and down last night - didn't come up with > much. > > We don't have a 'please give feedback' status - so I am setting 'Failed QA', > please take a look and consider/comment. My guess, and I'm assuming Amazon would be able to tell us, is that ref=... means that is the page it came from. In terms of generating revenue, I'm guessing that not just the tag but the ref is also paid. Only Amazon would know. And their documentation is not easily searched through. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 26 Aug '16

26 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I searched for documentation up and down last night - didn't come up with much. We don't have a 'please give feedback' status - so I am setting 'Failed QA', please take a look and consider/comment. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from Owen Leonard <oleonard(a)myacpl.org> --- I'm getting a JavaScript error on returns.pl: SyntaxError: expected expression, got ',' $("#barcode").focus(); }, Is it possible for the error message to use the date format pattern instead of the date format name? It's not very clear for the alert to say "Please enter a valid date (should match us)." It would be better to see: "Please enter a valid date (should match MM/DD/YYYY)." Other than that, this seems to be working really well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15503] Grab Item Information from Order Files
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #10 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Matthias Meusburger from comment #9) > Nick, can you post the MarcItemFieldsToOrder syspref you used? homebranch: 975$a holdingbranch: 975$b itype: 975$9|975$z nonpublic_note: 975$x public_note: 975$y loc: 975$8 ccode: 975$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 969$h budget_code: 922$a price: 975$p -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10455] remove redundant 'biblioitems.marc' field
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54881&action=ed… Bug 10455: Fix tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18272|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 54880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54880&action=ed… Bug 10300 - Allow transferring of items to be have separate IndependentBranches syspref Some libraries want to have IndependentBranches enabled, but still be able to transfer items between themselves. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndpendentBranches and IndependentBranchesTransfers 4) Log in as a super librarian 5) Note you can transfer items 6) Log in as a non-super librarian 7) Note you cannot transfer items 8) Disable IndependentBranchesTransfers 9) Note you can now transfer items -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
by bugzilla-daemon＠bugs.koha-community.org 25 Aug '16

25 Aug '16

1 0