September 2016 - Koha-bugs - lists.koha-community.org

[Bug 16376] New: Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '17

29 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Bug ID: 16376 Summary: Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Koha::Calendar->is_holiday calls the following DateTime truncate method: $localdt->truncate( to => 'day' ); This will truncate 2015-09-06 12:00:00 down to 2015-09-06 00:00:00. This causes major problems in Santiago, Chile, because 2015-09-06 is an invalid local time due to DST. I can't explain why it's a problem in 2015 because DST is weird in Chile in 2015, but it's obviously a problem for every other year as well: http://www.timeanddate.com/time/change/chile/santiago?year=2015 Consider 2014: 2014 Sunday, 27 April, 12:00 Midnight Sunday, 7 September, 12:00 Midnight You shouldn't have a problem on 27 April, because when 27 April 12:00 midnight hits (relative to UTC), local time is changed to 27 April 11:00pm. While UTC marches on, local time has been magically moved back an hour. You will have a problem on 7 September 12:00 midnight though, because that time doesn't exist. As soon as we roll over from 6 September 11:59pm to the next minute... we're actually on to 7 September 01:00:00am. Midnight doesn't exist on that day, which creates the following error in DateTime.pm: "Invalid local time for date in time zone: America/Santiago" This is a problem that the DateTime writer predicted. You can see their comments here: http://cpansearch.perl.org/src/DROLSKY/DateTime-1.26/lib/DateTime.pm https://rt.cpan.org/Public/Bug/Display.html?id=93347 We should probably do something like: eval { $dt->truncate(to => 'day'); } || warn "Eval failed with '$@'\n"; Why are we even doing this day truncation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 17310] New: Broken URLs in 'Item renewed' / 'Cannot renew' messages
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '17

27 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Bug ID: 17310 Summary: Broken URLs in 'Item renewed' / 'Cannot renew' messages Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: arouss1980(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Description of the problem: In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs like these: /cgi-bin/koha/catalogue/detail.pl?biblionumber=Koha::Schema::Result::Biblio=HASH(0x7714d88) /cgi-bin/koha/catalogue/moredetail.pl?itemnumber=7&biblionumber=Koha::Schema::Result::Biblio=HASH(0x7714d88)&bi=1286#item7 This is also true for the message shown when you try to renew an item that is not checked out. Valid in latest stable (v16.05.03) and in the current master (0254fd7). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 17265] New: Make koha-create-defaults less greedy
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '17

27 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17265 Bug ID: 17265 Summary: Make koha-create-defaults less greedy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net koha-dump-defaults runs mysqldump and then pipes the result to sed, to replace every occurence of the site name with the placeholder __KOHASITE__ mysqldump --databases --host="$mysqlhost" --user="$mysqluser" \ --password="$mysqlpass" "$mysqldb" | sed "s/$name/__KOHASITE__/g" I had used the silly name "data" as the site name for my "template instance", and this resulted in innocent things like -- Dumping __KOHASITE__ for table `zebraqueue` and bad things like 'Edit catalog (Modify bibliographic/holdings __KOHASITE__)' or this, in biblioitems.marcxml: <__KOHASITE__field> All told there were 7235 occurences of __KOHASITE__ in my rather small SQL file. As suggested by drojf on IRC, I *think* this would be fixed if we replaced "koha_$name" __INSTANCENAME__, instead of just $name. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 15711] New: Deleting patroncard images has unexpected behaviour and is broken
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '17

27 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 Bug ID: 15711 Summary: Deleting patroncard images has unexpected behaviour and is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org To reproduce: 1) Go to Tools -> Patron Card Creator -> Manage Images. Upload an image if you do not already have something uploaded 2) Without checking any boxes, click the 'Delete selected' box 3) A box will pop up saying 'Please select image(s) to delete', as expected. Click 'OK' 4) Another pop-up saying 'Are you sure you want to delete image(s): undefined?' This is unexpected and shouldn't be showing up if nothing has been selected. 5) Click 'OK' - This also doesn't work (image isn't deleted) and gives an error 'WARNING: An error has occurred. Please ask your system administrator to check the error log for more details.' 6) Check the box next to an image and click 'Delete selected', then 'OK'. You get the WARNING error again and the image isn't deleted. This is broken. -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 16933] New: Alt-Y not working on "Please confirm checkout" dialogs
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '17

27 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Bug ID: 16933 Summary: Alt-Y not working on "Please confirm checkout" dialogs Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: tmcmahon(a)wlpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The alt-Y key which used to select Yes in circulation dialogs switches to the renew tab instead. I also noticed that the new "Don't check out and print slip (P)" button doesn't work with alt-P either. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 17065] New: Rename C4/Auth_cas_servers.yaml.orig
by bugzilla-daemon＠bugs.koha-community.org 23 Jan '17

23 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065 Bug ID: 17065 Summary: Rename C4/Auth_cas_servers.yaml.orig Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net C4/Auth_cas_servers.yaml.orig gets cleaned away after every package build because of the .orig extension. This patch moves it. It is only a sample file, there is no functionality to test. Just verify that the file is there with the new name after you applied the patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 17019] New: debian/changelog update
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019 Bug ID: 17019 Summary: debian/changelog update Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 17066] New: build-git-snapshot: add basetgz parameter and update master version number for 3.22.x
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066 Bug ID: 17066 Summary: build-git-snapshot: add basetgz parameter and update master version number for 3.22.x Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net Needed for nightly oldstable packages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 17085] New: Specify libmojolicious-perl min version
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17085 Bug ID: 17085 Summary: Specify libmojolicious-perl min version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net Set min version for libmojolicious-perl to 6.0. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 17027] New: contril file update for 3.22
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '17

20 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027 Bug ID: 17027 Summary: contril file update for 3.22 Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net I updated the control file for 3.22.09. This should go in 3.22.10. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6