January 2017 - Koha-bugs - lists.koha-community.org

[Bug 18003] New: Should deletedborrowers.borrowernumber be a primary key?
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Bug ID: 18003 Summary: Should deletedborrowers.borrowernumber be a primary key? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17782 (Raised from bug 17782) DBIC needs a primary key to work correctly. We could be tempt to make borrowernumber a primary key, but a use case could bring thing. Indeed if a table is empty and the mysql (mariadb behaves identically) server restarted, the Auto Increment (AI) is reset. Problematic use case: 1. Install Koha 2. Create a patron (borrowers.borrowernumber = 1) 3. Delete it (deletedborrowers.borrowernumer = 1, and AI is set to 2 4. Restart mysql => borrowers is empty so AI is reset 5. Create a patron (borrowers.borrowernumber = 1) 6. Delete it => We will try to insert a new row with an existing borrowernumber (1) into the deletedborrowers table: BOOM Solution 1: Do not care about this problematic use case and prevent to delete the last patron. Solution 2: Add a AI primary key (id) to deletedborrowers => The 2 tables borrowers and deletedborrowers will differ, bugs will be expected Solution 3: Deal with that at code level: when a patron is created, guess the borrowernumber it will get and check if it does not already exist in the deletedborrowers table. If so, force it before inserting it Solution 4: Do not enforce this constraint at DB level but set the primary key to DBIC schema: Koha::Schema::Result::Deletedborrower: __PACKAGE__->set_primary_key("borrowernumber"); Problem: Koha::Database->new->schema->resultset('Deletedborrower')->find(42); will raise a warning "DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single" if 42 is duplicated, and the first matching row will be picked Another solution? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 16636] New: t/00-load.t warning from C4/External/BakerTaylor.pm
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 Bug ID: 16636 Summary: t/00-load.t warning from C4/External/BakerTaylor.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: mtompset(a)hotmail.com Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com Since the tests are expecting an initialize function, the initialize call was just moved outside of the INIT block. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 16342] New: Placks breaks Baker and Taylor cover images
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342 Bug ID: 16342 Summary: Placks breaks Baker and Taylor cover images Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org BakerTaylorImageURL is constructed through C4/External/BakerTaylor.pm under plack the initialisation/passing of these variables doesn't work To recreate (you do not need a B&T account): Put any old values into: BakerTaylorBookstoreURL BakerTaylorUsername BakerTaylorPassword and set BakerTaylorEnabled to 'Add' With plack off: Images should be constructed with URL like: http://contentcafe2.btol.com/ContentCafe/Jacket.aspx?UserID=$user&Password=… With plack enabled you get img src=BakerTaylorLinkURL... -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 18011] New: Categories.pl allows users to set the enrolementperioddate to before the current date without any error /warning messages
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Bug ID: 18011 Summary: Categories.pl allows users to set the enrolementperioddate to before the current date without any error/warning messages Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P3 Component: System Administration Assignee: alexbuckley(a)catalyst.net.nz Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com At present when creating a patron category the user can select a date from the date picker which is earlier than the current date, meaning patrons created from the patron category have a dateexpire before they were even created. The fix of this bug is to implement a javascript message informing the user that the date they selected from the datepicker is invalid and forcing them to choose a new date before they can submit the form. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 16231] New: Correct permission handling in subscription edit menu
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Bug ID: 16231 Summary: Correct permission handling in subscription edit menu Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-detail.pl?subscript ionid=X OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com The "Edit" toolbar menu for serials contains three items, "Edit subscription," "Edit as new (duplicate)" and "Delete subscription." Each item should be wrapped in its own check for the "CAN_user_serials_*" permission. -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 16276] New: When automatically suppressing expired borrowers, make sure they didn't log them selves recently
by bugzilla-daemon＠bugs.koha-community.org 30 May '19

30 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Bug ID: 16276 Summary: When automatically suppressing expired borrowers, make sure they didn't log them selves recently Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nicolas.legrand(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com We would like to automate the delation of expired patrons to comply to french laws regarding privacy. But we don't want to delate an expired patron which is still using the OPAC for bibliographical purpose, like managing lists. We would like to be able to say when the patron logged himself for the last time to permit this. Whith this parameter we would like to be able to use it from misc/cronjobs/delete_patrons.pl and also with the "Clean Patron Records" intranet page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 77

[Bug 15737] New: Patron userid lost during test for duplicate users
by bugzilla-daemon＠bugs.koha-community.org 30 May '19

30 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15737 Bug ID: 15737 Summary: Patron userid lost during test for duplicate users Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: david.roberts(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If you create a new patron record and manually assign a unique cardnumber (userid in the borrowers table) and Koha identifies a possible duplicate record, clicking OK to create the user as a new user causes the manually-assigned userid to be replaced with the user's firstname.lastname. The manually entered userid should be remembered (as long as it is genuinely unique). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 16497] New: REST API: add routes to list libraries
by bugzilla-daemon＠bugs.koha-community.org 28 May '19

28 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Bug ID: 16497 Summary: REST API: add routes to list libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: benjamin.rokseth(a)kul.oslo.kommune.no QA Contact: testopia(a)bugs.koha-community.org Small enhancement to REST API to add the possibility to list libraries. GET /api/v1/libraries List all libraries and branchcodes GET /api/v1/libraries/{branchcode} Get library description and branchcode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 99

[Bug 17496] New: install-CPAN.pl documentation/removal
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17496 Bug ID: 17496 Summary: install-CPAN.pl documentation/removal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org I have no idea what this script does and can't find any documentation for it anywhere.. We should either document it, or remove it ;) -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 17236] New: Add minute and hours to last checked out item display
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17236 Bug ID: 17236 Summary: Add minute and hours to last checked out item display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com bug 13315 added a display of the last item checked out. Some libraries use this feature and also use hourly loans and would like the feedback to include this information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14