October 2017 - Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #164 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 1/ +TODO: + +- Anything invoking the ->status method; annotated with: + + # Old use of ->status ! What do it mean? 2/ I will not make you rewrite everything, but it would have been better to stay consistent and not mix snake_case and camelCase for method names. First steps with the GUI: 3/ This is what I see when I enable the module: https://screenshots.firefox.com/z9dNoRL91NQ5F3cD/pro.kohadev.org Looks wrong. 4/ Hit /cgi-bin/koha/ill/ill-requests.pl and got: Loading failed for the <script> with source “http://pro.kohadev.org/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.tablesorter.min.js”. ill-requests.pl:151 Loading failed for the <script> with source “http://pro.kohadev.org/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.checkboxes.min.js”. ill-requests.pl:152 5/ Clicked "New ILL request" button and got: Can't locate Koha/Illbackends//Base.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #163 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Please fix QA script failures. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2454] Improve display of credits on pay fines tab
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 2454] Improve display of credits on pay fines tab
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 --- Comment #16 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 68470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68470 Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit" Review of attachment 68470: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=245…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt @@ -132,5 @@ > - [% CASE 'HE' %]Hold waiting too long > - [% CASE 'Rent' %]Rental fee > - [% CASE 'FOR' %]Forgiven > - [% CASE 'LR' %]Lost item fee refund > - [% CASE 'PF' %]Processing fee This is why you put white space changes in a different file. I believe this line got removed incorrectly. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #44 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Dominic Pichette from comment #43) > Created attachment 68791 [details] [review] > Bug 18282: operationId must be unique > > operationId has the following documentation: > "Unique string used to identify the operation. The id MUST be unique among > all > operations described in the API." > > This patch modifies operationIds to be unique accross our API operations. > > Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> > > Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> > Signed-off-by: Dominic Pichette <dominic(a)inlibro.com> Dominique, I think you submitted a signed patch to the wrong bug report. I obsoleted it and marked the bug back as Needs Signoff to avoid confusion. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2454] Improve display of credits on pay fines tab
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62994|0 |1 is obsolete| | --- Comment #15 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 62994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62994 [SIGNED OFF] Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit" The second one is the rebase of this. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2454] Improve display of credits on pay fines tab
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #14 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Jonathan Druart from comment #13) > CONFLICT (content): Merge conflict in > koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt > > Please do NOT modify the indentation when you do not modify the line or > create a new block. That will avoid this kind of unnecessary rebases. "If you want to reindent large amounts of existing code in connection with a bugfix or enhancement, you must do so in a separate patch from the one with code changes (unless the reindent is required due to the addition or removal of an indentation level (for example, an additional if added around a block)." https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 17380] New: Cannot edit authorities with authtypecode = default
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Bug ID: 17380 Summary: Cannot edit authorities with authtypecode = default Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt(a)gmail.com Reporter: joachim.ganseman(a)ehb.be QA Contact: testopia(a)bugs.koha-community.org Created attachment 55947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55947&action=ed… Example: after trying to merge PERSO_NAME and TOPIC_TERM "Rossini", the PERSO_NAME record is now authtypecoded as "default" and cannot be edited anymore Editing authorities whose authtypecode is not set to a common value is not possible in Koha 16.05 . This occurs e.g. after trying to (accidentally) merge a PERSO_NAME and TOPIC_TERM authority into one. The resulting authority will have its authtypecode set to "default". Upon trying to correct such an authority, it turns out to be impossible to edit the said authority. An error very similar to 'Can't call method "authtypecode" on an undefined value' appears instead of the editor. This occurs even when there are no authority frameworks defined (i.e. all in the default frameworks), in Koha 16.05 on Debian. -- You are receiving this mail because: You are watching all bug changes.

1 56