October 2017 - Koha-bugs - lists.koha-community.org

[Bug 19296] New: Tax is being subtracted from orders when vendor price does not include gst and ordering from a file
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19296 Bug ID: 19296 Summary: Tax is being subtracted from orders when vendor price does not include gst and ordering from a file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In the case of vendor prices don't include gst we are removing the gst from the order price, passing it to populate_order_with_prices and calculating tax on the price with tax removed! Example: Order with price of $10 and tax rate of 10% We calculate ecost/rrp at 9.09 Then calculate tax on 9.09 We should be calculating tax on $10 In addorderiso2707.pl: 270 if ( $bookseller->listincgst ) { 271 if ( $c_discount ) { 272 $orderinfo{ecost} = $price; 273 $orderinfo{rrp} = $orderinfo{ecost} / ( 1 - $c ); 274 } else { 275 $orderinfo{ecost} = $price * ( 1 - $c ); 276 $orderinfo{rrp} = $price; 277 } 278 } else { 279 if ( $c_discount ) { 280 $orderinfo{ecost} = $price / ( 1 + $orderinfo{tax_rate} ); 281 $orderinfo{rrp} = $orderinfo{ecost} / ( 1 - $c ); 282 } else { 283 $orderinfo{rrp} = $price / ( 1 + $orderinfo{tax_rate} ); 284 $orderinfo{ecost} = $orderinfo{rrp} * ( 1 - $c ); 285 } 286 } ... 296 297 %orderinfo = %{ 298 C4::Acquisition::populate_order_with_prices( 299 { 300 order => \%orderinfo, 301 booksellerid => $booksellerid, 302 ordering => 1, 303 receiving => 1, 304 } 305 ) 306 }; Then in C4 Acquisition: 2943 if ($ordering) { 2944 $order->{tax_rate_on_ordering} //= $order->{tax_rate}; 2945 if ( $bookseller->listincgst ) { 2946 # The user entered the rrp tax included 2947 $order->{rrp_tax_included} = $order->{rrp}; 2948 2949 # rrp tax excluded = rrp tax included / ( 1 + tax rate ) 2950 $order->{rrp_tax_excluded} = $order->{rrp_tax_included} / ( 1 + $order->{tax_rate_on_ordering} ); 2951 2952 # ecost tax excluded = rrp tax excluded * ( 1 - discount ) 2953 $order->{ecost_tax_excluded} = $order->{rrp_tax_excluded} * ( 1 - $discount ); 2954 2955 # ecost tax included = rrp tax included ( 1 - discount ) 2956 $order->{ecost_tax_included} = $order->{rrp_tax_included} * ( 1 - $discount ); 2957 } 2958 else { 2959 # The user entered the rrp tax excluded 2960 $order->{rrp_tax_excluded} = $order->{rrp}; 2961 2962 # rrp tax included = rrp tax excluded * ( 1 - tax rate ) 2963 $order->{rrp_tax_included} = $order->{rrp_tax_excluded} * ( 1 + $order->{tax_rate_on_ordering} ); 2964 2965 # ecost tax excluded = rrp tax excluded * ( 1 - discount ) 2966 $order->{ecost_tax_excluded} = $order->{rrp_tax_excluded} * ( 1 - $discount ); 2967 2968 # ecost tax included = rrp tax excluded * ( 1 - tax rate ) * ( 1 - discount ) 2969 $order->{ecost_tax_included} = 2970 $order->{rrp_tax_excluded} * 2971 ( 1 + $order->{tax_rate_on_ordering} ) * 2972 ( 1 - $discount ); 2973 } 2974 2975 # tax value = quantity * ecost tax excluded * tax rate 2976 $order->{tax_value_on_ordering} = 2977 $order->{quantity} * $order->{ecost_tax_excluded} * $order->{tax_rate_on_ordering}; 2978 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 15644] City dropdown default selection when modifying a patron matches only on city
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. Note: French format doesn't exist in 16.11.x and has been removed from the patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18742] New: Circulation statistics wizard no longer exports the total row
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742 Bug ID: 18742 Summary: Circulation statistics wizard no longer exports the total row Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It seems like a few lines were lost from issues-stats.pl in bug 7679: # footer print "TOTAL"; $cols = @$results[0]->{loopfooter}; print map {$sep.$_->{totalcol}} @$cols; print $sep.@$results[0]->{total}; -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 12346] False patron modification alerts on members-home.pl
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18956] Possible privacy breach with OPAC password recovery
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18956 --- Comment #26 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19117] paycollect.pl is vulnerable for CSRF attacks
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19117 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19333] XSS vulnerability in opac-shelves
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19333 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3841] Add a Default ACQ framework
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841 --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I started looking at this yesterday and was wondering why the framework was sometimes mandatory and sometimes optional. Also: I think we could choose nicer defaults for the ACQ framework, like setting default for not for loan to -1 = on order and remove some fields from display that are very unlikely to be set on order time. Should I open a separate bug report for those suggestions? I think -1 would be really nice to have, otherwise it's just the same as now, but witout the helpful warning on how to change things. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3841] Add a Default ACQ framework
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68638|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 68806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68806&action=ed… Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3841] Add a Default ACQ framework
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0