October 2017 - Koha-bugs - lists.koha-community.org

[Bug 19344] New: DB fields login_attempts and lang may be inverted
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19344 Bug ID: 19344 Summary: DB fields login_attempts and lang may be inverted Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Due to a bad rebase, the borrowers and deletedborrowers table structure may different from a new install and upgraded install -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 19317] New: Move of checkouts - Remove leftover
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19317 Bug ID: 19317 Summary: Move of checkouts - Remove leftover Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Nothing important here, but this line should have been removed by bug 18966: 2177 # Update the fines 2178 $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id = ?|, undef, $old_checkout->issue_id, $issue->issue_id); The issue_id is now the same when moved from issues to old_issues. We do not need to update the accountlines table -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 18999] New: Acq: Shipping cost not included in total spent on acq home and funds page
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 Bug ID: 18999 Summary: Acq: Shipping cost not included in total spent on acq home and funds page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Both the table on the acq start page and the table on the funds page don't include the shipping costs. This means, that the total spent is not correct. You can easily check this by comparing with the full list shown when clicking on the spent amount from the acq start page table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 34

[Bug 19135] New: AllowHoldsOnPatronsPossessions is not working
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135 Bug ID: 19135 Summary: AllowHoldsOnPatronsPossessions is not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 19329] New: The automatic slip printing does not work when IntranetSlipPrinterJS defined
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Bug ID: 19329 Summary: The automatic slip printing does not work when IntranetSlipPrinterJS defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19296] New: Tax is being subtracted from orders when vendor price does not include gst and ordering from a file
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19296 Bug ID: 19296 Summary: Tax is being subtracted from orders when vendor price does not include gst and ordering from a file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In the case of vendor prices don't include gst we are removing the gst from the order price, passing it to populate_order_with_prices and calculating tax on the price with tax removed! Example: Order with price of $10 and tax rate of 10% We calculate ecost/rrp at 9.09 Then calculate tax on 9.09 We should be calculating tax on $10 In addorderiso2707.pl: 270 if ( $bookseller->listincgst ) { 271 if ( $c_discount ) { 272 $orderinfo{ecost} = $price; 273 $orderinfo{rrp} = $orderinfo{ecost} / ( 1 - $c ); 274 } else { 275 $orderinfo{ecost} = $price * ( 1 - $c ); 276 $orderinfo{rrp} = $price; 277 } 278 } else { 279 if ( $c_discount ) { 280 $orderinfo{ecost} = $price / ( 1 + $orderinfo{tax_rate} ); 281 $orderinfo{rrp} = $orderinfo{ecost} / ( 1 - $c ); 282 } else { 283 $orderinfo{rrp} = $price / ( 1 + $orderinfo{tax_rate} ); 284 $orderinfo{ecost} = $orderinfo{rrp} * ( 1 - $c ); 285 } 286 } ... 296 297 %orderinfo = %{ 298 C4::Acquisition::populate_order_with_prices( 299 { 300 order => \%orderinfo, 301 booksellerid => $booksellerid, 302 ordering => 1, 303 receiving => 1, 304 } 305 ) 306 }; Then in C4 Acquisition: 2943 if ($ordering) { 2944 $order->{tax_rate_on_ordering} //= $order->{tax_rate}; 2945 if ( $bookseller->listincgst ) { 2946 # The user entered the rrp tax included 2947 $order->{rrp_tax_included} = $order->{rrp}; 2948 2949 # rrp tax excluded = rrp tax included / ( 1 + tax rate ) 2950 $order->{rrp_tax_excluded} = $order->{rrp_tax_included} / ( 1 + $order->{tax_rate_on_ordering} ); 2951 2952 # ecost tax excluded = rrp tax excluded * ( 1 - discount ) 2953 $order->{ecost_tax_excluded} = $order->{rrp_tax_excluded} * ( 1 - $discount ); 2954 2955 # ecost tax included = rrp tax included ( 1 - discount ) 2956 $order->{ecost_tax_included} = $order->{rrp_tax_included} * ( 1 - $discount ); 2957 } 2958 else { 2959 # The user entered the rrp tax excluded 2960 $order->{rrp_tax_excluded} = $order->{rrp}; 2961 2962 # rrp tax included = rrp tax excluded * ( 1 - tax rate ) 2963 $order->{rrp_tax_included} = $order->{rrp_tax_excluded} * ( 1 + $order->{tax_rate_on_ordering} ); 2964 2965 # ecost tax excluded = rrp tax excluded * ( 1 - discount ) 2966 $order->{ecost_tax_excluded} = $order->{rrp_tax_excluded} * ( 1 - $discount ); 2967 2968 # ecost tax included = rrp tax excluded * ( 1 - tax rate ) * ( 1 - discount ) 2969 $order->{ecost_tax_included} = 2970 $order->{rrp_tax_excluded} * 2971 ( 1 + $order->{tax_rate_on_ordering} ) * 2972 ( 1 - $discount ); 2973 } 2974 2975 # tax value = quantity * ecost tax excluded * tax rate 2976 $order->{tax_value_on_ordering} = 2977 $order->{quantity} * $order->{ecost_tax_excluded} * $order->{tax_rate_on_ordering}; 2978 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 15644] City dropdown default selection when modifying a patron matches only on city
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. Note: French format doesn't exist in 16.11.x and has been removed from the patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18742] New: Circulation statistics wizard no longer exports the total row
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742 Bug ID: 18742 Summary: Circulation statistics wizard no longer exports the total row Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It seems like a few lines were lost from issues-stats.pl in bug 7679: # footer print "TOTAL"; $cols = @$results[0]->{loopfooter}; print map {$sep.$_->{totalcol}} @$cols; print $sep.@$results[0]->{total}; -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 12346] False patron modification alerts on members-home.pl
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes.

1 0