October 2017 - Koha-bugs - lists.koha-community.org

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62437|0 |1 is obsolete| | --- Comment #125 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 68821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68821&action=ed… bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62436|0 |1 is obsolete| | --- Comment #124 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 68820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68820&action=ed… bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62435|0 |1 is obsolete| | --- Comment #123 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 68819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68819&action=ed… bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '17

30 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62434|0 |1 is obsolete| | --- Comment #122 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 68818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68818&action=ed… bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - added sort_by input param to GetItemsInfo() * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec(a)gmail.com --- Comment #11 from Josef Moravec <josef.moravec(a)gmail.com> --- Kyle, it's nice feature, and I really would like to have it in Koha. But qa tools are complaining about this: FAIL Koha/Patrons.pm FAIL valid Useless use of anonymous hash ({}) in void context FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt FAIL forbidden patterns forbidden pattern: tab char (line 30) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 50) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 123) forbidden pattern: tab char (line 46) forbidden pattern: tab char (line 51) forbidden pattern: tab char (line 32) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 55) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 122) forbidden pattern: tab char (line 53) forbidden pattern: tab char (line 127) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 35) forbidden pattern: tab char (line 126) forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 43) forbidden pattern: tab char (line 29) forbidden pattern: tab char (line 52) forbidden pattern: tab char (line 125) forbidden pattern: tab char (line 124) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 47) forbidden pattern: tab char (line 54) forbidden pattern: tab char (line 45) forbidden pattern: tab char (line 44) forbidden pattern: tab char (line 121) forbidden pattern: tab char (line 120) FAIL members/merge-patrons.pl FAIL valid Useless use of anonymous hash ({}) in void context FAIL t/db_dependent/Patrons.t FAIL forbidden patterns forbidden pattern: tab char (line 149) forbidden pattern: tab char (line 148) FAIL valid Useless use of anonymous hash ({}) in void context -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec(a)gmail.com --- Comment #121 from Josef Moravec <josef.moravec(a)gmail.com> --- Needs adaptation at least because of bug 17248 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19398] New: Wrong date format in quick patron search table
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19398 Bug ID: 19398 Summary: Wrong date format in quick patron search table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When searching for a patron from the circulation tab, the results table shows the date of birth unformatted. (Confirmed for 16.11 so far) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 19405] New: t/db_dependent/api/v1/holds.t fails randomly
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19405 Bug ID: 19405 Summary: t/db_dependent/api/v1/holds.t fails randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 14868 DBD::mysql::st execute failed: Duplicate entry 'cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvn' for key 'userid' [for Statement "INSERT INTO `borrowers` ( `branchcode`, `categorycode`, `flags`, `surname`, `userid`) VALUES ( ?, ?, ?, ?, ? )" with ParamValues: 0='N2ElsY9', 1='Kk8G', 2=80, 3='Test Surname', 4='cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvnnbgezJqmxqwz'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry 'cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvn' for key 'userid' at /kohadevbox/koha/Koha/Object.pm line 121 # Looks like your test exited with 255 before it could output anything. [18:52:19] t/db_dependent/api/v1/holds.t Reading the code I guess it happens if TestBuilder generates a userid with the size of borrowers.userid (75 chars). In that case the following lines are wrong: $borrower->userid($nopermission->{ userid }."z"); $borrower2->userid($nopermission->{ userid }."x"); $borrower3->userid($nopermission->{ userid }."y"); The 3 patrons will have the same userid. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 [Bug 14868] REST API: Swagger2-driven permission checking -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 19392] New: auth_values_input_www.t does not clean up
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19392 Bug ID: 19392 Summary: auth_values_input_www.t does not clean up Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org The two authorised value categories are not removed. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 18422] New: Add Select2 to authority editor
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '17

29 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422 Bug ID: 18422 Summary: Add Select2 to authority editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: synapse.ova(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Overview: Repeat tag fails if authority field has select subfield (for example, UNIMARC 700$8, 800$a) Steps to Reproduce: In authority editor repeat field that has select subfield Actual Results: Field does not repeat (copy is not created). Console shows a js TypeError in cataloging.js: «$(...).select2 is not a function» Expected Results: Field will repeat (copy is created) Additional Information: Error happens in version 16.11+ after adding Select2 js functions. The easiest way to fix is to add Select2 to authority editor -- You are receiving this mail because: You are watching all bug changes.

1 14