October 2017 - Koha-bugs - lists.koha-community.org

[Bug 13178] cardnumber field length is too short
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64646|0 |1 is obsolete| | Attachment #64647|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 68473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68473&action=ed… Bug 13178: increase max value of CardnumberLength testplan 1 - Apply patch 2 - Run updatedatabase.pl 3 - Update dbix scheme 4 - set the value of CardnumberLength to a value between 16 and 32 5 - Check you can enter a propper cardnumber (modify to 32 instead 20) + max value now depends on the database field value to Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10267] No error message when entering an invalid cardnumber
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2454] Improve display of credits on pay fines tab
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 --- Comment #12 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 68470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68470&action=ed… Bug 2454 - Amended patch: Removed the display of accountype, Notify ID, Level values for manual credit in pay.tt and replaced the description with string "Credit" Reimplemented accounttype column but kept the notifyid a nd level columns These specific values have been removed because this bug report requires the manual credit to no longer be shown on the 'Pay fines' tab. In response to comment 4 (thankyou for noticing that Felix) I have redone this patch so users can now successfully pay or write off manual credits because the manual credit values although not being displayed are still being submitted to pay.pl. Test plan: 1. From the Koha staff interface go the Patron area and select a patron page 2. Create a fine of $10 for the patron by clicking on the 'Fines' tab and creating a fine in the 'Create manual invoice' tab 3. Create a credit of $5 for the patron in the 'Create manual credit' page 4. Then go to the 'Pay fines' tab and notice there is a row for both the fine and credit both with values in the account type, Notify ID, and level boxes of the table 5. Select "write off all" and 'OK' in the confirmation box 6. Youre redirected to Account tab, return to 'pay fines' tab and notice no fines or credits are displayed 7. Repeat steps 2, 3, 4 and then click "Pay amount", confirm it, then navigate back to the 'Pay fines' tab and notice although the fine and credit are displayed the 'total due' value is 0.00 8. Apply the patch attached to this bug report 9. Repeat steps 2, and 3. 10. Navigate to 'Pay fines' tab and notice the fine has values in account type, Notify ID, and level and the credit does not. Additionally credit has the description value of 'Credit' 11. Repeat steps 5 and 6 and as with before this patch was applied notice the 'Pay fines' tab does not show any fines or credits 12. Repeat step 7 and again notice the 'Total due' value is 0.00 Bug 2454 - Reimplemented accounttype column but kept the notifyid and level columns Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 2454] Improve display of credits on pay fines tab
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19523 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19441] New: Several tests are failing on 16.05.x
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Bug ID: 19441 Summary: Several tests are failing on 16.05.x Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org xt_sample_notices_t.No sample notice to add xt_sample_notices_t.No sample notice to delete t_db_dependent_XISBN_t.Gets correct biblionumber from a book with a similar isbn using XISBN t_db_dependent_Template_Plugin_AuthorisedValues_t t_db_dependent_Items_AutomaticItemModificationByAge_t t_db_dependent_Biblio_Isbd_t t_db_dependent_SIP_Message_t t_db_dependent_Koha_SearchEngine_Elasticsearch_Search_t t_db_dependent_Koha_SearchEngine_Elasticsearch_Search_t t_db_dependent_00_strict_t.Syntax check misc/search_tools/rebuild_elastic_search.pl t_db_dependent_Koha_Elasticsearch_Indexer_t t_db_dependent_Koha_Elasticsearch_Indexer_t t_db_dependent_Biblio_TransformKohaToMarc_t -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 13392] New statistics wizard for suggestions
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick(a)bywatersolutions.com --- Comment #69 from Nick Clemens <nick(a)bywatersolutions.com> --- Hi Julian, Minor conflict in tests (wrong number) Missing comma in kohastructure.sql between constraints I tried adding a suggestion, ordering it, but never saw the suggestion status update to 'ORDERED' - nothing relevant in error log Reporting seems to work, however, if I don't select both a row and column the page simply reloads and clears data, maybe a warning could be added? Can you provide a clear test plan and verify things are working for you? -Nick -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19047] New: Fix AddBiblio call in Reserves.t
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19047 Bug ID: 19047 Summary: Fix AddBiblio call in Reserves.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 19013] New: sample_data.sql inserts patrons with guarantorid that do not exist
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19013 Bug ID: 19013 Summary: sample_data.sql inserts patrons with guarantorid that do not exist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org MariaDB [koha_kohadev]> select borrowernumber, guarantorid from borrowers where guarantorid is not null; +----------------+-------------+ | borrowernumber | guarantorid | +----------------+-------------+ | 6 | 102 | | 7 | 104 | | 8 | 112 | | 15 | 131 | | 18 | 160 | | 21 | 177 | | 30 | 254 | | 35 | 287 | | 36 | 288 | | 37 | 289 | | 40 | 320 | | 42 | 337 | +----------------+-------------+ MariaDB [koha_kohadev]> select max(borrowernumber) from borrowers; +---------------------+ | max(borrowernumber) | +---------------------+ | 50 | +---------------------+ That breaks randomly tests on Jenkins (Koha/Patrons.t) # Failed test 'new_patron_1 should have 0 guarantee' # at t/db_dependent/Koha/Patrons.t line 85. # got: '1' # expected: '0' # Failed test 'new_patron_1 should have 0 guarantee' # at t/db_dependent/Koha/Patrons.t line 88. # got: '1' # expected: '0' # Failed test 'new_patron_1 should have 2 guarantees' # at t/db_dependent/Koha/Patrons.t line 95. # got: '3' # expected: '2' # Failed test 'new_patron_1 should have 2 guarantees' # at t/db_dependent/Koha/Patrons.t line 98. # got: '3' # expected: '2' # Looks like you failed 4 tests of 8. # Failed test 'guarantees' # at t/db_dependent/Koha/Patrons.t line 100. # Failed test 'Delete should have deleted the patron' # at t/db_dependent/Koha/Patrons.t line 905. # got: '51' # expected: '52' # Looks like you failed 2 tests of 22. [16:26:26] t/db_dependent/Koha/Patrons.t ................................ -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 17940] New: Holds not going to waiting state after having been transferred
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Bug ID: 17940 Summary: Holds not going to waiting state after having been transferred Change sponsored?: --- Product: Koha Version: 16.11 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: stefan.berndtsson(a)ub.gu.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com We seem to have found an issue with holds after transfers. Steps to reproduce (everything done by staff): Allow for On shelf holds. Have library branch A and B. Have one biblio with one item located at library A. Have one patron able to have holds placed on them. 1. Place a hold on biblio for patron, select pickup at library B. 2. Check in item on library A (get a transfer notice). 3. Check in item on library B (another transfer notice). 4. Item is not waiting properly on pickup location. If pickup was set to library A (same as item), it would be properly set to waiting. Expected outcome would be that the item is set to waiting at library B. After step 1, the reserves table contains "NULL" in "found" column. After step 2, "found" contains "T" After step 3, "found" still contains "T", where it should really contain "W". This has been tested with both 16.11.00 and 16.11.01. Thank you. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22