October 2017 - Koha-bugs - lists.koha-community.org

[Bug 14791] Automatically attempt to resend failed notices
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Needs Signoff |BLOCKED --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Depends on bug 14723 which currently doesn't apply. Setting to BLOCKED. Please change back to Needs Signoff once dependency has been resolved. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13146] Improve GetRecordValue function by caching field mapping
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer(a)bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch doesn't apply. It looked to me that SetFieldMapping has been removed since this was written? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13146 UT Applying: Bug 13146 Improve GetRecordValue function by caching field mapping Using index info to reconstruct a base tree... M C4/Biblio.pm Falling back to patching base and 3-way merge... Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 13146 Improve GetRecordValue function by caching field mapping The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-13146-Improve-GetRecordValue-function-by-cachi-G9pMqQ.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am very sorry Julian, it seems the code in AuthoritiesMarc.pm has moved quite a lot since the last rebase. The conflict doesn't look easy to resolve (to me at least). Just a note to help with testing in the future: It's possible to merge authorities in the GUI. Search your authorities, then from the action menu choose 'merge'. When you do that for the second record it will trigger the merge process. Bug 14560 - Introduce a way of handling Rameau composed authorities, without breaking normal workflow 58871 - Bug 14560: Rameau authorities 58872 - Bug 14560 [Follow-up]: Compatible with DOM indexing. 58873 - Bug 14560 [Follow-up]: QA: Add debug warnings and get biblionumber with GetMarcFromKohaField Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14560: Rameau authorities Using index info to reconstruct a base tree... M C4/AuthoritiesMarc.pm M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref Auto-merging C4/AuthoritiesMarc.pm CONFLICT (content): Merge conflict in C4/AuthoritiesMarc.pm Failed to merge in the changes. Patch failed at 0001 Bug 14560: Rameau authorities The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14560-Rameau-authorities-pIduys.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13717] Add ability to move old patron attributes when importing borrowers
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Dependent bug 12598 has reached 'signed off' status now. But this patch no longer applies on top: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13717 - Add ability to move old patron attributes when importing new patron data fatal: sha1 information is lacking or useless (Koha/Borrower/Import.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13717 - Add ability to move old patron attributes when importing new patron data The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-13717---Add-ability-to-move-old-patron-attribu-RtYPcs.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15540] Debian package option to set up an .onion address ( Tor hidden service) for the OPAC
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer(a)bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Can't promise to test this, but maybe an email to the mailing list might find an interested tester? Smallish conflict: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15540 - Debian package option to set up an .onion address (Tor hidden service) for the OPAC Using index info to reconstruct a base tree... M debian/docs/koha-create.xml M debian/scripts/koha-create M debian/scripts/koha-remove Falling back to patching base and 3-way merge... Auto-merging debian/scripts/koha-remove Auto-merging debian/scripts/koha-create CONFLICT (content): Merge conflict in debian/scripts/koha-create Auto-merging debian/docs/koha-create.xml Failed to merge in the changes. Patch failed at 0001 Bug 15540 - Debian package option to set up an .onion address (Tor hidden service) for the OPAC The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15540---Debian-package-option-to-set-up-an-oni-d0f2n1.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14457] Integrate LIBRIS spellchecking
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- As you need to register the IP, I can't test on my kohadevbox. Maybe on a sandbox? QA tool doesn't complain about syspref order, but it was added to the end, maybe while you are on it move them up in the right alphabetic spot? In the system preference description it might be helfpul to add a quick description like "Swedish service for spellchecking" or something so you have a bit more of context looking at the pref and deciding if you want to turn it on. I know LIBRIS to be Swedish, but most people won't. QA test tools fail: FAIL Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'NAME' OK spelling OK valid FAIL installer/data/mysql/sysprefs.sql OK git manipulation FAIL semicolon simicolon found instead of comma at line 596 OK sysprefs_order FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt FAIL forbidden patterns forbidden pattern: tab char (line 17) forbidden pattern: tab char (line 16) OK git manipulation OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15418] Switch Net::Server personality in sipserver to Fork
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15418 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer(a)bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch doesn't apply. Opting for 'Failed QA' because of Srdjan's comment#2. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15418 Use Fork Net::Server personality for sip Using index info to reconstruct a base tree... M C4/SIP/SIPServer.pm M etc/SIPconfig.xml Falling back to patching base and 3-way merge... Auto-merging etc/SIPconfig.xml CONFLICT (content): Merge conflict in etc/SIPconfig.xml Auto-merging C4/SIP/SIPServer.pm CONFLICT (content): Merge conflict in C4/SIP/SIPServer.pm Failed to merge in the changes. Patch failed at 0001 Bug 15418 Use Fork Net::Server personality for sip The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Proposed-patch-pNkHlx.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16313] New: Koha::Logger doesn't forward the Log::Log4perl::Logger return value
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16313 Bug ID: 16313 Summary: Koha::Logger doesn't forward the Log::Log4perl::Logger return value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Log::Log4perl::Logger->$method returns undef if the log level is not logged or something bad happened and true or something similar on success. This allows chaining different loggers to trigger if Log4perl failed to log. Koha::Logger is hardwired to return 1 if Log4perl is configured properly regardless of whether the Log4perl actually succeeded in printing the log message. This is a Log4perl best practice: $Koha::Logger->debug() or syslog("LOG_DEBUG", ...); which should revert to syslog() to log if Log4perl cannot for some reason do the logging. (eg. is disabled) This patch makes the Koha::Logger work with Log4perl better in tandem and return the proper return values. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 15958] New: ZOOM/Zebra-connection cache flushing
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15958 Bug ID: 15958 Summary: ZOOM/Zebra-connection cache flushing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org When writing tests related to searching, When searching the local index repeatedly, changes in the index are not applied to the search results if the results always return the same records. This is due to ZOOM caching the results. This feature adds a ZOOM::Connection flushing subroutine to get rid of old caches. -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML.
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35658|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 68159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68159&action=ed… Bug 13660 - rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. When looking for a bad MARC Record using the rebuild_zebra_sliced.sh, it is useful to skip the complete MARCXML exporting from Koha and reuse the exported files for Zebra indexing. This patch adds a new parameter: -x | --exclude-export Do not export Biblios from Koha, but use the existing export-dir Which depends on the: -d | --export-dir Where rebuild_zebra.pl will export data Default: $EXPORTDIR !---------! ! TEST PLAN ! !---------! 1. Run "./rebuild_zebra_sliced.sh --length 1000" to export 1000 MARC Records and slice them to one big 1000-Record chunk. 2. Realize that you get an imaginary "stack smashing detected"-error crashing your indexing at some Record you dont know of and can't make out from the indexing logging. 3. Start looking for the bad Record by running: "./rebuild_zebra_sliced.sh --exlude-export --chunk-size 10" To skip Biblios export from Koha which takes ~2h and get straight into splitting your exported biblios to chunks of 10, and indexing them. You know which chunk fails so it is much easier to find the issue there. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0