October 2017 - Koha-bugs - lists.koha-community.org

[Bug 16313] New: Koha::Logger doesn't forward the Log::Log4perl::Logger return value
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16313 Bug ID: 16313 Summary: Koha::Logger doesn't forward the Log::Log4perl::Logger return value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Log::Log4perl::Logger->$method returns undef if the log level is not logged or something bad happened and true or something similar on success. This allows chaining different loggers to trigger if Log4perl failed to log. Koha::Logger is hardwired to return 1 if Log4perl is configured properly regardless of whether the Log4perl actually succeeded in printing the log message. This is a Log4perl best practice: $Koha::Logger->debug() or syslog("LOG_DEBUG", ...); which should revert to syslog() to log if Log4perl cannot for some reason do the logging. (eg. is disabled) This patch makes the Koha::Logger work with Log4perl better in tandem and return the proper return values. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 15958] New: ZOOM/Zebra-connection cache flushing
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15958 Bug ID: 15958 Summary: ZOOM/Zebra-connection cache flushing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org When writing tests related to searching, When searching the local index repeatedly, changes in the index are not applied to the search results if the results always return the same records. This is due to ZOOM caching the results. This feature adds a ZOOM::Connection flushing subroutine to get rid of old caches. -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML.
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35658|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 68159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68159&action=ed… Bug 13660 - rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. When looking for a bad MARC Record using the rebuild_zebra_sliced.sh, it is useful to skip the complete MARCXML exporting from Koha and reuse the exported files for Zebra indexing. This patch adds a new parameter: -x | --exclude-export Do not export Biblios from Koha, but use the existing export-dir Which depends on the: -d | --export-dir Where rebuild_zebra.pl will export data Default: $EXPORTDIR !---------! ! TEST PLAN ! !---------! 1. Run "./rebuild_zebra_sliced.sh --length 1000" to export 1000 MARC Records and slice them to one big 1000-Record chunk. 2. Realize that you get an imaginary "stack smashing detected"-error crashing your indexing at some Record you dont know of and can't make out from the indexing logging. 3. Start looking for the bad Record by running: "./rebuild_zebra_sliced.sh --exlude-export --chunk-size 10" To skip Biblios export from Koha which takes ~2h and get straight into splitting your exported biblios to chunks of 10, and indexing them. You know which chunk fails so it is much easier to find the issue there. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML.
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #71 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- With the patch applied the message "Not checked out." appears twice when returning an item that has not been checked out. QA tools also highlight some issues: FAIL C4/Circulation.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling FAIL valid "my" variable $item masks earlier declaration in same scope FAIL C4/Items.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid FAIL C4/Reserves.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling FAIL valid "my" variable $item masks earlier declaration in same scope OK C4/UsageStats.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid FAIL circ/returns.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid "my" variable $item masks earlier declaration in same scope OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/authorised_values.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL t/db_dependent/Circulation/Returns.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid "my" variable $item masks earlier declaration in same scope FAIL t/db_dependent/Circulation/issue.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid "my" variable $item masks earlier declaration in same scope FAIL t/db_dependent/UsageStats.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid "my" variable $item masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67889|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 68149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68149&action=ed… Bug 15494 - Add syspref Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67888|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 68148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68148&action=ed… Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67887|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 68147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68147&action=ed… Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67886|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 68146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68146&action=ed… Bug 15494 - Unit tests prove t/db_dependent/Circulation.t Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '17

15 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This seems to work quite well! Also tested renew through checkout, renewal tab and OPAC. When renewing the item from the list of checkouts and using the renewal limit override functionality, the message displayed is: Renew failed: item_denied_renewal This could be improved, maybe with a small follow-up? -- You are receiving this mail because: You are watching all bug changes.

1 0