October 2017 - Koha-bugs - lists.koha-community.org

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67808|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 68133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68133&action=ed… Bug 14919: Add test for Koha::Patron->old_holds subroutine Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi David, thx for the updated test plan. I reset my system since and I could see the bug and confirm the fix now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67102|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 68132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68132&action=ed… Bug 14784 - Fix checkin message for debarred patrons Tested and bug still exists, however previous patch did not apply and relied on obsolete code. Test plan: Before 1) Select a user with active restrictions 2) Make sure finesday=0 for the user category 3) Checkout and return an item (not overdue) : a previous restriction reminder will appear 4) Checkout and return an overdue item : no previous restriction reminder will appear After applying patch: Same steps, but a reminder should appear for step 4) I've also tested with finesday=1 with "no overdue", "grace period overdue" and "long overdue" test cases. The appropriate nessage appeared for each test. P.S.: The "finesday" setting is called "Suspension days" in the web interface, if you're searching for it like I did... Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #36 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sequence of attached patches is wrong, but works when you apply them in order :) I have started testing by regression testing the bibliographic frameworks export and import and for the default framework some things seem not quite right: - When exporting the default framework to Excel format the file ending changed from xml to ods for bibliographic frameworks - Reimporting the exported file for Default always results in unspecific error message. - QA might ask for tests for the changes to ImportExportFramework.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11976] show issue date instead of received date for serials in opac
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11976 - Show publication date instead of received date Applying: Bug 11976 - Display either or both publication date and receival date error: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). error: could not build fake ancestor Patch failed at 0001 Bug 11976 - Display either or both publication date and receival date The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11976---Display-either-or-both-publication-dat-6GeGs3.patch Some things in the second patch don't look quite right - it seems to contain some changes that don't belong to the patch (drop lines for tables, delete for the pref). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 67165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67165 Bug 11300 - Add a new authority linker which searches for authority links on a Z39.50 server. Review of attachment 67165: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=113…) ----------------------------------------------------------------- Hi Bouzid, noted some thing in the splinter review. Additionally: - atomicupdate for adding the system preference is missing - You will have to add tests for the new module to pass QA - QA tools show some fails: OK C4/Biblio.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid FAIL C4/Linker/Z3950Server.pm FAIL critic Found use of Switch. This module is deprecated by the Perl 5 Porters at line 223, column 5. Find an alternative module. OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for flip_heading POD is missing for getZ3950Authority POD is missing for get_link POD is missing for update_cache OK spelling OK valid OK cataloguing/automatic_linker.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid FAIL installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon FAIL sysprefs_order Not blocker: Sysprefs AdditionalFieldsInZ3950ResultSearch is bad placed (see bug 10610) - I've tried to configure and test the feature, but see an alert with an internal server error. Plack error logs show: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_cataloguing_automatic_linker_2epl line 65, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. Personal-name,do-not-truncate,ext="K�rger, Walter Christian" ZOOM error 114 "Unsupported Use attribute" (addinfo: "Personal-name") from diag-set 'Bib-1' at /home/vagrant/kohaclone/C4/Linker/Z3950Server.pm line 260. Can't locate object method "get_link" via package "C4::Linker::Default" (perhaps you forgot to load "C4::Linker::Default"?) at /home/vagrant/kohaclone/C4/Biblio.pm line 533. ::: C4/Linker/Z3950Server.pm @@ +15,5 @@ > +# You should have received a copy of the GNU General Public License > +# along with Koha; if not, see <http://www.gnu.org/licenses>. > + > +use strict; > +use warnings; Please use Modern::Perl instead! ::: installer/data/mysql/sysprefs.sql @@ +8,5 @@ > ('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create a duplicate invoice','YesNo'), > ('AddressFormat','us','us|de|fr','Choose format to display postal addresses', 'Choice'), > +('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC field/subfields are displayed in -Additional field- column in the result of a search Z3950', 'Free'), > +('AddPatronLists','categorycode','categorycode|category_type','Allow user to choose what list to pick up from when adding patrons','Choice'), > +('AddressFormat','us','','Choose format to display postal addresses', 'Choice'), I think there is a merge error here - the new pref (LinkerZ3950Server) is missing and others are doubled up. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19437] New: Orphaned QA follow-up: Rearrange CancelExpiredReserves tests
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19437 Bug ID: 19437 Summary: Orphaned QA follow-up: Rearrange CancelExpiredReserves tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 19260] New: Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Bug ID: 19260 Summary: Reservations / holds marked as problems being seen as expired ones and deleted wrongly. Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: r.delahunty(a)arts.ac.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com We have the ReservesMaxPickupDelay set to 7 and the ExpireReservesMaxPickupDelay system parameter set to Don’t Allow. Our workflow is that staff use the report generated by waitingreserves.pl to identify titles to retrieve from the Reservations / holds awaiting pickup shelf, and delete the reservation and return the items to the shelf, or have that action trigger reservation satisfaction for the next person in the queue. Since our upgrade for 16.05 to 17.05 we are finding that when we run the cancel_expired_holds.pl job at 01:00 daily, reservations marked as problem ones are being deleted in addition to expired ones (expiration date set by user has been reached, or the default 100 days has been reached). Koha 17.05 appears to be disregarding the ExpireReservesMaxPickupDelay system parameter. (http://translate.koha-community.org/manual/master/en/html/17_cron_jobs.html…) We have suspended this cron job in the meantime, and will write a query to identify expired ones we need to delete. Ideally we want problem reservations NOT to be seen as expired ones. Ray Delahunty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 49