November 2017 - Koha-bugs - lists.koha-community.org

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Would have preferred to see a test for GetOverduesForBranch, but it is not a blocker for me. A rename of this sub would be nice too (see FIXME). Something like GetOverduesWithFines ? Similarly, it is weird that the script branchoverdues.pl (whats in a name) does not list Overdues with fines in the header but just Overdues. Apart from these observations, it is wonderful to see dead code moving out ! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68920|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68959&action=ed… Bug 10021: (QA follow-up) Rename variables To avoid $account, $accounts and @accounts variables in the same scope Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68798|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68958&action=ed… Bug 10021: Restore "Pay fines" list Previous changes were wrong, the notify_id was always equal to 1 and GetBorNotifyAcctRecord was used to retrieved the account lines to pay Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68797|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68957&action=ed… Bug 10021: Remove notify columns in circ/branchoverdues.tt Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68796|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68956&action=ed… Bug 10021: Remove accountlines columns - DBIC Schema changes Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68795|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68955&action=ed… Bug 10021: Update DB changes Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68794|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68954&action=ed… Bug 10021: Drop columns notify_id and notify_level from accountlines It appears that has never worked. Could someone confirm? Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68793|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68953&action=ed… Bug 10021: Drop table notifys and related code This patch drops the notifys table and its related code in C4::Overdues. A second patch should remove the 2 columns notify_id and notify_level from the accountlines table. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0