November 2017 - Koha-bugs - lists.koha-community.org

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68795|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68955&action=ed… Bug 10021: Update DB changes Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68794|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68954&action=ed… Bug 10021: Drop columns notify_id and notify_level from accountlines It appears that has never worked. Could someone confirm? Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68793|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68953&action=ed… Bug 10021: Drop table notifys and related code This patch drops the notifys table and its related code in C4::Overdues. A second patch should remove the 2 columns notify_id and notify_level from the accountlines table. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #35 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #33) > (In reply to Marcel de Rooy from comment #32) > > QA Comment: > > > > GetOverduesForBranch > > Please add a test. You make some fundamental changes here. > > Fundamental? I do not understand what you want me to test. Maybe non-trivial would have been a better word ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10748] Add option to block return of lost items
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

1 0

[Bug 10748] Add option to block return of lost items
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68952&action=ed… Bug 10748: (QA follow-up) Add comment in SIP's do_checkin Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10748] Add option to block return of lost items
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68919|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68951&action=ed… Bug 10748: Add tests Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10748] Add option to block return of lost items
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68112|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68950&action=ed… Bug 10748: Add the ability to block return of lost items Mimicking what does BlockReturnOfWithdrawnItems we can easily add a new syspref to block return of lost items. This patch adds BlockReturnOfLostItems, if set to 'Block' a item marked as lost cannot be checked in. Test plan: 1/ Set BlockReturnOfLostItems to 'Do not block' 2/ Check an item out to a patron 3/ Edit the item and mark it as lost (*) 4/ Check the item in => The item is checked in 5/ Edit the item and remove the lost status 6/ Check the item out again 7/ Edit the item and mark it as lost (*) 8/ Check the item in => The item is not checked in (*) There are 2 ways to mark an item lost: - From the item list view (/catalogue/moredetail.pl?biblionumber=42) If you set the lost status from this form, the issue will be returned Maybe this should be optional (?) - From the edit items form (/cataloguing/additem.pl?biblionumber=42) It is the form you must use to not mark the issue returned. Signed-off-by: Dominic Pichette <dominic(a)inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10748] Add option to block return of lost items
by bugzilla-daemon＠bugs.koha-community.org 06 Nov '17

06 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- There is a difference with the Withdrawn case. If the item is Lost, checking it in will remove the lost status. So the second checkin will not be blocked anymore although you set the pref. If the item is withdrawn, the status remains the same. So a second try will be blocked again. No 'blocker' for me. Tested it with SIP too. Got a failed checkin. So that is OK. The message "Checkin failed" is not very informative though. You need to inspect syslog (staff member ;) to see this warning: Checkin failed: probably for Wrongbranch or withdrawn This warn comes from SIP/ILS.pm line 237. It could be 'enriched' with the blocked lost-case, but it is more a comment for developers than something useful. Adding a comment in a follow-up. -- You are receiving this mail because: You are watching all bug changes.

1 0