November 2017 - Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #175 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68926&action=ed… Bug 7317: opac.css update Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68561|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #128 from Josef Moravec <josef.moravec(a)gmail.com> --- Hi Srdjan, I did test these patches now, but I am sorry: The test Search.t is failing after this patchset... # Failed test 'Warning is raised correctly for invalid tags in MARC::Record' # at t/db_dependent/Search.t line 681. there are also so many warnings about preferences missing in mock virtualshelves on intranet and opac goes to ISE: DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse has_many results in iterator mode due to order criteria - performed an eager cursor slurp underneath. Consider using ->all() instead at /home/vagrant/kohaclone/Koha/Objects.pm line 209 Can't use string ("1") as an ARRAY ref while "strict refs" in use at /home/vagrant/kohaclone/C4/XSLT.pm line 290. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19576] New: opac-detail has multiple Koha::Biblios
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576 Bug ID: 19576 Summary: opac-detail has multiple Koha::Biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Marcel noticed this while QA'ing another bug. Simply remove the duplicate line. Confirm the page loads and works as expected. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68886|0 |1 is obsolete| | --- Comment #174 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68922&action=ed… Bug 7317: (QA followup) Get rid of warnings from the tests Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68885|0 |1 is obsolete| | --- Comment #173 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68921&action=ed… Bug 7317: Handle backend absense more gracefuly 5/ This patch makes Koha::Illrequest->load_backend raise an exception if the passed backend is invalid. This way we will catch more errors introduced. The patch also disables the 'New Ill request' when no backends are available. Gets rid of a related warnings. Both OPAC and Intranet now display a warning message when no backends are available. Tests are added for the load_backend changes. 4/ This patch fixes the path for the checkboxes jquery plugin, and removes the include for tablesorter, as this implementation uses Datatables. This is obviously code for older Koha, ported to master. TODO: There's something wrong on the styling. My idea is to get rid of the custom column visualization tool, and have it display as regular DataTables. We can then introduce the use of colvis on a separate bug report. Note: POD coverage for the exceptions file is wrongly tested. It is a false positive. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Simon, make sure your branch is up-to-date with origin/master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 68920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68920&action=ed… Bug 10021: (QA follow-up) Rename variables To avoid $account, $accounts and @accounts variables in the same scope -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10021] Remove dead code related to notifys
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '17

03 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #30) > When you remove a sub from a module without full coverage, this is the > result. Something for QA tools ? Yes, could be improved. POD failures must be considered as warnings. (In reply to Marcel de Rooy from comment #31) > (In reply to Jonathan Druart from comment #8) > > It appears that has never worked. > > Could someone confirm? > > Did you have any response whatsoever ? I think we discussed it on IRC, but I do not find the logs. (In reply to Marcel de Rooy from comment #32) > QA Comment: > > GetOverduesForBranch > Please add a test. You make some fundamental changes here. Fundamental? I do not understand what you want me to test. > koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt > - <input type="hidden" name="totals[% line.accountlines_id %]" value="[% > line.totals %]" /> > Not sure. Why do yo remove this line ? Yes it could have been done somewhere else, it's not directly related to these changes. There is no "totals*" variables retrieved from the pl script. > New code: > + my $accounts = Koha::Account::Lines->search({ borrowernumber => > $borrowernumber, }, { order_by => ['accounttype'] }); > + my @accounts; > + while ( my $account = $accounts->next ) { > This does not look very nice. Can we get more confusion on $account, > @accounts or $accounts ? > Renaming @accounts here might be the least we can do? > No blocker on itself. Will fix. -- You are receiving this mail because: You are watching all bug changes.

1 0