December 2017 - Koha-bugs - lists.koha-community.org

[Bug 16401] New: System preference staffClientBaseURL hardcoded to 'http' in svc / import_bib
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401 Bug ID: 16401 Summary: System preference staffClientBaseURL hardcoded to 'http' in svc / import_bib Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: z.tajoli(a)cineca.it QA Contact: testopia(a)bugs.koha-community.org In many points now, in particular in CAS authentication, we use the system preference staffClientBaseURL as OPACBaseURL. The preference should be a complete URL, starting with http:// or https://. So we need to change svc/import_bib line 101. From my $url = 'http://'. C4::Context->preference('staffClientBaseURL') .'/cgi-bin/koha/catalogue/detail.pl?biblionumber='. $biblionumber; To my $url = C4::Context->preference('staffClientBaseURL') .'/cgi-bin/koha/catalogue/detail.pl?biblionumber='. $biblionumber; It is probably a good idea to change also koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref. Like OPACBaseURL: " . This should be a complete URL, starting with http:// or https://. Do not include a trailing slash in the URL. (This must be filled in correctly for CAS, svc, and load_testing to work.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 32

[Bug 19453] New: Client side validation broken for "Fund" select
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '18

07 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 Bug ID: 19453 Summary: Client side validation broken for "Fund" select Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This might be a regression, or perhaps it has never worked, but the js-validation for the "Fund" select uses the selector [name="fund_code"] when the element is named "fund_id", correcting the selector fixes this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 17164] New: Software error when enrolment fee or reserve fee are too high ( Patron categories)
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '18

06 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164 Bug ID: 17164 Summary: Software error when enrolment fee or reserve fee are too high (Patron categories) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com For some reason I had ridiculously high enrolment fee and reserve fee data causing a software error when trying to access Patron Categories Software error: Template process failed: undef error - round() overflow. Try smaller precision or use Math::BigFloat at /home/vagrant/kohaclone/Koha/Number/Price.pm line 44. My enrolment fee was set at 8866609962973970000000.00 and my reserve fee was set at 3862694923528880000000.00 Obviously it's very unlikely for a librarian to set the enrolment fee or reserve fee to be this high but if it happens accidentally, it breaks the system and causes this error. Perhaps there should be some kind of constraint when entering this, like a maximum reserve fee constraint etc.? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 19461] New: Add floating toolbar to staff client catalog search results
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '18

06 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461 Bug ID: 19461 Summary: Add floating toolbar to staff client catalog search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Created attachment 68075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68075&action=ed… Screenshot of the proposed updated interface I propose to add a floating toolbar to the staff client catalog search results page. This toolbar would contain all the "controls" related to search results: Check all, Highlight, Add to Cart, Add to Lists, Z39.50 Search, Sort. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 18880] New: Regression breaks local authentication fallback for all external authentications
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Bug ID: 18880 Summary: Regression breaks local authentication fallback for all external authentications Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: oliver.bock(a)aei.mpg.de QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Created attachment 64719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64719&action=ed… Proposed patch A regression in commit cfc484b17 / bug #18314 breaks the local authentication fallback for all external authentications like LDAP, CAS and Shibboleth. The severity is critical for us as we, while using LDAP authentication, use the self-service checkout which requires a local user account. Also non-LDAP staff can't log into the staff pages anymore. The regression itself is a logical error as "@return = (0)" is considered to be "false" when checked with "unless". That's wrong as "unless" tests the number of elements in a list. Thus the "falsy" condition has to established with "@return = ()" instead. Please find attached a proposed patch against "17.05.x". Also, please make sure the fallback workflow gets test coverage. Thanks, Oliver -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 51

[Bug 19610] New: koha-common.logrotate should use copytruncate
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19610 Bug ID: 19610 Summary: koha-common.logrotate should use copytruncate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net Both bug 15713 and bug 16138 introduce service restarts when log rotation happens. This is done: - Stop services (plack and zebra) - Rotate the log file - Start services (plack and zebra) This can be avoided by using the 'copytruncate' directive in the logrotate configuration [1] [1] Search for 'copytruncate' here https://linux.die.net/man/8/logrotate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 18128] New: 'Go to page' option for search results in opac and staff
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '18

04 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Bug ID: 18128 Summary: 'Go to page' option for search results in opac and staff Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org As suggested in Bug 13205 Comment 1 -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 19777] New: Move template JavaScript to the footer: Serials, part 3
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '18

04 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Bug ID: 19777 Summary: Move template JavaScript to the footer: Serials, part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for even more of the serials templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 15839] New: Move the reviews related code to Koha::Reviews
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '18

04 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Bug ID: 15839 Summary: Move the reviews related code to Koha::Reviews Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 15449 The subroutines in C4::Reviews are only doing CRUD operations. This module can be moved easily to Koha::Reviews. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

1 64

[Bug 16583] New: Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7
by bugzilla-daemon＠bugs.koha-community.org 30 May '18

30 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583 Bug ID: 16583 Summary: Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7 Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: Linux Status: NEW Severity: major Priority: P2 Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: liz(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Have noticed some strangeness with a clean install of Koha on MySQL 5.7: When adding a rule at /cgi-bin/koha/admin/smart-rules.pl, if any box is left empty the first empty field pops an error similar to this: DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for column 'chargeperiod' at row 1 at /usr/share/koha/intranet/cgi-bin/admin/smart-rules.pl line 170 When attempting to add a borrower category, it thinks a duplicate has been added with the resultant error message "An error occurred when inserting this patron category. The patron category might already exist." The code for the category did not already exist. I am reporting this bug on behalf of Son Nguyen - he may choose to add any other information he has to this report. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16