February 2017 - Koha-bugs - lists.koha-community.org

[Bug 3116] ISBD parsing does not preserve subfield order
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3116 Pongtawat <pongtawat(a)punsarn.asia> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pongtawat(a)punsarn.asia --- Comment #3 from Pongtawat <pongtawat(a)punsarn.asia> --- I made a patch that add an option "all" to the field list that will show all subfields in order as they appeared in the record, separated by specified separator. Test 1. Add a MARC record with 650 with some subfields, says a z x a 2. Assume the ISBD preference define template for 650 as follows: #650|<br/><br/><label>Subjects--Topical Terms: </label>|{\n6503 }{\n650a}{ 650b }{ 650c }{ 650d }{ 650e }{--650x}{--650z}{--650y}{--650v}| 3. Go to ISBD tab, it will show: Subjects--Topical Terms: a--a--x--z 4. Apply patch 5. Go to ISBD tab, it will show the same result as in 3. 6. Change ISBD template for 650 to #650|<br/><br/><label>Subjects--Topical Terms: </label>|all--| 7. Go to ISBD tab, it will show: Subjects--Topical Terms: a--z--x--a Separator can be changed to something else, just put it after "all" (Patch tested on 16.11) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Baptiste <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60530|0 |1 is obsolete| | --- Comment #8 from Baptiste <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 60563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60563&action=ed… BUG 12310 : Modified scripts in order to convert any string to the good format paxed's solution is obsolete since the form asks for a number. The script includes 2 function which check if it is possible to transform properly into the format "XX.XX" and which do it. The money symbols are ignored. All other symbols are ignored. Test plan : 1) Check you can't enter any string except like "XX.XX" when - you create a Budget (Administration->Budget) - you write a fine (Circulation->[select a Borrower]->new fine ) - you pay an existing fine 2) Apply patch 3) Check you can enter any string with - anything you want - a , or a . as separator (both are default) - change the syspref DigitSeparator into the separator you with and check again ex : XXX,XXX,XXX.XX => . XXX XXX XXX,XX => ,. or , XXX XXX XXX.XX => ,. or . The string is immediately changed after you change the field Please note that any other symbole is ignored -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured.
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26374|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured.
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.hamidi(a)inlibro.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured.
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 --- Comment #5 from Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> --- Created attachment 60562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60562&action=ed… Bug 11808 - Add the SearchCardnumberWithLDAP system preference. When activated, cardnumber searches in the intranet will also do a search on the LDAP server if a user was not found in the local database. If the cardnumber is found on the LDAP server, the user account is imported in the local database. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #56 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #55) > In my opinion, this patchset is not ready to be QAed. Lot of changes should > be done to meet our coding guidelines. Jonathan, can you be more specific? That sounds like QA to me ; ) I've been working on the feature since 2012. It's already gone through one full rewrite because Koha's coding guidelines had moved on so much since it was initially written. If you want another signoff, that's fine. But you specifically wrote "Lot of changes should be done to meet our coding guidelines" which is not a task for a signer. That's a task for a QA'er and I'll really need some actionable comments if I am to make any changes! If you want another sign-off, please set status to needs sign-off. Otherwise the status can go back to failed qa. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #1 from rkuiper(a)roundrocktexas.gov --- We are very interested in this bug. Nothing has happened on this for over a year. Would someone give me a status update on this? Thanks, Rhonda K. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 rkuiper(a)roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper(a)roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #55 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- In my opinion, this patchset is not ready to be QAed. Lot of changes should be done to meet our coding guidelines. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to marc subfields
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.hamidi(a)inlibro.com --- Comment #29 from Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> --- Hello everyone, I rebased the patch and removed two patches that were not necessary. I also addressed some of the the comments : (In reply to Jonathan Druart from comment #23) > ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt > @@ -111,4 @@ > > <input type="checkbox" name="important" id="important" value="1" /> > > [% END %] > > </li> > > - <li><label for="authorised_value">Authorized value: </label>[% authorised_value %] (if you select a value here, the indicators will be limited to the authorized value list)</li> > > Why do you remove this line? I put back the line, as for why it was removed, I'm not sure. (In reply to Jonathan Druart from comment #24) > QA comments: > 1/ You have to deal with the items' fields too. I can mark a 995/952 field > as important, but the behavior is not implemented when adding items. > 2/ If a field is marked as important and mandatory, there are 2 stars (1 red > and 1 black), is it the expected behavior? Maybe the importance of a field > can be ignored if it is also marked as mandatory. I did not fix the first point as it requires more development, but for your second point I fixed it and it won't show important if the field is also mandatory. -- You are receiving this mail because: You are watching all bug changes.

1 0