February 2017 - Koha-bugs - lists.koha-community.org

[Bug 15108] OAI-PMH provider improvements
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com Status|Signed Off |Failed QA --- Comment #82 from Julian Maurice <julian.maurice(a)biblibre.com> --- The tests fail for me: 1. If I have data in the issues table I get an error : > DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key > constraint fails (`koha`.`issues`, CONSTRAINT `issues_ib fk_2` FOREIGN KEY > (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE) [for > Statement "DELETE FROM biblio"] at t/db_dependent/OAI/Server.t line 62. This can be easily fixed by deleting all issues before deleting all biblios 2. Biblio records are MARC21 (245$a for the title), so, as a UNIMARC user I get nothing in dc:title (tests "ListRecords oai_dc ..."). 3. I don't know if this one is related to MARC21/UNIMARC but I also get nothing in dc:language (hashref expected) (tests "ListRecords oai_dc ...") Result of prove here: http://paste.koha-community.org/325 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #57 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Kyle, I did not write the different failures because most of them are obvious: 1. There are no tests 2. CamelCase instead of snake_case for methods of Koha::Clubs and Koha::Patron 3. GetClubEnrollmentsCount and GetEnrollableClubsCount are not needed, just call ->count 4. You should not need to add GetBranches to the Branches TT plugin. Take a look at options_for_libraries 5. Subroutine added to Koha TT plugin (UserEnv), but not used. 6. Changes to circ/circulation.pl are not needed. A variable 'patron' is already passed to the template. 7. All the labels of the form has the same value for the "for" attribute. 8. Tables on clubs/clubs.pl are ugly (missing datatables.css?) 9. On /clubs/clubs-add-modify.pl?club_template_id=1, there is an empty input at the end of the form. 8. CGI->param must not be called in scalar context 9. When I save a form, I get "Your club was created" with a link to "Return to patron clubs". That sounds weird. Especially because the box is yellow. I'd suggest to behave as everywhere else in Koha: Save and get the list. I guess it's because there are too many small scripts, maybe it would have been easier to have a bigger one and have the different action handled in it (as everywhere else in admin scripts). 10. INSERT statements should have IGNORE in update db process 11. + `branchcode` varchar(10) COLLATE utf8_unicode_ci NULL DEFAULT NULL, you should not need to specify the COLLATE here. 12. QA tests do not pass FAIL Koha/Patron.pm FAIL forbidden patterns forbidden pattern: merge marker (>>>>>>>) (line 647) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18136] New: Content of ExportRemoveFields is not picked to pre-fill field list
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18136 Bug ID: 18136 Summary: Content of ExportRemoveFields is not picked to pre-fill field list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 18025] New: Expired password recovery links cause sql crash
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025 Bug ID: 18025 Summary: Expired password recovery links cause sql crash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: liz(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Trying to reset a password with an expired token leads to a very user unfriendly sql crash: DBD::mysql::st execute failed: Duplicate entry '19' for key 'PRIMARY' [for Statement "INSERT INTO `borrower_password_recovery` ( `borrowernumber`, `uuid`, `valid_until`) VALUES ( ?, ?, ? )" with ParamValues: 0='19', 1='$2a$08$O8FjE434Ue3DLtGTgQB3Bu', 2='2017-02-02T22:03:01'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '19' for key 'PRIMARY' at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 127 We should delete these if they exist, and issue a new token. -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 --- Comment #3 from Marc Véron <veron(a)veron.ch> --- @Katrin: What would you like that it looks like? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16984] New: Acquisitions broken
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 Bug ID: 16984 Summary: Acquisitions broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In acquisitions, even if AcqCreateItem is set to create an item at the time of ordering, the item creation form does not display. Instead, this JavaScript error shows in the console: additem.js:176 Uncaught TypeError: window[events[i]] is not a function I believe this regression was introduced by bug 15531. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 16115] New: JavaScript error on item search form
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 Bug ID: 16115 Summary: JavaScript error on item search form Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/catalogue/itemsearch.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org In the template for the item search page there is this at line 290: { 'type': 'select', 'values': [% notforloans.json %] }, [% notforloans.json %] appears to be undefined, whether the search form has been submitted or not. Viewing source shows this: { 'type': 'select', 'values': }, ...and the Firebug console reports this error: SyntaxError: expected expression, got '}' /cgi-bin/koha/catalogue/itemsearch.pl Line 240 -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 11450] Hold Request Confirm Deletion
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com --- Comment #27 from Mason James <mtj(a)kohaaloha.com> --- Pushed to 16.05.x, for 16.05.10 release -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17871] New: Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 Bug ID: 17871 Summary: Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Colin Campbell and Frédéric Demians mentioned in 2015 that Zebra facets don't work with YAZ 5.8.1: https://lists.katipo.co.nz/public/koha/2015-February/041987.html In 2016, Zeno said he couldn't get zebra::snippet to work: http://koha.1045719.n5.nabble.com/Zebra-the-elements-zebra-snippet-doesn-t-… I've looked at Indexdata's YAZ git repo for 5.8.1: https://github.com/indexdata/yaz/blame/v5.8.1/src/retrieval.c And I think the problem is this commit: https://github.com/indexdata/yaz/commit/f24766f1e9fc5404fc0b512af8607d7f705… At first, I thought the problem was with yaz_match_glob, but I've tested this function independently, and I think it's OK. I think the problem might be with how "el_best" is getting set. In theory, <retrieval syntax="xml"/> should be selected as el_best first... then zebra::* should be selected as it should have a true value returned from yaz_match_glob. (Note that "return 0" appears to indicate success for yaz_retrieval_request.) So if you try to use facets with YAZ 5.8.1, you get the following from Zebra: [25] Specified element set name not valid for specified database -- v2 addinfo ''. That makes it seem like el_best isn't being set at all... but I don't know. I'm going to email Indexdata and see what they come up with for this one. But in any case... I have a solution for now. If we remove the line <retrieval syntax="xml" name="zebra::*" /> and restart Zebra, we can get results using zebra::facet and zebra::snippet. I've tested this change with OpenSuse Leap 42.2 with Zebra 2.0.60 and YAZ 5.8.1, and it works, but I'd be interested in hearing about other people's experiences with older (and newer) versions of YAZ. With commit 67abcc64, Marcel actually removed most unnecessary retrieval elements, but Tomas added them back with ca074c92 along with the zebra::* line. -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '17

23 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com --- Comment #54 from Mason James <mtj(a)kohaaloha.com> --- Pushed to 16.05.x, for 16.05.10 release -- You are receiving this mail because: You are watching all bug changes.

1 0