February 2017 - Koha-bugs - lists.koha-community.org

[Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com Status|Needs Signoff |In Discussion --- Comment #2 from M. Tompsett <mtompset(a)hotmail.com> --- This is the first column: [% IF itemloo.not_holdable %] [% IF itemloo.not_holdable == 'damaged' %] Item damaged [% ELSIF itemloo.not_holdable == 'ageRestricted' %] Age restricted [% ELSIF itemloo.not_holdable == 'tooManyHoldsForThisRecord' %] Exceeded max holds per record [% ELSIF itemloo.not_holdable == 'tooManyReserves' %] Too many holds [% ELSIF itemloo.not_holdable == 'notReservable' %] Not holdable [% ELSIF itemloo.not_holdable == 'cannotReserveFromOtherBranches' %] Patron is from different library [% ELSIF itemloo.not_holdable == 'itemAlreadyOnHold' %] Patron already has hold for this item [% ELSE %] [% itemloo.not_holdable %] [% END %] [% END %] This is what Marc V added: <td> [% IF ( itemloo.itemlost ) %]Lost[% END %] [% IF ( itemloo.damaged ) %]Damaged[% END %] [% IF ( itemloo.withdrawn ) %]Withdrawn[% END %] </td> I think there are some underlying design issues which require further thought or at least explanation. It makes little sense to me to have two columns displaying something about the fact that it is damaged. It also is confusing that itemlost, damaged, and withdrawn would be in the same column. I didn't read the code deeper. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.hamidi(a)inlibro.com --- Comment #30 from Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> --- The patch has been rebased on the current master. I made some changed to base on Jonathan comments. (In reply to Jonathan Druart from comment #26) > Suggestions: > What about moving all the cronjob prefs to a new "cronjob" tab? > What about a new pref to turn all of these prefs on/off? > > > Review: > 1/ Change in the behavior if the script is called without parameter (help is > not displayed anymore). > I think we should add a confirm flag if the pref will be used and --days is > not given. > 2/ +use English qw( -no_match_vars ); > why that? > 3/ It would have been good to use Pod2usage > > Failing QA for 1. 1- The script now show help if no parameter is passed and the system preference is not set. 2- I removed this line, apparently $PROGRAM_NAME needed it, so I changed the variable to $0 to display the name (relative path) of the script. 3- Maybe another patch. (In reply to Katrin Fischer from comment #27) > Just a note here - please think if systems with multiple instances. I have > run into several problems with other cronjobs lately :( It would be nice if > a move to sysprefs allows you to schedule it for all instances, while it > will only be active for ones with the pref set. Not sure if it's doable > without behaviour change... but you can make wishes, right? :) We'll keep this in mind :) This was just a rebase and minor changes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50297|0 |1 is obsolete| | --- Comment #29 from Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> --- Created attachment 60570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60570&action=ed… Bug 13287: QA Follow up Added missing upgrade SQL system preference. Corrected system preference screen message Fixes on purge_suggestions.pl - perlcritic friendlier - address $PERL5LIB comment by using $PROGRAM_NAME (comment #10) - used STDERR (comment #10) - perltidy TEST PLAN --------- $ ./installer/data/mysql/updatedatabase.pl -- should run upgrade and generate new systempreference in table $ ./misc/cronjobs/purge_suggestions.pl --help -- should give help with a real path used instead of $PERL5LIB. $ ./misc/cronjobs/purge_suggestions.pl -days -1 -- should give error message as expected $ ./misc/cronjobs/purge_suggestions.pl -days 0 -- should give error message as expected Go to OPAC system preferences tab and check the PurgeSuggestionsOlderThan system preference -- message should be as expected (see comment #9) run koha qa test tools -- all should pass Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50296|0 |1 is obsolete| | --- Comment #28 from Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> --- Created attachment 60569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60569&action=ed… Bug13287 - Add a system preference to define the number of days used in purge_suggestions.pl The system preferences value is used whenever purge_suggestions.pl is called without the 'days' parameter. This patch uses the preference description suggested by comment #9. This version should now be cleanly applicable. I Apply the patch II Run updatedatabase.pl a) Run purge_suggestions.pl without the days parameter - validate that there is an error message b) Run purge_suggestions.pl with the days parameter - validate that there is no error message c) Insert a number of days in the system variable PurgeSuggestionsOlderThan d) Run purge_suggestions.pl without the days parameter - validate that there is no error message Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> Tested per plan, all tests pass. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Mehdi Hamidi <mehdi.hamidi(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12966] Edition statement missing from card view in Z39.50 result list ( acq+cataloguing)
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12966 --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I've set it to 'obsolete': Details > Edit details > obsolete checkbox -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12966] Edition statement missing from card view in Z39.50 result list ( acq+cataloguing)
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12966 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60565|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12966] Edition statement missing from card view in Z39.50 result list ( acq+cataloguing)
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12966 --- Comment #2 from Pongtawat <pongtawat(a)punsarn.asia> --- I'm sorry, my attachment go to the wrong bug. I can't find a way to remove it :( -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3116] ISBD parsing does not preserve subfield order
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3116 --- Comment #4 from Pongtawat <pongtawat(a)punsarn.asia> --- Created attachment 60566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60566&action=ed… Add option 'all' to ISBD template -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12966] Edition statement missing from card view in Z39.50 result list ( acq+cataloguing)
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '17

22 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12966 Pongtawat <pongtawat(a)punsarn.asia> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pongtawat(a)punsarn.asia --- Comment #1 from Pongtawat <pongtawat(a)punsarn.asia> --- Created attachment 60565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60565&action=ed… Add option 'all' to ISBD template -- You are receiving this mail because: You are watching all bug changes.

1 0