February 2017 - Koha-bugs - lists.koha-community.org

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #73 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 59739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59739&action=ed… Bug 13757: (QA followup) Make opac-memberentry.pl handle attrs deletion The original code on this bug skipped empty-valued attributes. But emptying attributes is the only way to tell the controller script that the user wants to delete them. This patch makes opac-memberentry.pl check the existence of attributes sharing the code of the empty for the given patron, and it stores the deletion on the Koha::Patron::Modification as needed. Otherwise deletions got skipped. To test: - Verify setting/deleting attributes that are opac-editable and verify the results are sound. https://bugs.koha-community.org/show_bug.cgi?id=13737 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #72 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 59738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59738&action=ed… Bug 13757: Make Koha::Patron::Modification->store del empty attrs This patch makes Koha::Patron::Modification->store delete the passed attributes that contain empty values. This is the way it currently works, as all opac-editable attributes are presented to the end-user and they are allowed to delete them, and the best way I found to represent the deletion on the modification request is by setting it to the empty string. I chose this way because it is how the staff interface handles it, so it is consistent. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: This time tests pass! - Verify comment #70 on the bug is fixed now - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> https://bugs.koha-community.org/show_bug.cgi?id=13737 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #71 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 59737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59737&action=ed… Bug 13757: (regression tests) Empty attributes should delete existing This patch introduces tests for the required functionality. To test: - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => FAIL: The current code doesn't work like that Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> https://bugs.koha-community.org/show_bug.cgi?id=13737 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8840] ubuntu-pkg-check.sh fix and extend functionality
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 [Bug 18028] install_dir/*.packages are outdated and must be removed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17626] New: INSTALL files are outdated
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17626 Bug ID: 17626 Summary: INSTALL files are outdated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Developer documentation Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Since we are pretty bad to maintain INSTALL files, I'd suggest to point to the wiki. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #46 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 59726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59726&action=ed… [SIGNED-OFF] Bug 15030: Add tests This test will prevent regression on the lost of data when items.itemcallnumber is linked with a plugin. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #45 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 59725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59725&action=ed… [SIGNED-OFF] Bug 15030 - continue. The enumchron value was overwritten by 'header' even when value supplied Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #44 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 59724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59724&action=ed… [SIGNED-OFF] Bug 15030 - Fixes the serials fields associated with a plugin, to not overwrite the previously saved value This fixes the remaining fields from serials-edit.pl that were seeing their previously entered values be oblitarated with each new edit. The fields associated to a plugin (dateaccessioned and barcode) were always displaying <empty> with each new edit, losing the previous effort. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59671|0 |1 is obsolete| | Attachment #59672|0 |1 is obsolete| | Attachment #59673|0 |1 is obsolete| | Attachment #59674|0 |1 is obsolete| | --- Comment #43 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 59723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59723&action=ed… [SIGNED-OFF] Bug 15030 - Certain values in serials' items are lost on next edit When editing serials subscription, we can edit them but some values are not pulled from the DB correctly to be put in the edit box. If not noticed, the value will be overwritten on the next save. Test: - Create a subscription - Edit itemcallnumber (952o?) and make sure to have a different value than the default one. - Save. - Edit it again - The saved value is not there. This is true for itemcallnumber and a few other fields. This was caused by calls to ->field($subfield). This would always fail, of course. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0