February 2017 - Koha-bugs - lists.koha-community.org

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #55 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59780&action=ed… Bug 14224: Check if the columns do not exist before creating them Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59761|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59779&action=ed… Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14764] Add OPAC News branch selector
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Liz: Is this: if (defined $input->param('branch') and length $input->param('branch')) { $homebranch = $input->param('branch'); } if (C4::Context->userenv and defined $input->param('branch') and length $input->param('branch') == 0 ){ $homebranch = ""; } could actually be: if (defined $input->param('branch') and length $input->param('branch')) { $homebranch = $input->param('branch'); } elsif (C4::Context->userenv and defined $input->param('branch') ) { $homebranch = ""; } ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18032] New: make test fail 'DBIx::Class::Storage::DBI'
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18032 Bug ID: 18032 Summary: make test fail 'DBIx::Class::Storage::DBI' Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs(a)lists.koha-community.org Reporter: jane.chang(a)cwts.edu QA Contact: testopia(a)bugs.koha-community.org root@debian-w01:/home/kohasysusr/Downloads/koha-16.05.09# make test PERL_DL_NONLAZY=1 KOHA_CONF=blib/KOHA_CONF_DIR/koha-conf.xml "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/PERL_MODULE_DIR', 'blib/arch')" t/*.t t/00-checkdatabase-version.t ........ ok t/00-deprecated.t ................... ok t/00-load.t ......................... 1/? DBIx::Class::ResultSet::find(): Your storage class (DBIx::Class::Storage::DBI) does not set sql_limit_dialect and you have not supplied an explicit limit_dialect in your connection_info. DBIC will attempt to use the GenericSubQ dialect, which works on most databases but can be (and often is) painfully slow. Please file an RT ticket against 'DBIx::Class::Storage::DBI' . at /home/kohasysusr/Downloads/koha-16.05.09/blib/PERL_MODULE_DIR/Koha/Objects.pm line 83 t/00-load.t ......................... 196/? # Failed test 'use Koha::Token;' # at t/00-load.t line 64. # Tried to use 'Koha::Token'. # Error: Can't locate WWW/CSRF.pm in @INC (@INC contains: /home/kohasysusr/Downloads/koha-16.05.09/blib/PERL_MODULE_DIR /home/kohasysusr/Downloads/koha-16.05.09/blib/arch /usr/share/koha/lib /usr/share/koha/lib /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl . /var/lib/koha/plugins /var/lib/koha/plugins) at /home/kohasysusr/Downloads/koha-16.05.09/blib/PERL_MODULE_DIR/Koha/Token.pm line 53. # BEGIN failed--compilation aborted at /home/kohasysusr/Downloads/koha-16.05.09/blib/PERL_MODULE_DIR/Koha/Token.pm line 53. # Compilation failed in require at t/00-load.t line 64. # BEGIN failed--compilation aborted at t/00-load.t line 64. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Token' FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Token' make: *** [test_dynamic] Error 255 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 14405] Add datatable to fines table in OPAC patron account
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard(a)myacpl.org |aleishaamohia(a)hotmail.com Change sponsored?|--- |Sponsored CC| |aleishaamohia(a)hotmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14405] Add datatable to fines table in OPAC patron account
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405 --- Comment #1 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 59764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59764&action=ed… Bug 14405: Add datatables to fines table in OPAC To test: 1) Apply patch 2) Go to OPAC -> Your account 3) Confirm you can now sort on all columns Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14405] Add datatable to fines table in OPAC patron account
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #53 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- (In reply to Jonathan Druart from comment #50) > (In reply to Jonathan Druart from comment #41) > > Aleisha, it seems that your last patch kept the 2 subroutines in C4::Items. > > Since you are not using them, you can remove them. > > Note that this is still valid, C4::Circulation::GetItemIssues is readded by > your patch whereas it has been removed by bug 17679. Fixed in the latest patch. (In reply to Katrin Fischer from comment #51) > (In reply to Jonathan Druart from comment #50) > > I'd like to get feedbacks about these few questions: > > 1. Maybe the pref AllowIssueNotes should be renamed AllowCheckoutNotes? > > I think the initial devs might not have been aware of our terminology: > https://wiki.koha-community.org/wiki/Terminology > Could we fix this later on in a separate patch later on? This has been > taking a long time already. I agree with Katrin - any other additional comments about language etc. can be fixed once this has passed, but would really like to get this through. Reattached patch removes the GetItemIssues from the patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59641|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 59761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59761&action=ed… Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14536] PageObject-pattern base implementation
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia(a)hotmail.com --- Comment #23 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Please provide a test plan so someone can test this. -- You are receiving this mail because: You are watching all bug changes.

1 0