February 2017 - Koha-bugs - lists.koha-community.org

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59641|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 59761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59761&action=ed… Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14536] PageObject-pattern base implementation
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '17

02 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia(a)hotmail.com --- Comment #23 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Please provide a test plan so someone can test this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #51 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jonathan Druart from comment #50) > I'd like to get feedbacks about these few questions: > 1. Maybe the pref AllowIssueNotes should be renamed AllowCheckoutNotes? I think the initial devs might not have been aware of our terminology: https://wiki.koha-community.org/wiki/Terminology Could we fix this later on in a separate patch later on? This has been taking a long time already. > 2. Does everybody think that "PATRON_NOTE" template code is meaningful > enough? Don't have a better idea right now - it matches how it's called in the GUI. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #67 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Blou from comment #65) > Josef, > I'd be happy to have someone in our team test and sign this, but right now I > get a > Applying: Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug > 15451) > fatal: sha1 information is lacking or useless (C4/Acquisition.pm). > > Damn sha1... > Making one big patch out of it would probably limit future rebases, btw, > since a lot of these do-undo-redo the same code... > > Reminder for the initial work: > > **** > Sponsored by : CCSR > **** I squashed the patches. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58985|0 |1 is obsolete| | Attachment #58986|0 |1 is obsolete| | Attachment #58987|0 |1 is obsolete| | Attachment #58988|0 |1 is obsolete| | Attachment #58989|0 |1 is obsolete| | Attachment #58990|0 |1 is obsolete| | Attachment #58991|0 |1 is obsolete| | Attachment #58992|0 |1 is obsolete| | --- Comment #66 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 59757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59757&action=ed… Bug 8612: Use CSV profile for exporting basket This patch allows the user to use a CSV export profile to create the fields to export the basket as CSV in a basket page. Test plan: 1) Apply the patch 2) Go to Tools › CSV export profiles and create a profile of type "SQL for basket export in acquisition" example: biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno 3) In acquisition module, create a new basket and add an order to the basket 4) On basket detail page, there should be the split button labelled "Export to CSV" 5) Try to use the button and export CSV with your CSV profile you defined in step 2 6) Validate the CSV file. 7) Repeat 4-6 with a closed basket. a) close the basket b) View the basket c) validate that there is an export button d) test it with an export 8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t t/db_dependent/Koha/CsvProfiles.t Initial work: Sponsored by: CCSR Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Barton Chittenden <barton(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #2 from Barton Chittenden <barton(a)bywatersolutions.com> --- I believe that this may also cause fragmenting of CHECKOUT, RENEWAL and CHECKIN messages. These are digest messages, which should accumulate detail about their respective circ action in message_queue.metadata until process_message_queue.pl runs. We have seen evidence of multiple RENEWAL messages going out in very short order... it would be normal for process_message_queue.pl to be running while items are being checked in our out, causing two messages to be sent, but we have had evidence of 3 messages sent at the same time, which isn't possible unless the message_queue is being processed by two separate instances of process_message_queue.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #75 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Another one: 1/ Set an attr as displayed at the OPAC but not editable 2/ At the OPAC, fill the edit patron form but miss a mandatory field, submit 3/ You get the form again but the attr is not displayed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #74 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I do not know if it comes from the last patches but I found something else. if I do not make any changes to the editable attrs, they will appear as modified anyway (entry in borrower_modifications). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13737] [OMNIBUS] Add Koha RESTful Services
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59687|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13737] [OMNIBUS] Add Koha RESTful Services
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '17

01 Feb '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0