March 2017 - Koha-bugs - lists.koha-community.org

[Bug 17083] New: Remove more event attributes from tools templates
by bugzilla-daemon＠bugs.koha-community.org 11 May '17

11 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Bug ID: 17083 Summary: Remove more event attributes from tools templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org This patch will remove event attributes from some tools-related templates: labels/label-edit-layout.tt tools/cleanborrowers.tt tools/inventory.tt tools/letter.tt tools/upload.tt -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 17847] New: Move C4::Koha::GetAuthvalueDropbox to Koha:: AuthorisedValues
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Bug ID: 17847 Summary: Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 17781] New: Improper branchcode set during renewal
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Bug ID: 17781 Summary: Improper branchcode set during renewal Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com For no discernable reason, when AddIssue calls AddRenewal, it passes the branchcode generated from _GetCircControlBranch. Assume _GetCircControlBranch is set to return items.homebranch. So: 1) If an item owned by LibraryA is checked out at LibraryB, the statistic line branchcode will be LibraryB 2) If an item is renewed via the ajax datatables renewal function, the statistic line branchcode will be LibraryB 3) If an item is renewed via scanning the item into the checkout again, the statistic line branchcode will be *LibraryA* This is clearly improper behavior. The renewal is taking place at LibraryB, so the branchcode passed to AddRenewal should be LibraryB, the logged in library. This also jives with the documentation for the subroutine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 18335] New: Check in: Make patron info in hold messages obey syspref AddressFormat
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18335 Bug ID: 18335 Summary: Check in: Make patron info in hold messages obey syspref AddressFormat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When checking in, information about patrons with a hold always display in an US style. Address information should opey the system preference AddressFormat To reproduce: - Set syspref AddressFormat to German style - Check out an item to a patron A - Put a hold on this item for patron B - Check in item using the Check in field in page header - Result: In message 'Hold found', address does not display in German style -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 17911] New: Message and timeout mismatch
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17911 Bug ID: 17911 Summary: Message and timeout mismatch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Step 3 in the installer says "If this page does not redirect in 5 seconds..." but the actual number is 10 seconds (see the second line with the meta refresh content says 10). Solution: fix the meta refresh, because changing the message could be a translation mess. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 17821] New: due date in intranet search results should use TT date plugin
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Bug ID: 17821 Summary: due date in intranet search results should use TT date plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Intranet search results displays due date from item onloan. This should use the TT date plugin. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 18015] New: On shelf holds allowed > "If all unavailable" ignores notforloan
by bugzilla-daemon＠bugs.koha-community.org 05 May '17

05 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Bug ID: 18015 Summary: On shelf holds allowed > "If all unavailable" ignores notforloan Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", items with status "Not for loan" are considered available and break the functionality. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 18162] New: Don't translate JSON keys
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18162 Bug ID: 18162 Summary: Don't translate JSON keys Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org Symptoms: When Swedish or Norwegian was selected as the interface language in the staff client, patron searches that were only returning a single result would redirect to /cgi-bin/koha/members/moremember.pl?borrowernumber=undefined, which of course gives the message "This patron does not exist. Find another patron?" Cause: In koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt we have this: 34 "dt_action": 35 "<a href='/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=[% data.borrowernumber %]' class='btn btn-default btn-xs'> Edit</a>", 36 "borrowernumber": 37 "[% data.borrowernumber %]" 38 }[% UNLESS loop.last %],[% END %] borrowernumber here is meant to be a key in some JSON data, but it had been translated, which means the JS in koha-tmpl/intranet-tmpl/prog/nb-NO/modules/members/member.tt that redirects when there is only one result could not find the borrowernumnber: 196 // redirect if there is only 1 result. 197 if ( json.aaData.length == 1 ) { 198 var borrowernumber = json.aaData[0].borrowernumber; 199 document.location.href="/cgi-bin/koha/members/moremember.pl?borrowernumber="+borrowernumber; 200 return false; 201 } In Pootle, the string that had been translated looks like this: ", "borrowernumber": "%s" }%s,%s %s ] } %s %s %s%s%s %s%s%s %s%s%s %s %s Quick fix: Find the relevant string in *-staff-prog.po and untranslate it. Permanent fix: Is there some way to mark a string so it does not get picked up for translation? If not, perhaps it would make sense to rename borrowernumber here to something that is more obviously not meant to be translated? Why are the other keys in the JSON prefixed with dt_? Is there some special magic to it, or could we do the same for borrowernumber? Thanks to oha on #koha for nudging me in the right direction to figure this out. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 18358] New: koha item-status.inc variable name
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18358 Bug ID: 18358 Summary: koha item-status.inc variable name Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: long_sam.tw(a)yahoo.com.tw QA Contact: testopia(a)bugs.koha-community.org http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tm… I found the item.itemnotforloan variable, but opac-course-details.tt has used this codes. 54 [% IF ( item.itemnotforloan ) %] 55 [% SET itemavailable = 0 %] 56 [% IF ( item.notforloanvalueopac ) %] 57 [% item.notforloanvalueopac %] [% IF ( item.restrictedopac ) %]([% item.restrictedopac %])[% END %] 58 [% ELSE %] 59 Not for loan [% IF ( item.restrictedopac ) %]([% item.restrictedopac %])[% END %] 60 [% END %] 61 [% ELSIF ( item.notforloan_per_itemtype ) %] 62 [% SET itemavailable = 0 %] 63 Not for loan [% IF ( item.restrictedopac ) %]([% item.restrictedopac %])[% END %] 64 [% END %] opac-course-details.tt line 76 76 <td>[% INCLUDE 'item-status.inc' item=cr.item issue=cr.issue %]</td> 77 <td>[% cr.issue.date_due | $KohaDates as_due_date => 1 %]</td> 78 <td>[% IF ( cr.public_note ) %] Dump opac-course-details.pl codes. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=opac/opac-course-… 47 my $course_reserves = GetCourseReserves( course_id => $course_id, include_items => 1, include_count => 1 ); $course_reserves has no item.itemnotforloan variables, but has item.notforloan variables. course_reserves -------------------- $VAR1 = [ { 'itemnumber' => '19349', 'course_item' => { 'itemnumber' => '19349', 'ccode' => undef, 'location' => undef, 'ci_id' => '18', 'course_reserves' => [ { 'timestamp' => '2017-02-22 17:16:50', 'ci_id' => '18', 'staff_note' => '', 'course_id' => '7', 'cr_id' => '18', 'public_note' => '' } ], 'holdingbranch' => undef, 'timestamp' => '2017-02-23 11:11:33', 'itype' => 'BOOKC', 'enabled' => 'yes' }, 'ci_id' => '18', 'item' => { 'withdrawn' => '0', 'coded_location_qualifier' => undef, 'marc' => '00501nam a2200157Ia 4500003000600000005001700006008004000023040000800063100006800071245009700139250000800236260004900244700001800293942001700311999001500328AOGST20161028172127.0141108s1986 ch e 000 chi d aaog1 a賀西納 Harold Vinson Synan 著/魏玉琴譯c(Vinson Synan)10a靈恩運動 c賀西納 (Vinson Synan)著 ; 魏玉琴譯b美國聖潔及五旬節運動史 a初 b教會更新研究發展中心c1986a台北1 aSynanbVinson 2AOGSTcBOOKC c6589d6589', 'url' => undef, 'isbn' => undef, 'copyrightdate' => '1986', 'itemnumber' => '19349', 'ccode' => undef, 'serial' => undef, 'cn_suffix' => undef, 'barcode' => 'B1010102217', 'cn_item' => undef, 'uri' => undef, 'marcxml' => "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <record xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd\" xmlns=\"http://www.loc.gov/MARC21/slim\"> <leader>00501nam a2200157Ia 4500</leader> <controlfield tag=\"003\">AOGST</controlfield> <controlfield tag=\"005\">20161028172127.0</controlfield> <controlfield tag=\"008\">141108s1986 ch e 000 chi d</controlfield> <datafield tag=\"040\" ind1=\" \" ind2=\" \"> <subfield code=\"a\">aog</subfield> </datafield> <datafield tag=\"100\" ind1=\"1\" ind2=\" \"> <subfield code=\"a\">\x{8cc0}\x{897f}\x{7d0d} Harold Vinson Synan \x{8457}/\x{9b4f}\x{7389}\x{7434} \x{8b6f}</subfield> <subfield code=\"c\">(Vinson Synan)</subfield> </datafield> <datafield tag=\"245\" ind1=\"1\" ind2=\"0\"> <subfield code=\"a\">\x{9748}\x{6069}\x{904b}\x{52d5} </subfield> <subfield code=\"c\">\x{8cc0}\x{897f}\x{7d0d} (Vinson Synan)\x{8457} ; \x{9b4f}\x{7389}\x{7434}\x{8b6f}</subfield> <subfield code=\"b\">\x{7f8e}\x{570b}\x{8056}\x{6f54}\x{53ca}\x{4e94}\x{65ec}\x{7bc0}\x{904b}\x{52d5}\x{53f2}</subfield> </datafield> <datafield tag=\"250\" ind1=\" \" ind2=\" \"> <subfield code=\"a\">\x{521d}</subfield> </datafield> <datafield tag=\"260\" ind1=\" \" ind2=\" \"> <subfield code=\"b\">\x{6559}\x{6703}\x{66f4}\x{65b0}\x{7814}\x{7a76}\x{767c}\x{5c55}\x{4e2d}\x{5fc3}</subfield> <subfield code=\"c\">1986</subfield> <subfield code=\"a\">\x{53f0}\x{5317}</subfield> </datafield> <datafield tag=\"700\" ind1=\"1\" ind2=\" \"> <subfield code=\"a\">Synan</subfield> <subfield code=\"b\">Vinson</subfield> </datafield> <datafield tag=\"942\" ind1=\" \" ind2=\" \"> <subfield code=\"2\">AOGST</subfield> <subfield code=\"c\">BOOKC</subfield> </datafield> <datafield tag=\"999\" ind1=\" \" ind2=\" \"> <subfield code=\"c\">6589</subfield> <subfield code=\"d\">6589</subfield> </datafield> </record> ", 'materials' => undef, 'datelastseen' => '2017-02-21', 'cn_class' => undef, 'title' => "\x{9748}\x{6069}\x{904b}\x{52d5} ", 'pages' => undef, 'withdrawn_on' => undef, 'number' => undef, 'itemtype' => 'BOOKC', 'totalissues' => undef, 'author' => "\x{8cc0}\x{897f}\x{7d0d} Harold Vinson Synan \x{8457}/\x{9b4f}\x{7389}\x{7434} \x{8b6f}", 'size' => undef, 'replacementprice' => undef, 'seriestitle' => undef, 'booksellerid' => undef, 'timestamp' => '2016-10-28 17:21:27', 'new_status' => undef, 'editionstatement' => "\x{521d}", 'stocknumber' => undef, 'publishercode' => "\x{6559}\x{6703}\x{66f4}\x{65b0}\x{7814}\x{7a76}\x{767c}\x{5c55}\x{4e2d}\x{5fc3}", 'collectionvolume' => undef, 'datecreated' => '2014-11-08', 'reserves' => undef, 'editionresponsibility' => undef, 'itemnotes_nonpublic' => undef, 'enumchron' => undef, 'dateaccessioned' => '2016-10-28', 'notes' => undef, 'permanent_location' => undef, 'volumedate' => undef, 'itype' => 'CRC', 'onloan' => undef, 'illus' => undef, 'ean' => undef, 'biblioitemnumber' => '6589', 'restricted' => undef, 'agerestriction' => undef, 'itemlost_on' => undef, 'notforloan' => '1', 'replacementpricedate' => '2016-10-28', 'itemnotes' => undef, 'itemcallnumber' => '231.21 8349', 'location' => undef, 'stack' => undef, 'itemlost' => '0', 'collectionissn' => undef, 'price' => undef, 'abstract' => undef, 'collectiontitle' => undef, 'publicationyear' => undef, 'issues' => '1', 'place' => "\x{53f0}\x{5317}", 'homebranch' => 'AOGST', 'issn' => undef, 'cn_source' => 'AOGST', 'more_subfields_xml' => undef, 'holdingbranch' => 'AOGST', 'renewals' => undef, 'biblionumber' => '6589', 'damaged' => '0', 'unititle' => undef, 'cn_sort' => '', 'lccn' => undef, 'volume' => undef, 'frameworkcode' => 'M21', 'datelastborrowed' => '2017-02-06', 'volumedesc' => undef, 'copynumber' => 'c.2', 'paidfor' => undef }, 'issue' => undef, 'public_note' => '', 'reserves_count' => '1', 'timestamp' => '2017-02-22 17:16:50', 'staff_note' => '', 'course_id' => '7', 'cr_id' => '18' }, -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 18291] New: Remove SQL from preferences.pl administrative script
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291 Bug ID: 18291 Summary: Remove SQL from preferences.pl administrative script Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: alexbuckley(a)catalyst.net.nz Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org This bug report requires the removal of SQL code from the preferences.pl administrative script into a separate perl module. It also requires the creation of unit tests and POD for the new subroutines in the perl modules. -- You are receiving this mail because: You are watching all bug changes.

1 22