March 2017 - Koha-bugs - lists.koha-community.org

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes(a)biblibre.com Status|Needs Signoff |Signed Off --- Comment #37 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6172] Non-French UNIMARC frameworks need to be updated
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha(a)univ-lyon3.fr See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18309 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #56 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- New sub days_foward: Please add a unit test for this routine. In Calendar.t? Or Holidays.t? Also note that the while loop is very dangerous if you would pass a negative number (infinite loop). Please check the value of the days. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #55 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- About the atomic update (db revision): You add the pref, but we should also take into account all waiting reserves now and look at/calculate their expiration date. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #54 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Also please look here in circ/waitingreserves.pl ( $waiting_year, $waiting_month, $waiting_day ) = Add_Delta_Days( $waiting_year, $waiting_month, $waiting_day, $max_pickup_delay); my $calcDate = Date_to_Days( $waiting_year, $waiting_month, $waiting_day ); This date is compared with today and holds may be cancelled. We should use the new expirationdate here too. An interesting aspect is this one too in the same script: $max_pickup_delay-- if C4::Context->preference('ExpireReservesMaxPickUpDelay'); This is kind of strange btw. You should either use the delay or not use it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #53 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Please look at this code in C4/Letters.pm: if ( $table eq 'reserves' && $values->{'waitingdate'} ) { my @waitingdate = split /-/, $values->{'waitingdate'}; $values->{'expirationdate'} = ''; if ( C4::Context->preference('ReservesMaxPickUpDelay') ) { my $dt = dt_from_string(); $dt->add( days => C4::Context->preference('ReservesMaxPickUpDelay') ); $values->{'expirationdate'} = output_pref( { dt => $dt, dateonly => 1 } ); } This code should be adjusted too in line with the changes in $hold->set_waiting. Actually, if there is a waiting date, we must assume now that it is no longer needed to calculate an expiration date. In the above code the holiday was not respected either. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #52 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Well, holds patches are not simple at least. Submitting a few comments collected so far. Do not give up. We are improving on the way. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #116 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Séverine Queune from comment #115) > Personnaly, I think it's very useful but will use it when pushed in master > only on a test instance. Yes of course, that's how it must be used. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10858] Browse selected biblios
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Eric <eric.gosselin.5(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |eric.gosselin.5(a)gmail.com --- Comment #102 from Eric <eric.gosselin.5(a)gmail.com> --- Doesn't apply in the sandboxes. Could you rebase it? Thank you -- You are receiving this mail because: You are watching all bug changes.

1 0