March 2017 - Koha-bugs - lists.koha-community.org

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #55 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- About the atomic update (db revision): You add the pref, but we should also take into account all waiting reserves now and look at/calculate their expiration date. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #54 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Also please look here in circ/waitingreserves.pl ( $waiting_year, $waiting_month, $waiting_day ) = Add_Delta_Days( $waiting_year, $waiting_month, $waiting_day, $max_pickup_delay); my $calcDate = Date_to_Days( $waiting_year, $waiting_month, $waiting_day ); This date is compared with today and holds may be cancelled. We should use the new expirationdate here too. An interesting aspect is this one too in the same script: $max_pickup_delay-- if C4::Context->preference('ExpireReservesMaxPickUpDelay'); This is kind of strange btw. You should either use the delay or not use it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #53 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Please look at this code in C4/Letters.pm: if ( $table eq 'reserves' && $values->{'waitingdate'} ) { my @waitingdate = split /-/, $values->{'waitingdate'}; $values->{'expirationdate'} = ''; if ( C4::Context->preference('ReservesMaxPickUpDelay') ) { my $dt = dt_from_string(); $dt->add( days => C4::Context->preference('ReservesMaxPickUpDelay') ); $values->{'expirationdate'} = output_pref( { dt => $dt, dateonly => 1 } ); } This code should be adjusted too in line with the changes in $hold->set_waiting. Actually, if there is a waiting date, we must assume now that it is no longer needed to calculate an expiration date. In the above code the holiday was not respected either. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #52 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Well, holds patches are not simple at least. Submitting a few comments collected so far. Do not give up. We are improving on the way. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #116 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Séverine Queune from comment #115) > Personnaly, I think it's very useful but will use it when pushed in master > only on a test instance. Yes of course, that's how it must be used. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10858] Browse selected biblios
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Eric <eric.gosselin.5(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |eric.gosselin.5(a)gmail.com --- Comment #102 from Eric <eric.gosselin.5(a)gmail.com> --- Doesn't apply in the sandboxes. Could you rebase it? Thank you -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13913] Renewal error message in OPAC is confusing
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila(a)ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61534|0 |1 is obsolete| | --- Comment #36 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 61539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61539&action=ed… Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Rabased on master Rebased on master (2016-06-23) Rebased on master (2017-03-23) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #51 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: [1] We now assume that the max suspension days should be applied on the individual suspension, not on the accumulation. Is that a logical choice? No blocker, just mentioning it. [2] The unit test does not return the case where you would return first the 10 day book and then the 5 day book. This might be interesting to add since formerly the second return would not make a difference. Note: I tested this case in the interface and it works. -- You are receiving this mail because: You are watching all bug changes.

1 0