March 2017 - Koha-bugs - lists.koha-community.org

[Bug 10357] Send email when serial received subscription link is hard to find
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10357] Send email when serial received subscription link is hard to find
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes(a)biblibre.com --- Comment #3 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10357] Send email when serial received subscription link is hard to find
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr Status|Needs Signoff |Signed Off --- Comment #2 from Séverine Queune <severine.queune(a)bulac.fr> --- The subscribe link now appears on the "Subscription" tab. It works the same way (confirmation, button to unsuscribe). However, as mail are not send when working on sandbox, I didn't check the notice is correcly send to the patron when receiving a new issue ; there is no "standing" mail on the "Notice" tab on the patron account. Thanks for this very useful patch ! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- + # FIXME Is it right? I'd have expected 5 * 2 - 1 instead + # Same for the others + my $expected_expiration = output_pref( + { + dt => dt_from_string->add( days => ( 5 - 1 ) * 2 ), If I look to the code: my $grace = DateTime::Duration->new( $unit => $issuing_rule->firstremind ); my $deltadays = DateTime::Duration->new( days => $chargeable_units ); if ( $deltadays->subtract($grace)->is_positive() ) { my $suspension_days = $deltadays * $finedays; Then I would expect indeed (5-1)*2. Why would you expect 5*2-1 ? First you do deltadays - grace (=1) and then you multiply with finedays (2) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan(a)bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the 17.05 Release. Thanks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 --- Comment #15 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Still looking here btw -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- I do not see a signoff on those patches? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #66 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Code looks good to me. This smaller change has mostly been code reviewed by me. I tested some constructs on itself, but I do not have a shibboleth server. Since most QAers do not and it has been tested by Martin and Mirko, I take the liberty to pass QA on it now. But not without a few remarks :) Koha::Database->new()->schema()->resultset('Borrower') ->find( { $config->{matchpoint} => $match } ); Strictly speaking, you should use find with primary keys/unique constraints. It might fallback to search here depending on your matchpoint (userid has a unique constraint). =head2 _autocreate my ( $retval, $retcard, $retuserid ) = _autocreate( $config, $match ); Given a database handle [...] => Where is that database handle? It got removed after the second patch.. Fixed in a followup. checkpw_shib The change to this routine should normally be accompanied by changes in the tests. Perhaps you should add autocreate => 0 explicitly to mockedConfig in this test. I wonder if testing autocreate => 1 should be done better in a db_dependent test. Since this patch goes such a long way, I do not want to block it now. But please add a small test on a new report. Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '17

23 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #65 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61527&action=ed… Bug 12026: [QA Follow-up] Fix a POD line Still refers to a removed parameter of _autocreate. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0