April 2017 - Koha-bugs - lists.koha-community.org

[Bug 18356] New: Prediction pattern wrong, skips years, for some year based frequencies
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Bug ID: 18356 Summary: Prediction pattern wrong, skips years, for some year based frequencies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com To reproduce: Set a frequency with: Unit: Year Issues per unit: 9 Units per issue: 1 OR Unit: Year Issues per unit: 12 Units per issue: 1 Notice the prediction pattern works for about 1 cycle, then crossed to next year, then jumps a year: No. 82 03/01/2017 No. 83 03/31/2017 No. 84 04/30/2017 No. 85 05/30/2017 No. 86 06/29/2017 No. 87 07/29/2017 No. 88 08/28/2017 No. 89 09/27/2017 No. 90 10/27/2017 No. 91 11/26/2017 No. 92 12/26/2017 No. 93 01/25/2018 No. 94 03/01/2019 WRONG!! No. 95 03/31/2019 No. 96 04/30/2019 No. 97 05/30/2019 No. 98 06/29/2019 No. 99 07/29/2019 No. 100 08/28/2019 No. 101 09/27/2019 No. 102 10/27/2019 No. 103 11/26/2019 No. 104 12/26/2019 No. 105 01/25/2020 No. 106 03/01/2021 WRONG!! Seems to be a problem in some cases when we call: ($year) = Add_Delta_YM($year,$month,$day, $freqdata->{"unitsperissue"},0); As this call will always add a year, it ends up in: /usr/share/perl5/Date/Calc/PP.pm sub DateCalc_add_year_month Where we add $year + $freqdata->{"unitsperissue"} and return 1 if it is greater than 1 Suspecting the pass of $freqdata->{"unitsperissue"} is incorrect -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 17181] New: Patron card creator replaces existing image when uploading image with same name
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Bug ID: 17181 Summary: Patron card creator replaces existing image when uploading image with same name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org If you try to upload an image into Patron Card Creator with the same file name as an image that has already been upload, the original image gets replaced, without any warning. There should be some kind of warning before replacing, i.e. "The name "filename" already exists. Upload and replace image or cancel upload?" -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 17710] New: C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 Bug ID: 17710 Summary: C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch should use same logic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org C4::Matcher::get_matches sorts its rows in descending order using score, while C4::ImportBatch::GetBestRecordMatch sorts its rows in descending order using score and record id. To get the best record match, C4::ImportBatch::GetBestRecordMatch takes the top result. By contrast, C4::Matcher::get_matches could easily return different rows in the top position if there are multiple rows with the same score, since its array is populated using a hash where order doesn't matter. It's an easy enough fix, although I will admit to finding the solution on StackOverflow: "Since <=> and cmp return 0 to indicate equality, and that's false, and because Perl's logical Boolean operators return the deciding value instead of just 0 or 1, sorting by multiple keys is as easy as stringing multiple comparisons together with or or ||" http://stackoverflow.com/questions/10395383/sorting-an-array-of-hash-by-mul… -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 17974] New: Add the Koha::Item->biblio method
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 Bug ID: 17974 Summary: Add the Koha::Item->biblio method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 18482] New: False duplicates detected on adding a batch from a stage file
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Bug ID: 18482 Summary: False duplicates detected on adding a batch from a stage file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)univ-lyon3.fr QA Contact: testopia(a)bugs.koha-community.org Created attachment 62572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62572&action=ed… False duplicates detected on adding a batch from a stage file When adding a batch from a stage file with defaut matching on title/author, if a duplicate is detected, all following records treated in the batch are discarded from import even if they are not duplicates. Checking for duplicate now lies on duplinbatch value that is not reset at each loop (In the initial commit, discarding record was directly tight to FindDuplicate return). So from the point when duplinbatch is defined, all the following biblios are discarded as duplicate whatever FindDuplicate return is. This patch adds a distinct flag. Test plan : You need the 2 test attached files TestFile1.mrc and TestFile2.elc (TestFile1 includes only the title "Amilec ou La graine d'hommes" that is also included in TestFile2). To save them, right click on bugzilla link and do 'Save target as'. 1) go to “Stage MARC records for import” page, upload TestFile1, select iso 5426 encoding and stage it for Import. 2) Click again 'Stage MARC records' button and do the same for TestFile2.elc 3) Go to acquisitions module, enter a vendor name and create a new basket. 4) From your basket, click 'Add to basket', then in the “Add order to basket window/block” choose 'From a staged file'. 5) Then click ‘Add orders' button on File1. 6) Leave default matching on Title/Author, tick the title, add a location in second tag and fund in third tag and Save. 7) Make sure that the new record is indexed (depending to your indexing system and test platform). 8) Redo step 4 and step 5 this time on TestFile2. 9) Leave default matching on Title/Author, select all titles, add a location in second tag, a fund in third tag and Save. 10) A warning is displayed saying that no records have been imported because they all match an existing record. The “Import all” block is not any more visible. 11) Apply the patch 12) Refresh 'Add orders from' page (File2) and redo step 9 13) You are redirected to the basket page : a warning is displayed to tell you that some duplicates have been found and skipped. There's a link on the warning throughout you can go back to the list of remaining records and treat them individually if necesary. 14) Click the link : you fall upon the only title that is a very duplicate (record of TestFile1). 15) Be happy 16) Sign off Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 18512] New: GetAuthorisedValues.GetByCode Template plguin should return code ( not empty string) if value not found
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Bug ID: 18512 Summary: GetAuthorisedValues.GetByCode Template plguin should return code (not empty string) if value not found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 18204] New: Authority searches are not saved in Search history
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Bug ID: 18204 Summary: Authority searches are not saved in Search history Change sponsored?: --- Product: Koha Version: 16.11 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: leire(a)scanbit.net QA Contact: testopia(a)bugs.koha-community.org When you search an authority in Authority search, this search is not saved in Search history. EnableOpacSearchHistory is enabled Steps to test: 1- Login your account (opac) 2- Search an authority in Authority search 3- Go to Search history -> Authority 4- It says "Your authority search history is empty" Tested on 16.11.04 -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 16295] New: marc_modification_templates permission doesn't allow access to modify template
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Bug ID: 16295 Summary: marc_modification_templates permission doesn't allow access to modify template Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: jzairo(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I have a staff member with permission to manage marc modification templates but they can't use it. They get Error: You do not have permission to access this page. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 17585] New: Add the Koha::Patron->get_account_lines method
by bugzilla-daemon＠bugs.koha-community.org 27 Jul '17

27 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Bug ID: 17585 Summary: Add the Koha::Patron->get_account_lines method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 17936] New: Search bar not aligned on right in small screen sizes
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '17

26 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Bug ID: 17936 Summary: Search bar not aligned on right in small screen sizes Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: Linux Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: kathryn(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Created attachment 59186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59186&action=ed… screen shot of search bar not aligned on rhs When viewing the home page in a mobile-phone sized screen the search is not aligned with the items above and below it on the right hand side. -- You are receiving this mail because: You are watching all bug changes.

1 15