April 2017 - Koha-bugs - lists.koha-community.org

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #38 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 62795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62795&action=ed… [SIGNED OFF] Bug 3311 [Follow-up] Statistical reports should error if row and column aren't selected This patch moves the validation JavaScript from the body of the page to the <head>. The "validated" class is removed from the form so that there is not a conflict between default error handling and the custom validation added to the page. To test, apply the patch and verify that form validation still enforces a selection of both row and column and that the error messages display in the table header. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #37 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 62794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62794&action=ed… Bug 3311: Followup clean up HTML on page. There should be no validator.w3.org validation issues for this page's source. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62658|0 |1 is obsolete| | Attachment #62659|0 |1 is obsolete| | Attachment #62777|0 |1 is obsolete| | --- Comment #36 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 62793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62793&action=ed… Bug 3311: Form validation feedback By using the validated class, make use of jquery form submission validation to inform user of required fields. TEST PLAN --------- 1) run Home -> Reports -> Catalog -> Submit -- no meaningful output and no error messages. 2) apply patch 3) repeat 1 -- meaningful error messages appear. -- headings are in red, indicative of required values. 4) try other combinations of row or column selected/unselected. -- meaningful error messages. 5) run koha qa test tools Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #35 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Jonathan Druart from comment #34) > What about other pages (eg. reports/borrowers_stats.pl, > reports/issues_stats.pl)? > The title of the bug report says "stat reports", I guess we are expecting to > see all of them fixed. *facepalm* You're right. borrower_stats.pl issues_stats.pl The others with Row and Column have default selections. Changing to assigned. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14843] Notifications and messages via REST API
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14843 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 [Bug 18206] REST API: Default exception handling -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14843] Notifications and messages via REST API
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14843 --- Comment #9 from Lari Taskula <lari.taskula(a)jns.fi> --- Still BLOCKED by Bug 7174 but I wanted to attach this heavily rewritten patch if anyone is interested to work with it. It is now dependent on Bug 18137. This patch can work without dependency to Bug 7174, but at least the following steps are required: 1. The atomicupdate script needs to be rewritten to community standards. Get rid of AtomicUpdater and PermissionManager, and those permissions have to be added the way it currently happens in Koha 2. Fix permission adding mechanism in the test file 3. There are probably some conflicts in definitions.json, paths.json and parameters.json, but they should be trivial to fix. I may return later to fix those steps, but if you really want to test this now, feel free to provide a follow-up :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14843] Notifications and messages via REST API
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14843 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42719|0 |1 is obsolete| | --- Comment #8 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 62791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62791&action=ed… Bug 14843: REST API for message queue - /api/v1/notices GET /api/v1/notices POST /api/v1/notices GET /api/v1/notices/{message_id} PUT /api/v1/notices/{message_id} PATCH /api/v1/notices/{message_id} DELETE /api/v1/notices/{message_id} POST /api/v1/notices/{message_id}/resend New permissions: - Module * messages - Sub-permissions * get_message * create_message * update_message * delete_message * resend_message To test: 1. prove t/db_dependent/api/v1/notices.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- ok, let's assume it's the way to go. What about other pages (eg. reports/borrowers_stats.pl, reports/issues_stats.pl)? The title of the bug report says "stat reports", I guess we are expecting to see all of them fixed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #78 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 62779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62779&action=ed… Bug 12461 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60624|0 |1 is obsolete| | --- Comment #77 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 62778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62778&action=ed… Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0