April 2017 - Koha-bugs - lists.koha-community.org

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #78 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 62779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62779&action=ed… Bug 12461 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60624|0 |1 is obsolete| | --- Comment #77 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 62778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62778&action=ed… Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to M. Tompsett from comment #32) > This should meet your standards now, JD. s/your/our I will give it another try today or tomorrow. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #32 from M. Tompsett <mtompset(a)hotmail.com> --- Thanks for the follow up, Owen! Comment #25 is the test plan. This should meet your standards now, JD. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62776|0 |1 is obsolete| | --- Comment #31 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 62777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62777&action=ed… [SIGNED OFF] Bug 3311 [Follow-up] Statistical reports should error if row and column aren't selected This patch moves the validation JavaScript from the body of the page to the <head>. The "validated" class is removed from the form so that there is not a conflict between default error handling and the custom validation added to the page. To test, apply the patch and verify that form validation still enforces a selection of both row and column and that the error messages display in the table header. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #30 from Owen Leonard <oleonard(a)myacpl.org> --- M. Tompsett: The script wasn't working at the top of the page because it was being overridden by the default validation. The position of your JS was fixing that problem by executing later. By removing the "validated" class from the form your JS is able to be responsible for all the validation and still be placed correctly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #29 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 62776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62776&action=ed… Bug 3311 [Follow-up] Statistical reports should error if row and column aren't selected This patch moves the validation JavaScript from the body of the page to the <head>. The "validated" class is removed from the form so that there is not a conflict between default error handling and the custom validation added to the page. To test, apply the patch and verify that form validation still enforces a selection of both row and column and that the error messages display in the table header. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0