April 2017 - Koha-bugs - lists.koha-community.org

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #54 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 62774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62774&action=ed… [SIGNED-OFF] Bug 15165: Set amount parameter required, define its data type and confirm amount > 0 This patch enforces "amount" to be required when paying towards accountline(s). It also specifies the data type of amount, so that nonsense amounts like "strings" cannot go through. Also, defines minimum amount as 0 and exclusiveMinimum true so that the amount must be greater than 0 (and not equal). This patch also wraps the operations in try/catch as now recommended. Possible enhancements to Koha::Account->pay could also be done so that we would catch Koha::Exceptions in the case of invalid input. However, this is probably outside the scope of this bug and would require more testing on other components as well. After all, we can handle the input nicely with Swagger alone. To test: 1. prove t/db_dependent/api/v1/accountlines.t 2. prove t/db_dependent/api/v1/patrons.t Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #53 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 62773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62773&action=ed… [SIGNED-OFF] Bug 15165: Remove meansofpayment parameter Accountlines does not have such column in current master. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #52 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 62772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62772&action=ed… [SIGNED-OFF] Bug 15165: followup - fix definitions, and passing amount parameter in pay method Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #51 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 62771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62771&action=ed… [SIGNED-OFF] Bug 15165 - Add API routes to pay accountlines POST /accountlines/(:accountlines_id)/payment (pay towards accountline) POST /patrons/(:borrowernumber)/payment (pay towards borrower) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You must have permission updatecharges. 2. Create a fine to any patron and get the accountlines_id. 3. Send POST request to http://yourlibrary/api/v1/accountlines/YYY/payment without body where YYY is the accountlines_id you created in step 2. 4. Check that the accountline that you created in step 2 is paid. 5. Create two payments with amount 5.00 (with no other outstanding payments) 6. Send POST request to http://yourlibrary/api/v1/patrons/ZZZ/payment with body {"amount": 10} Replace ZZZ with the borrowernumber for which you have created two fines 7. Check that the two accountlines are paid. 8. Repeat step 2. 9. Send POST request to http://yourlibrary/api/v1/accountlines/YYY/payment with body {"amount": XXX} Replace YYY with the accountlines_id you created in step 8. Set amount (XXX) to the half of the amount of the fine you created in step 8. 10. Check that the fine is still outstanding with half of the original amount. 11. Run unit tests at t/db_dependent/api/v1/accountlines.t and t/db_dependent/api/v1/patrons.t Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #50 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 62770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62770&action=ed… [SIGNED-OFF] Bug 15165 - Add API route to edit accountlines PUT /accountlines/{accountlines_id} (edit) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY where YYY is one of your accountlines_id. See the body definition in definitions/editAccountlineBody.json and use this in your PUT request. 3. Run unit tests in t/db_dependent/api/v1/accountlines.t Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #49 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 62769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62769&action=ed… [SIGNED-OFF] Bug 15165 - Add API route to list accountlines GET /accountlines (list) GET /accountlines?borrowernumber=X (list) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Go to http://yourlibrary/api/v1/accountlines?borrowernumber=XXX (replace XXX with a borrowernumber that has accountlines) and check you receive correct data 3. Go to http://yourlibrary/api/v1/accountlines and check that you receive all accountlines 4. Run unit tests in t/db_dependent/api/v1/accountlines.t Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15140] Add MARC21 776 to OPAC and staff display
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 Felix Hemme <felix.hemme(a)thulb.uni-jena.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Felix Hemme <felix.hemme(a)thulb.uni-jena.de> --- Hi Marcel, linking works fine now. But I think the value from subfield $i (relationship information) should be displayed if second indicator = 8. Like in field 775 (other edition entry). I changed the status to "Failed QA". Please change it again if that was not correct. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #78 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Owen, Sorry for no apply! I've rebased and added a tiny fix to an edge case we missed before. Should apply now. Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #77 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 62767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62767&action=ed… Bug 11897: Bugfix: Handle empty rotas. * Koha/StockRotationRota.pm (investigate): If current rota has no stages, return empty items & log entries in report. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '17

27 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62730|0 |1 is obsolete| | --- Comment #76 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 62766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62766&action=ed… Bug 11897: Use camel case in Koha namespace modules. * Koha/Item.pm (stockrotationitem, add_to_rota): Use camel case. * Koha/Library.pm (stockrotationstages): Use camel case. * Koha/REST/V1/Stage.pm (move): Use camel case. * Koha/StockRotationItem.pm: New name for 'Koha/Stockrotationitem.pm'. (stage, advance): Use camel case. * Koha/StockRotationItems.pm: New name for 'Koha/Stockrotationitems.pm'. (object_class): Use camel case. * Koha/StockRotationRota.pm: New name for 'Koha/Stockrotationrota.pm'. (stockrotationstages, stockrotationitems, add_item): Use camel case. * Koha/StockRotationRotas.pm: New name for 'Koha/Stockrotationrotas.pm'. (object_class): Use camel case. * Koha/StockRotationStage.pm: New name for 'Koha/Stockrotationstage.pm'. (stockrotationitems, rota, siblings, next_siblings, previous_siblings) (next_sibling, previous_sibling, first_sibling, last_sibling): Use camel case. * Koha/StockRotationStages.pm: New name for 'Koha/Stockrotationstages.pm'. (object_class): Use camel case. * Koha/Util/StockRotation.pm: New name for 'Koha/Util/Stockrotation.pm'. (toggle_indemand, move_to_next_stage, remove_from_stage): Use camel case. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Improve wording. * misc/cronjobs/stockrotation.pl: Use camel case. * catalogue/stockrotation.pl: Use camel case. * tools/stockrotation.pl: Use camel case. * t/db_dependent/Items.t: Use camel case. * t/db_dependent/Koha/Libraries.t: Use camel case. * t/db_dependent/StockRotationItems.t: New name for 't/db_dependent/Stockrotationitems.t' & use camel case. * t/db_dependent/StockRotationRotas.t: New name for 't/db_dependent/Stockrotationrotas.t' & use camel case. * t/db_dependent/StockRotationStages.t: New name for 't/db_dependent/Stockrotationstages.t' & use camel case. * t/db_dependent/api/v1/stockrotationstage.t: Use camel case. -- You are receiving this mail because: You are watching all bug changes.

1 0