April 2017 - Koha-bugs - lists.koha-community.org

[Bug 18486] New: Calendar maintenance script: correct dates
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18486 Bug ID: 18486 Summary: Calendar maintenance script: correct dates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs(a)lists.koha-community.org Reporter: black23(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org User case: Some holiday need to be added just couple of days before. We need tool that corect date of check-ins or pickup days on new the closest working day, if some changes in calendar are made. Script find dates for check-ins and pickups at new holiday and validate them with new schedule. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #18 from Nick Clemens <nick(a)bywatersolutions.com> --- Hi Nancy, We have also worked around this by simply excluding that page from plack, it avoids the issue and allows exports to complete. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to NancyK. from comment #16) > This bug is going to cause us a really big problem. We are doing weekly > exports and have plans for more. Please fix this soon. > Thanks > > NancyK This will not be fixed soon as nobody as a solution. You should consider using the CLI script misc/export_records.pl for your weekly export (with a cronjob even). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2093] Add OPAC dashboard for logged-in users
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #52 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 62709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62709&action=ed… Bug 15395: Fix several issues in translation process - Change location of generated PO files to ease its integration into Pootle (po/xx-XX-messages.po instead of xx_XX/LC_MESSAGES/Koha.po) - Use msginit for PO creation to try to set correctly Plural-Forms header. If it fails, set a default one - 'install' command now creates the PO file if it doesn't already exist - Fix locale name when language code is different from ll-CC (where ll is the language code and CC is the country code). Test plan: 1. `perl translate install ar-Arab` should results in po/ar/LC_MESSAGES/Koha.mo and po/ar-Arab-messages.po 2. `perl translate install gl` should results in po/gl/LC_MESSAGES/Koha.mo and po/gl-messages.po 3. `perl translate install zh-Hans-CN` should results in po/zh_CN/LC_MESSAGES/Koha.mo and po/zh-Hans-CN-messages.po 4. `perl translate install fr-FR` should results in po/fr_FR/LC_MESSAGES/Koha.mo and po/fr-FR-messages.po -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12145] Lock for Move up buttons with Marc tag
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha(a)catalyst.net.nz Assignee|gmcharlt(a)gmail.com |aleisha(a)catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #58 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Finally, there is the added complication of relations and other methods that relate to stockrotation objects: e.g. Koha::Item, line 189 defines the relation between an item and its stock rotation item. That method is currently, quite naturally, called 'stockrotationitem' ("give me the stockrotationitem object associated with this item"). Should this now be: stockRotationItem - this seems terrible and has no precedent, so probably ignore this. stock_rotation_item - so now we introduce yet another name for the same object; just in a different context. And what if we had a method like "stock_rotation_item_index"? Would this be an index of Koha::Items associated with stock rotation, or would this be an index of stockrotationitems? stockrotationitem - leave it as is. But this seems inconsistent with the renaming of the modules themselves. I hope all of this does not come across as pedantic — I guess simply don't know what the right approach is, and I'm not clear whether Koha community has a clear policy on this. If there is, I'm very happy to adopt that. If there isn't, like I say, I have a preference for the approach I've taken so far. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #57 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Also, as an aside, and to potentially save time here, I don't think there is a code guideline about this (pointing us in either direction), though there does seem to be a large precedent to do as you suggest, and only 2 other modules not using camel case in their names. Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #56 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Hi Kyle, I've been playing around with this, and am happy to do so (I will upload a patch to this effect a little later), but from my perspective I'm not a fan of the change: - the database tables are called stockrotationitem etc., so the dbix class files use the non-camel cased versions. - changing the Koha namespace entries to camel case means we now have a separation between dbix classes and the koha object code - when working with the unit test builder interface, you now have to remember to use non camel case, but when using the koha objects you have to use camel case… Also, given that the object is called a 'stockrotationitem' for instance, to me it seems natural that the camel case boundary would be, for instance, StockrotationitemDeliverer. But then maybe the last point is the result of my German background, where ridiculously long compound nouns are not seen as problematic ;-) WDYT? Alex (In reply to Kyle M Hall from comment #55) > Can you please camel case your module names for readability ( e.g. > Koha::StockRotationItem instead of Koha::Stockrotationitem )? > > Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0