April 2017 - Koha-bugs - lists.koha-community.org

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #76 from Nick Clemens <nick(a)bywatersolutions.com> --- a/clubs/clubs-add-modify.pl 47 my $stored = $cgi->param('name') ? $id ? 'updated' : 'stored' : undef; *This is confusing a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt 85 This item is on hold for another borrower. *Should be patron Koha/Template/Plugin/AuthorisedValues.pm 38 my ( $self, $category, $selected, $opac ) = @_; 39 return GetAuthorisedValues( $category, $selected, $opac ); *I think this is rebase error, no 'selected' param now koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: [% IF borrower.get_club_enrollments_count.size || borrower.get_enrollable_clubs(1).size %] *causes error - The method size is not covered by tests *same as above in: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/clubs-tab.tt * borrower.FirstValidEmailAddress is not covered by tests, I think you mean borrower.first_valid_email_address When viewing tools/clubs.pl 1 - The 'New club' button has an empty dropdown until a template is defined, it should be disabled 2 - Once the first template is defined the Clubs table says: " No club templates defined. " - should say "No clubs defined" 3 - Dates for clubs should show in clubs table When adding patrons to clubs - 1 - If no fields are associated with a club you click 'Enroll' then have a new screen with no additional info and must click 'Enroll' again - should be clearer 'Finish enrollment' or something 2 - You should not be able to add a patron to club that is out of date, or they should be hidden by default The feature adds valuable info for reporting, but I think it should have at least one default view, a link from the clubs table to "See patrons enrolled in this club" That link should be copied on the patrons club enrollement tab -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho(a)gmail.com --- Comment #7 from Cab Vinton <bibliwho(a)gmail.com> --- Agreed. Thank you, Kyle! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 --- Comment #6 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 62699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62699&action=ed… Bug 6758 - Update Schema Files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62696|0 |1 is obsolete| | Attachment #62697|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 62698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62698&action=ed… Bug 6758 - Add new patron column for date of renewal Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Create a new patron 4) Note the new column date_renewed is NULL 5) Renew the patron 6) Note the date in the column date_renewed is today's date -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 --- Comment #4 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 62697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62697&action=ed… Bug 6758 - Update Schema Files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 --- Comment #3 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 62696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62696&action=ed… Bug 6758 - Capture membership renewal date for reporting purposes -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|priyanka.nk(a)osslabs.biz |kyle(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |--- CC| |kyle(a)bywatersolutions.com Status|CLOSED |REOPENED --- Comment #2 from Kyle M Hall <kyle(a)bywatersolutions.com> --- It is far more efficient and far easier to have the column in the borrowers table than to join on the action logs for reporting purposes. I din't think this should be closed since Savitra specifically mentions a column for date renewed . -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0