April 2017 - Koha-bugs - lists.koha-community.org

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #57 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Also, as an aside, and to potentially save time here, I don't think there is a code guideline about this (pointing us in either direction), though there does seem to be a large precedent to do as you suggest, and only 2 other modules not using camel case in their names. Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #56 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Hi Kyle, I've been playing around with this, and am happy to do so (I will upload a patch to this effect a little later), but from my perspective I'm not a fan of the change: - the database tables are called stockrotationitem etc., so the dbix class files use the non-camel cased versions. - changing the Koha namespace entries to camel case means we now have a separation between dbix classes and the koha object code - when working with the unit test builder interface, you now have to remember to use non camel case, but when using the koha objects you have to use camel case… Also, given that the object is called a 'stockrotationitem' for instance, to me it seems natural that the camel case boundary would be, for instance, StockrotationitemDeliverer. But then maybe the last point is the result of my German background, where ridiculously long compound nouns are not seen as problematic ;-) WDYT? Alex (In reply to Kyle M Hall from comment #55) > Can you please camel case your module names for readability ( e.g. > Koha::StockRotationItem instead of Koha::Stockrotationitem )? > > Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #51 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #50) > What did I miss? For now you need to run `translate update fr-FR` first to create the PO file, then you need to change the Plural-Forms header, and only after that you can run `translate install` to compile the PO into MO. I think we can avoid the manual step of setting Plural-Forms by using msginit. I'll give it a try. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2093] Add OPAC dashboard for logged-in users
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt(a)gmail.com |aleisha(a)catalyst.net.nz CC| |aleisha(a)catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2093] Add OPAC dashboard for logged-in users
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 --- Comment #3 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 62704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62704&action=ed… Bug 2093: Add OPAC Summary for logged-in users This patch adds a summary to the OPAC once the user has logged in that shows the users number of checkouts, overdues, holds pending, holds waiting and total fines. We also have a syspref OPACUserSummary to turn this feature on and off. Default is ON. To test: 1) Apply patch and update database 2) Set up some checkouts, overdues, holds pending AND waiting and fines for a user 3) Log into OPAC as that user, see summary. Confirm links all work as expected 4) Confirm that if there are no checkouts / overdues etc that the link disappears from the summary 5) Turn OPACUserSummary OFF and confirm the summary does not show on the mainpage. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2093] Add OPAC dashboard for logged-in users
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '17

26 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 NancyK. <nkeener(a)washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nkeener(a)washoecounty.us --- Comment #16 from NancyK. <nkeener(a)washoecounty.us> --- This bug is going to cause us a really big problem. We are doing weekly exports and have plans for more. Please fix this soon. Thanks NancyK -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Allow correct handling of plural translation
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- [kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc/translator (bug_15395) ✭]% perl translate install fr-FR /bin/cp: cannot stat ‘Koha.pot’: No such file or directory /usr/bin/msgfmt: error while opening "/home/vagrant/kohaclone/misc/translator/po/fr_FR/LC_MESSAGES/Koha.po" for reading: No such file or directory /home/vagrant/kohaclone/misc/translator/po2json {-p} {file.po} > {outputfile.json} -p : do pretty-printing of json data What did I miss? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #76 from Nick Clemens <nick(a)bywatersolutions.com> --- a/clubs/clubs-add-modify.pl 47 my $stored = $cgi->param('name') ? $id ? 'updated' : 'stored' : undef; *This is confusing a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt 85 This item is on hold for another borrower. *Should be patron Koha/Template/Plugin/AuthorisedValues.pm 38 my ( $self, $category, $selected, $opac ) = @_; 39 return GetAuthorisedValues( $category, $selected, $opac ); *I think this is rebase error, no 'selected' param now koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: [% IF borrower.get_club_enrollments_count.size || borrower.get_enrollable_clubs(1).size %] *causes error - The method size is not covered by tests *same as above in: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/clubs-tab.tt * borrower.FirstValidEmailAddress is not covered by tests, I think you mean borrower.first_valid_email_address When viewing tools/clubs.pl 1 - The 'New club' button has an empty dropdown until a template is defined, it should be disabled 2 - Once the first template is defined the Clubs table says: " No club templates defined. " - should say "No clubs defined" 3 - Dates for clubs should show in clubs table When adding patrons to clubs - 1 - If no fields are associated with a club you click 'Enroll' then have a new screen with no additional info and must click 'Enroll' again - should be clearer 'Finish enrollment' or something 2 - You should not be able to add a patron to club that is out of date, or they should be hidden by default The feature adds valuable info for reporting, but I think it should have at least one default view, a link from the clubs table to "See patrons enrolled in this club" That link should be copied on the patrons club enrollement tab -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6758] Capture membership renewal date for reporting purposes
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '17

25 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho(a)gmail.com --- Comment #7 from Cab Vinton <bibliwho(a)gmail.com> --- Agreed. Thank you, Kyle! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0