April 2017 - Koha-bugs - lists.koha-community.org

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62196|0 |1 is obsolete| | --- Comment #107 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 62633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62633&action=ed… Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62624|0 |1 is obsolete| | --- Comment #24 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 62630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62630&action=ed… Bug 3311: Followup clean up HTML on page. There should be no validator.w3.org validation issues for this page's source. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18182] New: TestBuilder should be able to return Koha::Object objects
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Bug ID: 18182 Summary: TestBuilder should be able to return Koha::Object objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: tomascohen(a)gmail.com QA Contact: gmcharlt(a)gmail.com There's a common pattern in most tests we write: my $object_hash = $builder->build({ source => 'TheSchema', value => { fixed => values, ... } }); my $id = $object->{the_id_field}; my $object = Koha::Objects->find($id); < the actual tests > It would be handy to have TestBuilder provide a way to actually retrieve the Koha::Object instance. -- You are receiving this mail because: You are watching all bug changes.

1 47

[Bug 13835] Popup with searches: results hidden by language menu in footer
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62582|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 62626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62626&action=ed… Bug 13835: Popup with searches: results hidden by language menu in footer Language menus in pop up windows are not necessary and can hide the contents (especially search results) on a narrow screen. For an example, see screenshot in comment #3 This patch allows to mark pop p menus not to display the language footer. To test: - Reproduce issue from comment #3 - Apply patch - Try to reproduce issue from comment #3 -> language menu should no longer display - Verify that language menu is suppresed in 'Add to ist' as well (from catalog search results, select an item, Add to:...) Note: There will be more pop-ups with unwnated language selector. That can be resolved in follow up bugs. Followed test plan which worked as intended Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13835] Popup with searches: results hidden by language menu in footer
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13835] Popup with searches: results hidden by language menu in footer
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835 --- Comment #7 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- *** Bug 13837 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13837] Popup "Search for garantor" should not display language menu in footer
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13837 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |RESOLVED Resolution|WONTFIX |DUPLICATE CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 13835 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62541|0 |1 is obsolete| | --- Comment #23 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 62624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62624&action=ed… Bug 3311: Followup clean up HTML on page. Should be no validation errors if you paste source code to validator.w3.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62533|0 |1 is obsolete| | --- Comment #22 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 62623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62623&action=ed… Bug 3311: Form validation feedback By using the validated class, make use of jquery form submission validation to inform user of required fields. TEST PLAN --------- 1) run Home -> Reports -> Catalog -> Submit -- no meaningful output and no error messages. 2) apply patch 3) repeat 1 -- meaningful error messages appear. -- headings are in red, indicative of required values. 4) try other combinations of row or column selected/unselected. -- meaningful error messages. 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14791] Automatically attempt to resend failed notices
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #11 from Lari Taskula <lari.taskula(a)jns.fi> --- Removed dependency to Bug 13995 and rebased patch to use Koha::Exceptions instead. Switched to Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0