April 2017 - Koha-bugs - lists.koha-community.org

[Bug 14791] Automatically attempt to resend failed notices
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42698|0 |1 is obsolete| | --- Comment #9 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 62615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62615&action=ed… Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers Sometimes notices keep failing due to various reasons. One common problem is network connection failures. Because of this, the notices go into 'failed' status without another attempt for sending. This is very problematic, because we have to not only monitor the failed messages but also resend them manually. The purpose of this patch is to move us into more automated way of handling delivery failures. This patch enables us to handle exceptions in SMS messaging. The main idea is to throw an exception from SMS::Send driver in case of a failure. The exception will be caught by C4::SMS and from here it will be forwarded to C4::Letters where instead of automatically setting the message into 'failed' status, we now can do as we wish with various exceptions. As an example I have caught Koha::Exception::ConnectionFailed in C4::Letters::_send_message_by_sms(). When we catch the said exception, we simply leave the message in 'pending' status. This way it will be resent whenever process_message_queue.pl is executed again. There are multiple other reasons of failure where Exceptions will come in handy. For example the SMS Gateway provider may return some errors at request, and with this patch we will be able to handle them better. Below is a short example for making your SMS::Send driver throw an exception in case of a connection failure in SMS/Send/MyDriver/Driver.pm. _______________________________________________________________ use Koha::Exception::ConnectionFailed; sub send_sms { #.....your implementation..... # Throw an exception in case of a connection error # $connError can be for example: ($curl->{'retcode'} == 6) # cURL code 6: CURLE_COULDNT_RESOLVE_HOST if ($connError){ Koha::Exception::ConnectionFailed->throw(error => "Connection failed"); } #.....your implementation..... } _______________________________________________________________ prerequisites: -2. Set system preference SMSSendDriver to Example::ExceptionExample -1. Enable system preference EnhancedMessagingPreferences To test: 1. Have/create some pending sms messages into message_queue 2. Go to Patrons -> Notices 3. Observe that the your message is in pending status 4. Apply patch 5. Run misc/cronjob/process_message_queue.pl 6. Observe that your message is still in pending status You can also test it with your own implementation of SMSSendDriver. What you need to do is follow the example mentioned earlier to make send_sms() subroutine throw Koha::Exception::ConnectionFailed in case of a connection failure. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #55 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Can you please camel case your module names for readability ( e.g. Koha::StockRotationItem instead of Koha::Stockrotationitem )? Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11580] returnBeforeExpiry and closed day
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard <oleonard(a)myacpl.org> --- Setting to 'Failed QA' based on Comment 8 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10267] No error message when entering an invalid cardnumber
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Aleisha, the last case is wrong, maxlength_cardnumber is evaluated false and the message will be "Card number must not be more than characters". That should not be possible (because C4::Members::get_cardnumber_length returns max=16), but the code does not make sense as it is. Moreover you should not use the keypress event but change, that way a paste or delete in the input will update the message as well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18481] New: Unable to pay full fine amount.
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18481 Bug ID: 18481 Summary: Unable to pay full fine amount. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 62565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62565&action=ed… Inability to pay full amount. It won't let me pay full for $7.56... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 3379] Rounding error for fines total in C4::Members:: GetMemberAccountRecords
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3379 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18481 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18481 [Bug 18481] Unable to pay full fine amount. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18487] New: GetMemberAccountRecords returning imprecise amount - causing pay issue
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18487 Bug ID: 18487 Summary: GetMemberAccountRecords returning imprecise amount - causing pay issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To recreate: Create a manual invoice for 7.56 Pay fines, 'pay amount' Attempt to pay 7.56 You get an error "amount paid must be less than or equal to 7.56" Verify you can pay 7.55 - or 7.57 if you owe 7.57, but not 7.56 if you owe 7.56 Turns out $total_due is being fetched as '7.5599' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #23 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Hi Daphne, Thank you very much for taking the time to test! I've added some comments in line. (In reply to Daphne Hoolahan from comment #22) > It all went pretty good and worked fine. > > We just found a couple of things that are worth pointing out: > > 6.1.1 – Why is the biblio number empty on this screen? Actually one of them > has the value zero now that we went through the whole process. The biblio number would be the number that a library assigns to an ILL when they receive it, before they lend it out to a borrower. As a result, the ILLmodule will just allow it to be empty and never assigns a value to it. It is the librarian that manually assigns a number to it. I need to investigate why the biblio is set to 0 in more detail, but I believe this is because a blank field is converted to a 0 at some point in conversion from form input to koha object. > 6.1.2 – we noticed that we could request the same title more than once. > Maybe not an issue but worth mentioning. Indeed — the module currently carries out no validation. This might be an interesting enhancement at a later stage! > 6.1.9 – we received the email fine but it does not say who it is from, ther > than it has the from email address. Should it have the from organisation > above the status or is the staff member expected to customise the email text > to indicate their organisation? > > Dear Sir/Madam, > > We would like to request an interlibrary loan for a title matching the > following description: > > - Status: New > - Author: A.N. Other > - ID: 5678 > - Title: Interlibrary loans in Koha > > Please let us know if you are able to supply this to us. > > Kind Regards The email headers (from address) should be set at the server level. I.e. changing the server configuration should fix that issue. Having said that, it may well be a good idea to add a hard-coded block with the libraries delivery address to this template. A future patch should use notice templates to allow customization of these emails. > 6.2 – We found it difficult to find any matching titles. What is keywords > for? (especially as title has a separate entry field) The keywords field should just search "anywhere". Adding more keywords should significantly reduce the number of hits. The searches against the test system will be searching against the British Library test API — which I'm very confident has an extremely limited result set. I believe that explains the difficulty you had in finding results? > image attached > > Also we got an error when we tried this search – didn’t seem to like the > book filter: > Error performing operation > image attached > > When trying to confirm a request from the BL > > Software error: > > The API responded with an error: 500 Internal Server Error > Detail: <?xml version="1.0" > encoding="UTF-8"?><apiResponse><timestamp>2017-03-28 13:15:56.941 > BST</timestamp><status>8</status><message>Authentication failed: Exception > occurred processing authentication, please contact BL Customer > Services</message><result /></apiResponse> at > /usr/share/koha-interleaf/Koha/Illbackends/BLDSS/Base.pm line 481. > For help, please send mail to the webmaster > (alex.sassmannshausen(a)ptfs-europe.com) giving this error message and the > time and date of the error. This is a peculiar error message, as it's to do with authentication. I expect a great number of request confirmations against the BL test system to fail, but normally with different error messages. I will investigate this issue in more detail. I will also add a block with library details to the generic email template. Probably just after the "Kind regards". What do you think? Best wishes, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3379] Rounding error for fines total in C4::Members:: GetMemberAccountRecords
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3379 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18487 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18487 [Bug 18487] GetMemberAccountRecords returning imprecise amount - causing pay issue -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Ray Delahunty <r.delahunty(a)arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty(a)arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.

1 0